summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2019-06-13 21:59:18 +0200
committerGerrit Code Review <noreply-gerritcodereview@google.com>2019-06-13 21:59:18 +0200
commit053ea111a716b91fea9fbe2f7e3a7996baf83821 (patch)
treeae3bdceb42799992b9a72f23b01e754b2527c946
parentMerge "Avoid key_queue_mutex deadlock in waitkey()" (diff)
parentUse the new ziparchive Next std::string_view overload. (diff)
downloadandroid_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.tar
android_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.tar.gz
android_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.tar.bz2
android_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.tar.lz
android_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.tar.xz
android_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.tar.zst
android_bootable_recovery-053ea111a716b91fea9fbe2f7e3a7996baf83821.zip
-rw-r--r--install/install.cpp2
-rw-r--r--install/verifier.cpp2
2 files changed, 2 insertions, 2 deletions
diff --git a/install/install.cpp b/install/install.cpp
index 8d46641dc..445f3ab34 100644
--- a/install/install.cpp
+++ b/install/install.cpp
@@ -539,7 +539,7 @@ bool verify_package_compatibility(ZipArchiveHandle package_zip) {
std::vector<std::string> compatibility_info;
ZipEntry info_entry;
- std::string info_name;
+ std::string_view info_name;
while (Next(cookie, &info_entry, &info_name) == 0) {
std::string content(info_entry.uncompressed_length, '\0');
int32_t ret = ExtractToMemory(zip_handle, &info_entry, reinterpret_cast<uint8_t*>(&content[0]),
diff --git a/install/verifier.cpp b/install/verifier.cpp
index 02759cdc2..ab750442d 100644
--- a/install/verifier.cpp
+++ b/install/verifier.cpp
@@ -320,7 +320,7 @@ static std::vector<Certificate> IterateZipEntriesAndSearchForKeys(const ZipArchi
std::vector<Certificate> result;
- std::string name;
+ std::string_view name;
ZipEntry entry;
while ((iter_status = Next(cookie, &entry, &name)) == 0) {
std::vector<uint8_t> pem_content(entry.uncompressed_length);