summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTreehugger Robot <treehugger-gerrit@google.com>2021-12-02 21:25:27 +0100
committerGerrit Code Review <noreply-gerritcodereview@google.com>2021-12-02 21:25:27 +0100
commit5bd36e04bed97da9692b128986c72bd22055ecc4 (patch)
tree29737ebfd0155e16e6c19a49178f3cc2f86a645c
parentMerge changes from topic "servicemanager-recovery" (diff)
parentAvoid to format raw disk if metadata encryption is enabled (diff)
downloadandroid_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.tar
android_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.tar.gz
android_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.tar.bz2
android_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.tar.lz
android_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.tar.xz
android_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.tar.zst
android_bootable_recovery-5bd36e04bed97da9692b128986c72bd22055ecc4.zip
-rw-r--r--recovery_utils/roots.cpp20
1 files changed, 20 insertions, 0 deletions
diff --git a/recovery_utils/roots.cpp b/recovery_utils/roots.cpp
index 0b82c1ccd..d761e7525 100644
--- a/recovery_utils/roots.cpp
+++ b/recovery_utils/roots.cpp
@@ -34,6 +34,7 @@
#include <android-base/stringprintf.h>
#include <android-base/unique_fd.h>
#include <ext4_utils/ext4_utils.h>
+#include <ext4_utils/wipe.h>
#include <fs_mgr.h>
#include <fs_mgr/roots.h>
@@ -176,6 +177,25 @@ int format_volume(const std::string& volume, const std::string& directory) {
}
}
+ // If the raw disk will be used as a metadata encrypted device mapper target,
+ // next boot will do encrypt_in_place the raw disk which gives a subtle duration
+ // to get any failure in the process. In order to avoid it, let's simply wipe
+ // the raw disk if we don't reserve any space, which behaves exactly same as booting
+ // after "fastboot -w".
+ if (!v->metadata_encryption.empty() && length == 0) {
+ android::base::unique_fd fd(open(v->blk_device.c_str(), O_RDWR));
+ if (fd == -1) {
+ PLOG(ERROR) << "format_volume: failed to open " << v->blk_device;
+ return -1;
+ }
+ int64_t device_size = get_file_size(fd.get(), 0);
+ if (device_size > 0 && !wipe_block_device(fd.get(), device_size)) {
+ LOG(INFO) << "format_volume: wipe metadata encrypted " << v->blk_device << " with size "
+ << device_size;
+ return 0;
+ }
+ }
+
if (v->fs_type == "ext4") {
static constexpr int kBlockSize = 4096;
std::vector<std::string> mke2fs_args = {