summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2019-03-13 05:54:03 +0100
committerandroid-build-merger <android-build-merger@google.com>2019-03-13 05:54:03 +0100
commit682cd4fbc463a0ad2e225c360264335c2606b335 (patch)
treebf40af1a74130b62db507c47f4af792de94bb380
parentMerge "minui: Managed FDs with smart pointers." (diff)
parentMerge "Use the package class for wipe packages" (diff)
downloadandroid_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.tar
android_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.tar.gz
android_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.tar.bz2
android_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.tar.lz
android_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.tar.xz
android_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.tar.zst
android_bootable_recovery-682cd4fbc463a0ad2e225c360264335c2606b335.zip
-rw-r--r--install.h2
-rw-r--r--recovery.cpp55
-rw-r--r--tests/component/install_test.cpp5
3 files changed, 26 insertions, 36 deletions
diff --git a/install.h b/install.h
index 7b6267bf1..da8aa5e39 100644
--- a/install.h
+++ b/install.h
@@ -57,7 +57,7 @@ bool verify_package(Package* package);
bool ReadMetadataFromPackage(ZipArchiveHandle zip, std::map<std::string, std::string>* metadata);
// Reads the "recovery.wipe" entry in the zip archive returns a list of partitions to wipe.
-std::vector<std::string> GetWipePartitionList(const std::string& wipe_package);
+std::vector<std::string> GetWipePartitionList(Package* wipe_package);
// Verifies the compatibility info in a Treble-compatible package. Returns true directly if the
// entry doesn't exist.
diff --git a/recovery.cpp b/recovery.cpp
index 2c9f9de68..0074b6433 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -498,41 +498,36 @@ static bool secure_wipe_partition(const std::string& partition) {
return true;
}
-static std::string ReadWipePackage(size_t wipe_package_size) {
+static std::unique_ptr<Package> ReadWipePackage(size_t wipe_package_size) {
if (wipe_package_size == 0) {
LOG(ERROR) << "wipe_package_size is zero";
- return "";
+ return nullptr;
}
std::string wipe_package;
std::string err_str;
if (!read_wipe_package(&wipe_package, wipe_package_size, &err_str)) {
PLOG(ERROR) << "Failed to read wipe package" << err_str;
- return "";
+ return nullptr;
}
- return wipe_package;
+
+ return Package::CreateMemoryPackage(
+ std::vector<uint8_t>(wipe_package.begin(), wipe_package.end()), nullptr);
}
// Checks if the wipe package matches expectation. If the check passes, reads the list of
// partitions to wipe from the package. Checks include
// 1. verify the package.
// 2. check metadata (ota-type, pre-device and serial number if having one).
-static bool CheckWipePackage(const std::string& wipe_package) {
- auto package = Package::CreateMemoryPackage(
- std::vector<uint8_t>(wipe_package.begin(), wipe_package.end()), nullptr);
-
- if (!package || !verify_package(package.get())) {
+static bool CheckWipePackage(Package* wipe_package) {
+ if (!verify_package(wipe_package)) {
LOG(ERROR) << "Failed to verify package";
return false;
}
- // TODO(xunchang) get zip archive from package.
- ZipArchiveHandle zip;
- if (auto err =
- OpenArchiveFromMemory(const_cast<void*>(static_cast<const void*>(&wipe_package[0])),
- wipe_package.size(), "wipe_package", &zip);
- err != 0) {
- LOG(ERROR) << "Can't open wipe package : " << ErrorCodeString(err);
+ ZipArchiveHandle zip = wipe_package->GetZipArchiveHandle();
+ if (!zip) {
+ LOG(ERROR) << "Failed to get ZipArchiveHandle";
return false;
}
@@ -542,19 +537,13 @@ static bool CheckWipePackage(const std::string& wipe_package) {
return false;
}
- int result = CheckPackageMetadata(metadata, OtaType::BRICK);
- CloseArchive(zip);
-
- return result == 0;
+ return CheckPackageMetadata(metadata, OtaType::BRICK) == 0;
}
-std::vector<std::string> GetWipePartitionList(const std::string& wipe_package) {
- ZipArchiveHandle zip;
- if (auto err =
- OpenArchiveFromMemory(const_cast<void*>(static_cast<const void*>(&wipe_package[0])),
- wipe_package.size(), "wipe_package", &zip);
- err != 0) {
- LOG(ERROR) << "Can't open wipe package : " << ErrorCodeString(err);
+std::vector<std::string> GetWipePartitionList(Package* wipe_package) {
+ ZipArchiveHandle zip = wipe_package->GetZipArchiveHandle();
+ if (!zip) {
+ LOG(ERROR) << "Failed to get ZipArchiveHandle";
return {};
}
@@ -571,7 +560,6 @@ std::vector<std::string> GetWipePartitionList(const std::string& wipe_package) {
err != 0) {
LOG(ERROR) << "Failed to extract " << RECOVERY_WIPE_ENTRY_NAME << ": "
<< ErrorCodeString(err);
- CloseArchive(zip);
return {};
}
} else {
@@ -581,7 +569,6 @@ std::vector<std::string> GetWipePartitionList(const std::string& wipe_package) {
static constexpr const char* RECOVERY_WIPE_ON_DEVICE = "/etc/recovery.wipe";
if (!android::base::ReadFileToString(RECOVERY_WIPE_ON_DEVICE, &partition_list_content)) {
PLOG(ERROR) << "failed to read \"" << RECOVERY_WIPE_ON_DEVICE << "\"";
- CloseArchive(zip);
return {};
}
}
@@ -597,7 +584,6 @@ std::vector<std::string> GetWipePartitionList(const std::string& wipe_package) {
result.push_back(line);
}
- CloseArchive(zip);
return result;
}
@@ -606,17 +592,18 @@ static bool wipe_ab_device(size_t wipe_package_size) {
ui->SetBackground(RecoveryUI::ERASING);
ui->SetProgressType(RecoveryUI::INDETERMINATE);
- std::string wipe_package = ReadWipePackage(wipe_package_size);
- if (wipe_package.empty()) {
+ auto wipe_package = ReadWipePackage(wipe_package_size);
+ if (!wipe_package) {
+ LOG(ERROR) << "Failed to open wipe package";
return false;
}
- if (!CheckWipePackage(wipe_package)) {
+ if (!CheckWipePackage(wipe_package.get())) {
LOG(ERROR) << "Failed to verify wipe package";
return false;
}
- std::vector<std::string> partition_list = GetWipePartitionList(wipe_package);
+ auto partition_list = GetWipePartitionList(wipe_package.get());
if (partition_list.empty()) {
LOG(ERROR) << "Empty wipe ab partition list";
return false;
diff --git a/tests/component/install_test.cpp b/tests/component/install_test.cpp
index 117813694..969805b42 100644
--- a/tests/component/install_test.cpp
+++ b/tests/component/install_test.cpp
@@ -120,7 +120,10 @@ TEST(InstallTest, read_wipe_ab_partition_list) {
std::string wipe_package;
ASSERT_TRUE(android::base::ReadFileToString(temp_file.path, &wipe_package));
- std::vector<std::string> read_partition_list = GetWipePartitionList(wipe_package);
+ auto package = Package::CreateMemoryPackage(
+ std::vector<uint8_t>(wipe_package.begin(), wipe_package.end()), nullptr);
+
+ auto read_partition_list = GetWipePartitionList(package.get());
std::vector<std::string> expected = {
"/dev/block/bootdevice/by-name/system_a", "/dev/block/bootdevice/by-name/system_b",
"/dev/block/bootdevice/by-name/vendor_a", "/dev/block/bootdevice/by-name/vendor_b",