diff options
author | Tao Bao <tbao@google.com> | 2018-07-12 00:13:35 +0200 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-07-12 00:13:35 +0200 |
commit | a9f9acca91d04ef5b7c626d5af65c6d399801dea (patch) | |
tree | de107da565599b010b1c991a23f82460633a215f /applypatch | |
parent | Merge "updater: Let read_file() return Value::Type::STRING." (diff) | |
parent | Remove the debug code for bspatch flakiness (diff) | |
download | android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.tar android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.tar.gz android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.tar.bz2 android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.tar.lz android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.tar.xz android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.tar.zst android_bootable_recovery-a9f9acca91d04ef5b7c626d5af65c6d399801dea.zip |
Diffstat (limited to 'applypatch')
-rw-r--r-- | applypatch/applypatch.cpp | 13 | ||||
-rw-r--r-- | applypatch/imgpatch.cpp | 21 |
2 files changed, 2 insertions, 32 deletions
diff --git a/applypatch/applypatch.cpp b/applypatch/applypatch.cpp index b1f5607a6..eb0a2a7b5 100644 --- a/applypatch/applypatch.cpp +++ b/applypatch/applypatch.cpp @@ -587,11 +587,6 @@ static int GenerateTarget(const FileContents& source_file, const std::unique_ptr SHA_CTX ctx; SHA1_Init(&ctx); SinkFn sink = [&memory_sink_str, &ctx](const unsigned char* data, size_t len) { - if (len != 0) { - uint8_t digest[SHA_DIGEST_LENGTH]; - SHA1(data, len, digest); - LOG(DEBUG) << "Appending " << len << " bytes data, SHA-1: " << short_sha1(digest); - } SHA1_Update(&ctx, data, len); memory_sink_str.append(reinterpret_cast<const char*>(data), len); return len; @@ -632,14 +627,6 @@ static int GenerateTarget(const FileContents& source_file, const std::unique_ptr << short_sha1(bonus_digest); } - // TODO(b/67849209) Remove after debugging the unit test flakiness. - if (android::base::GetMinimumLogSeverity() <= android::base::LogSeverity::DEBUG) { - if (WriteToPartition(reinterpret_cast<const unsigned char*>(memory_sink_str.c_str()), - memory_sink_str.size(), target_filename) != 0) { - LOG(DEBUG) << "Failed to write patched data " << target_filename; - } - } - return 1; } else { LOG(INFO) << " now " << short_sha1(target_sha1); diff --git a/applypatch/imgpatch.cpp b/applypatch/imgpatch.cpp index da7569219..e6be39a2f 100644 --- a/applypatch/imgpatch.cpp +++ b/applypatch/imgpatch.cpp @@ -61,11 +61,6 @@ static bool ApplyBSDiffPatchAndStreamOutput(const uint8_t* src_data, size_t src_ int mem_level = Read4(deflate_header + 52); int strategy = Read4(deflate_header + 56); - // TODO(b/67849209) Remove after debugging the unit test flakiness. - if (android::base::GetMinimumLogSeverity() <= android::base::LogSeverity::DEBUG) { - LOG(DEBUG) << "zlib version " << zlibVersion(); - } - z_stream strm; strm.zalloc = Z_NULL; strm.zfree = Z_NULL; @@ -83,10 +78,8 @@ static bool ApplyBSDiffPatchAndStreamOutput(const uint8_t* src_data, size_t src_ size_t actual_target_length = 0; size_t total_written = 0; static constexpr size_t buffer_size = 32768; - SHA_CTX sha_ctx; - SHA1_Init(&sha_ctx); auto compression_sink = [&strm, &actual_target_length, &expected_target_length, &total_written, - &ret, &sink, &sha_ctx](const uint8_t* data, size_t len) -> size_t { + &ret, &sink](const uint8_t* data, size_t len) -> size_t { // The input patch length for an update never exceeds INT_MAX. strm.avail_in = len; strm.next_in = data; @@ -113,11 +106,6 @@ static bool ApplyBSDiffPatchAndStreamOutput(const uint8_t* src_data, size_t src_ } } while ((strm.avail_in != 0 || strm.avail_out == 0) && ret != Z_STREAM_END); - // TODO(b/67849209) Remove after debugging the unit test flakiness. - if (android::base::GetMinimumLogSeverity() <= android::base::LogSeverity::DEBUG) { - SHA1_Update(&sha_ctx, data, len); - } - actual_target_length += len; return len; }; @@ -125,11 +113,6 @@ static bool ApplyBSDiffPatchAndStreamOutput(const uint8_t* src_data, size_t src_ int bspatch_result = ApplyBSDiffPatch(src_data, src_len, patch, patch_offset, compression_sink); deflateEnd(&strm); - if (android::base::GetMinimumLogSeverity() <= android::base::LogSeverity::DEBUG) { - uint8_t digest[SHA_DIGEST_LENGTH]; - SHA1_Final(digest, &sha_ctx); - LOG(DEBUG) << "sha1 of " << actual_target_length << " bytes input data: " << short_sha1(digest); - } if (bspatch_result != 0) { return false; } @@ -144,7 +127,7 @@ static bool ApplyBSDiffPatchAndStreamOutput(const uint8_t* src_data, size_t src_ << actual_target_length; return false; } - LOG(DEBUG) << "bspatch writes " << total_written << " bytes in total to streaming output."; + LOG(DEBUG) << "bspatch wrote " << total_written << " bytes in total to streaming output."; return true; } |