diff options
author | android-build-team Robot <android-build-team-robot@google.com> | 2018-01-31 18:23:38 +0100 |
---|---|---|
committer | android-build-team Robot <android-build-team-robot@google.com> | 2018-01-31 18:23:38 +0100 |
commit | d3997ffbce4e3703881e615f03c7477331dcdf9c (patch) | |
tree | 8413d33e74901d2960a7f5f7e6232a8791b13588 /edify/expr.cpp | |
parent | merge in pi-release history after reset to master (diff) | |
parent | Merge "Avoid overwrite of the error message in AbortFn" am: bded087f7d am: 20af3722d8 (diff) | |
download | android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.tar android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.tar.gz android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.tar.bz2 android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.tar.lz android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.tar.xz android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.tar.zst android_bootable_recovery-d3997ffbce4e3703881e615f03c7477331dcdf9c.zip |
Diffstat (limited to '')
-rw-r--r-- | edify/expr.cpp | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/edify/expr.cpp b/edify/expr.cpp index 1b8623f03..6823b7339 100644 --- a/edify/expr.cpp +++ b/edify/expr.cpp @@ -114,9 +114,9 @@ Value* IfElseFn(const char* name, State* state, const std::vector<std::unique_pt Value* AbortFn(const char* name, State* state, const std::vector<std::unique_ptr<Expr>>& argv) { std::string msg; if (!argv.empty() && Evaluate(state, argv[0], &msg)) { - state->errmsg = msg; + state->errmsg += msg; } else { - state->errmsg = "called abort()"; + state->errmsg += "called abort()"; } return nullptr; } @@ -410,12 +410,15 @@ Value* ErrorAbort(State* state, const char* format, ...) { } Value* ErrorAbort(State* state, CauseCode cause_code, const char* format, ...) { - va_list ap; - va_start(ap, format); - android::base::StringAppendV(&state->errmsg, format, ap); - va_end(ap); - state->cause_code = cause_code; - return nullptr; + std::string err_message; + va_list ap; + va_start(ap, format); + android::base::StringAppendV(&err_message, format, ap); + va_end(ap); + // Ensure that there's exactly one line break at the end of the error message. + state->errmsg = android::base::Trim(err_message) + "\n"; + state->cause_code = cause_code; + return nullptr; } State::State(const std::string& script, void* cookie) |