diff options
author | Tianjie Xu <xunchang@google.com> | 2018-01-30 22:44:02 +0100 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2018-01-30 22:44:02 +0100 |
commit | bded087f7de69fc352c5860659e2db4478b30bdd (patch) | |
tree | 26ebc8890fcc2fdf5357494abc6bda180249c505 /edify | |
parent | Merge "Add update_channel field to bootloader_message_ab." (diff) | |
parent | Avoid overwrite of the error message in AbortFn (diff) | |
download | android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.tar android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.tar.gz android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.tar.bz2 android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.tar.lz android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.tar.xz android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.tar.zst android_bootable_recovery-bded087f7de69fc352c5860659e2db4478b30bdd.zip |
Diffstat (limited to '')
-rw-r--r-- | edify/expr.cpp | 19 |
1 files changed, 11 insertions, 8 deletions
diff --git a/edify/expr.cpp b/edify/expr.cpp index 1b8623f03..6823b7339 100644 --- a/edify/expr.cpp +++ b/edify/expr.cpp @@ -114,9 +114,9 @@ Value* IfElseFn(const char* name, State* state, const std::vector<std::unique_pt Value* AbortFn(const char* name, State* state, const std::vector<std::unique_ptr<Expr>>& argv) { std::string msg; if (!argv.empty() && Evaluate(state, argv[0], &msg)) { - state->errmsg = msg; + state->errmsg += msg; } else { - state->errmsg = "called abort()"; + state->errmsg += "called abort()"; } return nullptr; } @@ -410,12 +410,15 @@ Value* ErrorAbort(State* state, const char* format, ...) { } Value* ErrorAbort(State* state, CauseCode cause_code, const char* format, ...) { - va_list ap; - va_start(ap, format); - android::base::StringAppendV(&state->errmsg, format, ap); - va_end(ap); - state->cause_code = cause_code; - return nullptr; + std::string err_message; + va_list ap; + va_start(ap, format); + android::base::StringAppendV(&err_message, format, ap); + va_end(ap); + // Ensure that there's exactly one line break at the end of the error message. + state->errmsg = android::base::Trim(err_message) + "\n"; + state->cause_code = cause_code; + return nullptr; } State::State(const std::string& script, void* cookie) |