diff options
| -rw-r--r-- | Android.mk | 12 | ||||
| -rw-r--r-- | bootloader.cpp | 235 | ||||
| -rw-r--r-- | bootloader.h | 75 | ||||
| -rw-r--r-- | bootloader_message/Android.mk | 24 | ||||
| -rw-r--r-- | bootloader_message/include/bootloader_message/bootloader_message.h | 99 | ||||
| -rw-r--r-- | recovery.cpp | 44 | ||||
| -rw-r--r-- | uncrypt/Android.mk | 11 | ||||
| -rw-r--r-- | uncrypt/bootloader_message_writer.cpp (renamed from bootloader_message/bootloader_message.cpp) | 70 | ||||
| -rw-r--r-- | uncrypt/include/bootloader_message_writer.h | 36 | ||||
| -rw-r--r-- | uncrypt/uncrypt.cpp | 2 | ||||
| -rw-r--r-- | updater/install.cpp | 2 |
11 files changed, 382 insertions, 228 deletions
diff --git a/Android.mk b/Android.mk index 589bff41f..9a064f236 100644 --- a/Android.mk +++ b/Android.mk @@ -31,6 +31,7 @@ include $(CLEAR_VARS) LOCAL_SRC_FILES := \ adb_install.cpp \ asn1_decoder.cpp \ + bootloader.cpp \ device.cpp \ fuse_sdcard_provider.cpp \ install.cpp \ @@ -65,7 +66,6 @@ LOCAL_C_INCLUDES += \ LOCAL_STATIC_LIBRARIES := \ libbatterymonitor \ - libbootloader_message \ libext4_utils_static \ libsparse_static \ libminzip \ @@ -143,17 +143,15 @@ LOCAL_SRC_FILES := \ LOCAL_STATIC_LIBRARIES := libcrypto_static include $(BUILD_STATIC_LIBRARY) -include \ - $(LOCAL_PATH)/applypatch/Android.mk \ - $(LOCAL_PATH)/bootloader_message/Android.mk \ - $(LOCAL_PATH)/edify/Android.mk \ - $(LOCAL_PATH)/minui/Android.mk \ +include $(LOCAL_PATH)/minui/Android.mk \ $(LOCAL_PATH)/minzip/Android.mk \ $(LOCAL_PATH)/minadbd/Android.mk \ $(LOCAL_PATH)/mtdutils/Android.mk \ - $(LOCAL_PATH)/otafault/Android.mk \ $(LOCAL_PATH)/tests/Android.mk \ $(LOCAL_PATH)/tools/Android.mk \ + $(LOCAL_PATH)/edify/Android.mk \ $(LOCAL_PATH)/uncrypt/Android.mk \ + $(LOCAL_PATH)/otafault/Android.mk \ $(LOCAL_PATH)/updater/Android.mk \ $(LOCAL_PATH)/update_verifier/Android.mk \ + $(LOCAL_PATH)/applypatch/Android.mk diff --git a/bootloader.cpp b/bootloader.cpp new file mode 100644 index 000000000..f6c0e9341 --- /dev/null +++ b/bootloader.cpp @@ -0,0 +1,235 @@ +/* + * Copyright (C) 2008 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <errno.h> +#include <fcntl.h> +#include <inttypes.h> +#include <stdio.h> +#include <string.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <unistd.h> + +#include <fs_mgr.h> + +#include <android-base/file.h> + +#include "bootloader.h" +#include "common.h" +#include "mtdutils/mtdutils.h" +#include "roots.h" +#include "unique_fd.h" + +static int get_bootloader_message_mtd(bootloader_message* out, const Volume* v); +static int set_bootloader_message_mtd(const bootloader_message* in, const Volume* v); +static bool read_misc_partition(const Volume* v, size_t offset, size_t size, std::string* out); +static bool write_misc_partition(const Volume* v, size_t offset, const std::string& in); + +int get_bootloader_message(bootloader_message* out) { + Volume* v = volume_for_path("/misc"); + if (v == nullptr) { + LOGE("Cannot load volume /misc!\n"); + return -1; + } + if (strcmp(v->fs_type, "mtd") == 0) { + return get_bootloader_message_mtd(out, v); + } else if (strcmp(v->fs_type, "emmc") == 0) { + std::string s; + if (!read_misc_partition(v, BOOTLOADER_MESSAGE_OFFSET_IN_MISC, sizeof(bootloader_message), + &s)) { + return -1; + } + memcpy(out, s.data(), s.size()); + return 0; + } + LOGE("Unknown misc partition fs_type \"%s\"\n", v->fs_type); + return -1; +} + +bool read_wipe_package(size_t size, std::string* out) { + Volume* v = volume_for_path("/misc"); + if (v == nullptr) { + LOGE("Cannot load volume /misc!\n"); + return false; + } + if (strcmp(v->fs_type, "mtd") == 0) { + LOGE("Read wipe package on mtd is not supported.\n"); + return false; + } else if (strcmp(v->fs_type, "emmc") == 0) { + return read_misc_partition(v, WIPE_PACKAGE_OFFSET_IN_MISC, size, out); + } + LOGE("Unknown misc partition fs_type \"%s\"\n", v->fs_type); + return false; +} + +int set_bootloader_message(const bootloader_message* in) { + Volume* v = volume_for_path("/misc"); + if (v == nullptr) { + LOGE("Cannot load volume /misc!\n"); + return -1; + } + if (strcmp(v->fs_type, "mtd") == 0) { + return set_bootloader_message_mtd(in, v); + } else if (strcmp(v->fs_type, "emmc") == 0) { + std::string s(reinterpret_cast<const char*>(in), sizeof(*in)); + bool success = write_misc_partition(v, BOOTLOADER_MESSAGE_OFFSET_IN_MISC, s); + return success ? 0 : -1; + } + LOGE("Unknown misc partition fs_type \"%s\"\n", v->fs_type); + return -1; +} + +// ------------------------------ +// for misc partitions on MTD +// ------------------------------ + +static const int MISC_PAGES = 3; // number of pages to save +static const int MISC_COMMAND_PAGE = 1; // bootloader command is this page + +static int get_bootloader_message_mtd(bootloader_message* out, + const Volume* v) { + size_t write_size; + mtd_scan_partitions(); + const MtdPartition* part = mtd_find_partition_by_name(v->blk_device); + if (part == nullptr || mtd_partition_info(part, nullptr, nullptr, &write_size)) { + LOGE("failed to find \"%s\"\n", v->blk_device); + return -1; + } + + MtdReadContext* read = mtd_read_partition(part); + if (read == nullptr) { + LOGE("failed to open \"%s\": %s\n", v->blk_device, strerror(errno)); + return -1; + } + + const ssize_t size = write_size * MISC_PAGES; + char data[size]; + ssize_t r = mtd_read_data(read, data, size); + if (r != size) LOGE("failed to read \"%s\": %s\n", v->blk_device, strerror(errno)); + mtd_read_close(read); + if (r != size) return -1; + + memcpy(out, &data[write_size * MISC_COMMAND_PAGE], sizeof(*out)); + return 0; +} +static int set_bootloader_message_mtd(const bootloader_message* in, + const Volume* v) { + size_t write_size; + mtd_scan_partitions(); + const MtdPartition* part = mtd_find_partition_by_name(v->blk_device); + if (part == nullptr || mtd_partition_info(part, nullptr, nullptr, &write_size)) { + LOGE("failed to find \"%s\"\n", v->blk_device); + return -1; + } + + MtdReadContext* read = mtd_read_partition(part); + if (read == nullptr) { + LOGE("failed to open \"%s\": %s\n", v->blk_device, strerror(errno)); + return -1; + } + + ssize_t size = write_size * MISC_PAGES; + char data[size]; + ssize_t r = mtd_read_data(read, data, size); + if (r != size) LOGE("failed to read \"%s\": %s\n", v->blk_device, strerror(errno)); + mtd_read_close(read); + if (r != size) return -1; + + memcpy(&data[write_size * MISC_COMMAND_PAGE], in, sizeof(*in)); + + MtdWriteContext* write = mtd_write_partition(part); + if (write == nullptr) { + LOGE("failed to open \"%s\": %s\n", v->blk_device, strerror(errno)); + return -1; + } + if (mtd_write_data(write, data, size) != size) { + LOGE("failed to write \"%s\": %s\n", v->blk_device, strerror(errno)); + mtd_write_close(write); + return -1; + } + if (mtd_write_close(write)) { + LOGE("failed to finish \"%s\": %s\n", v->blk_device, strerror(errno)); + return -1; + } + + LOGI("Set boot command \"%s\"\n", in->command[0] != 255 ? in->command : ""); + return 0; +} + + +// ------------------------------------ +// for misc partitions on block devices +// ------------------------------------ + +static void wait_for_device(const char* fn) { + int tries = 0; + int ret; + do { + ++tries; + struct stat buf; + ret = stat(fn, &buf); + if (ret == -1) { + printf("failed to stat \"%s\" try %d: %s\n", fn, tries, strerror(errno)); + sleep(1); + } + } while (ret && tries < 10); + + if (ret) { + printf("failed to stat \"%s\"\n", fn); + } +} + +static bool read_misc_partition(const Volume* v, size_t offset, size_t size, std::string* out) { + wait_for_device(v->blk_device); + unique_fd fd(open(v->blk_device, O_RDONLY)); + if (fd.get() == -1) { + LOGE("Failed to open \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + if (lseek(fd.get(), static_cast<off_t>(offset), SEEK_SET) != static_cast<off_t>(offset)) { + LOGE("Failed to lseek \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + out->resize(size); + if (!android::base::ReadFully(fd.get(), &(*out)[0], size)) { + LOGE("Failed to read \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + return true; +} + +static bool write_misc_partition(const Volume* v, size_t offset, const std::string& in) { + wait_for_device(v->blk_device); + unique_fd fd(open(v->blk_device, O_WRONLY | O_SYNC)); + if (fd.get() == -1) { + LOGE("Failed to open \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + if (lseek(fd.get(), static_cast<off_t>(offset), SEEK_SET) != static_cast<off_t>(offset)) { + LOGE("Failed to lseek \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + if (!android::base::WriteFully(fd.get(), in.data(), in.size())) { + LOGE("Failed to write \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + + if (fsync(fd.get()) == -1) { + LOGE("Failed to fsync \"%s\": %s\n", v->blk_device, strerror(errno)); + return false; + } + return true; +} diff --git a/bootloader.h b/bootloader.h index 9c84a1cf9..88d54a5cb 100644 --- a/bootloader.h +++ b/bootloader.h @@ -14,5 +14,76 @@ * limitations under the License. */ -// TODO: Remove this file once we remove all places that include this file. -#include "bootloader_message/include/bootloader_message/bootloader_message.h" +#ifndef _RECOVERY_BOOTLOADER_H +#define _RECOVERY_BOOTLOADER_H + +#include <stddef.h> + +// Spaces used by misc partition are as below: +// 0 - 2K Bootloader Message +// 2K - 16K Used by Vendor's bootloader +// 16K - 64K Used by uncrypt and recovery to store wipe_package for A/B devices +// Note that these offsets are admitted by bootloader,recovery and uncrypt, so they +// are not configurable without changing all of them. +static const size_t BOOTLOADER_MESSAGE_OFFSET_IN_MISC = 0; +static const size_t WIPE_PACKAGE_OFFSET_IN_MISC = 16 * 1024; + +/* Bootloader Message + * + * This structure describes the content of a block in flash + * that is used for recovery and the bootloader to talk to + * each other. + * + * The command field is updated by linux when it wants to + * reboot into recovery or to update radio or bootloader firmware. + * It is also updated by the bootloader when firmware update + * is complete (to boot into recovery for any final cleanup) + * + * The status field is written by the bootloader after the + * completion of an "update-radio" or "update-hboot" command. + * + * The recovery field is only written by linux and used + * for the system to send a message to recovery or the + * other way around. + * + * The stage field is written by packages which restart themselves + * multiple times, so that the UI can reflect which invocation of the + * package it is. If the value is of the format "#/#" (eg, "1/3"), + * the UI will add a simple indicator of that status. + * + * The slot_suffix field is used for A/B implementations where the + * bootloader does not set the androidboot.ro.boot.slot_suffix kernel + * commandline parameter. This is used by fs_mgr to mount /system and + * other partitions with the slotselect flag set in fstab. A/B + * implementations are free to use all 32 bytes and may store private + * data past the first NUL-byte in this field. + */ +struct bootloader_message { + char command[32]; + char status[32]; + char recovery[768]; + + // The 'recovery' field used to be 1024 bytes. It has only ever + // been used to store the recovery command line, so 768 bytes + // should be plenty. We carve off the last 256 bytes to store the + // stage string (for multistage packages) and possible future + // expansion. + char stage[32]; + char slot_suffix[32]; + char reserved[192]; +}; + +/* Read and write the bootloader command from the "misc" partition. + * These return zero on success. + */ +int get_bootloader_message(struct bootloader_message *out); +int set_bootloader_message(const struct bootloader_message *in); + +#ifdef __cplusplus + +#include <string> + +bool read_wipe_package(size_t size, std::string* out); +#endif + +#endif diff --git a/bootloader_message/Android.mk b/bootloader_message/Android.mk deleted file mode 100644 index 815ac67d7..000000000 --- a/bootloader_message/Android.mk +++ /dev/null @@ -1,24 +0,0 @@ -# Copyright (C) 2016 The Android Open Source Project -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -LOCAL_PATH := $(call my-dir) - -include $(CLEAR_VARS) -LOCAL_CLANG := true -LOCAL_SRC_FILES := bootloader_message.cpp -LOCAL_MODULE := libbootloader_message -LOCAL_STATIC_LIBRARIES := libbase libfs_mgr -LOCAL_C_INCLUDES := $(LOCAL_PATH)/include -LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include -include $(BUILD_STATIC_LIBRARY) diff --git a/bootloader_message/include/bootloader_message/bootloader_message.h b/bootloader_message/include/bootloader_message/bootloader_message.h deleted file mode 100644 index c63aeca6f..000000000 --- a/bootloader_message/include/bootloader_message/bootloader_message.h +++ /dev/null @@ -1,99 +0,0 @@ -/* - * Copyright (C) 2008 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#ifndef _BOOTLOADER_MESSAGE_H -#define _BOOTLOADER_MESSAGE_H - -#include <stddef.h> - -// Spaces used by misc partition are as below: -// 0 - 2K Bootloader Message -// 2K - 16K Used by Vendor's bootloader -// 16K - 64K Used by uncrypt and recovery to store wipe_package for A/B devices -// Note that these offsets are admitted by bootloader,recovery and uncrypt, so they -// are not configurable without changing all of them. -static const size_t BOOTLOADER_MESSAGE_OFFSET_IN_MISC = 0; -static const size_t WIPE_PACKAGE_OFFSET_IN_MISC = 16 * 1024; - -/* Bootloader Message - * - * This structure describes the content of a block in flash - * that is used for recovery and the bootloader to talk to - * each other. - * - * The command field is updated by linux when it wants to - * reboot into recovery or to update radio or bootloader firmware. - * It is also updated by the bootloader when firmware update - * is complete (to boot into recovery for any final cleanup) - * - * The status field is written by the bootloader after the - * completion of an "update-radio" or "update-hboot" command. - * - * The recovery field is only written by linux and used - * for the system to send a message to recovery or the - * other way around. - * - * The stage field is written by packages which restart themselves - * multiple times, so that the UI can reflect which invocation of the - * package it is. If the value is of the format "#/#" (eg, "1/3"), - * the UI will add a simple indicator of that status. - * - * The slot_suffix field is used for A/B implementations where the - * bootloader does not set the androidboot.ro.boot.slot_suffix kernel - * commandline parameter. This is used by fs_mgr to mount /system and - * other partitions with the slotselect flag set in fstab. A/B - * implementations are free to use all 32 bytes and may store private - * data past the first NUL-byte in this field. - */ -struct bootloader_message { - char command[32]; - char status[32]; - char recovery[768]; - - // The 'recovery' field used to be 1024 bytes. It has only ever - // been used to store the recovery command line, so 768 bytes - // should be plenty. We carve off the last 256 bytes to store the - // stage string (for multistage packages) and possible future - // expansion. - char stage[32]; - char slot_suffix[32]; - char reserved[192]; -}; - -#ifdef __cplusplus - -#include <string> -#include <vector> - -bool read_bootloader_message(bootloader_message* boot, std::string* err); -bool write_bootloader_message(const bootloader_message& boot, std::string* err); -bool write_bootloader_message(const std::vector<std::string>& options, std::string* err); -bool clear_bootloader_message(std::string* err); - -bool read_wipe_package(std::string* package_data, size_t size, std::string* err); -bool write_wipe_package(const std::string& package_data, std::string* err); - - -#else - -#include <stdbool.h> - -// C Interface. -bool write_bootloader_message(const char* options); - -#endif // ifdef __cplusplus - -#endif // _BOOTLOADER_MESSAGE_H diff --git a/recovery.cpp b/recovery.cpp index c4b36557b..98148af0a 100644 --- a/recovery.cpp +++ b/recovery.cpp @@ -44,7 +44,6 @@ #include <android-base/parseint.h> #include <android-base/stringprintf.h> #include <android-base/strings.h> -#include <bootloader_message/bootloader_message.h> #include <cutils/android_reboot.h> #include <cutils/properties.h> #include <log/logger.h> /* Android Log packet format */ @@ -53,6 +52,7 @@ #include <healthd/BatteryMonitor.h> #include "adb_install.h" +#include "bootloader.h" #include "common.h" #include "device.h" #include "error_code.h" @@ -303,13 +303,9 @@ static void redirect_stdio(const char* filename) { // - the contents of COMMAND_FILE (one per line) static void get_args(int *argc, char ***argv) { - bootloader_message boot = {}; - std::string err; - if (!read_bootloader_message(&boot, &err)) { - LOGE("%s\n", err.c_str()); - // If fails, leave a zeroed bootloader_message. - memset(&boot, 0, sizeof(boot)); - } + struct bootloader_message boot; + memset(&boot, 0, sizeof(boot)); + get_bootloader_message(&boot); // this may fail, leaving a zeroed structure stage = strndup(boot.stage, sizeof(boot.stage)); if (boot.command[0] != 0 && boot.command[0] != 255) { @@ -371,20 +367,16 @@ get_args(int *argc, char ***argv) { strlcat(boot.recovery, (*argv)[i], sizeof(boot.recovery)); strlcat(boot.recovery, "\n", sizeof(boot.recovery)); } - if (!write_bootloader_message(boot, &err)) { - LOGE("%s\n", err.c_str()); - } + set_bootloader_message(&boot); } static void set_sdcard_update_bootloader_message() { - bootloader_message boot = {}; + struct bootloader_message boot; + memset(&boot, 0, sizeof(boot)); strlcpy(boot.command, "boot-recovery", sizeof(boot.command)); strlcpy(boot.recovery, "recovery\n", sizeof(boot.recovery)); - std::string err; - if (!write_bootloader_message(boot, &err)) { - LOGE("%s\n", err.c_str()); - } + set_bootloader_message(&boot); } // Read from kernel log into buffer and write out to file. @@ -545,11 +537,9 @@ finish_recovery(const char *send_intent) { copy_logs(); // Reset to normal system boot so recovery won't cycle indefinitely. - bootloader_message boot = {}; - std::string err; - if (!write_bootloader_message(boot, &err)) { - LOGE("%s\n", err.c_str()); - } + struct bootloader_message boot; + memset(&boot, 0, sizeof(boot)); + set_bootloader_message(&boot); // Remove the command file, so recovery won't repeat indefinitely. if (has_cache) { @@ -926,9 +916,8 @@ static bool check_wipe_package(size_t wipe_package_size) { return false; } std::string wipe_package; - std::string err_str; - if (!read_wipe_package(&wipe_package, wipe_package_size, &err_str)) { - LOGE("Failed to read wipe package: %s\n", err_str.c_str()); + if (!read_wipe_package(wipe_package_size, &wipe_package)) { + LOGE("Failed to read wipe package.\n"); return false; } if (!verify_package(reinterpret_cast<const unsigned char*>(wipe_package.data()), @@ -1380,7 +1369,7 @@ static bool is_battery_ok() { } static void set_retry_bootloader_message(int retry_count, int argc, char** argv) { - bootloader_message boot = {}; + struct bootloader_message boot {}; strlcpy(boot.command, "boot-recovery", sizeof(boot.command)); strlcpy(boot.recovery, "recovery\n", sizeof(boot.recovery)); @@ -1399,10 +1388,7 @@ static void set_retry_bootloader_message(int retry_count, int argc, char** argv) snprintf(buffer, sizeof(buffer), "--retry_count=%d\n", retry_count+1); strlcat(boot.recovery, buffer, sizeof(boot.recovery)); } - std::string err; - if (!write_bootloader_message(boot, &err)) { - LOGE("%s\n", err.c_str()); - } + set_bootloader_message(&boot); } static ssize_t logbasename( diff --git a/uncrypt/Android.mk b/uncrypt/Android.mk index bb276edd5..09cfdfca5 100644 --- a/uncrypt/Android.mk +++ b/uncrypt/Android.mk @@ -15,6 +15,15 @@ LOCAL_PATH := $(call my-dir) include $(CLEAR_VARS) +LOCAL_CLANG := true +LOCAL_SRC_FILES := bootloader_message_writer.cpp +LOCAL_MODULE := libbootloader_message_writer +LOCAL_STATIC_LIBRARIES := libbase libfs_mgr +LOCAL_C_INCLUDES := $(LOCAL_PATH)/.. +LOCAL_EXPORT_C_INCLUDE_DIRS := $(LOCAL_PATH)/include +include $(BUILD_STATIC_LIBRARY) + +include $(CLEAR_VARS) LOCAL_CLANG := true @@ -24,7 +33,7 @@ LOCAL_C_INCLUDES := $(LOCAL_PATH)/.. LOCAL_MODULE := uncrypt -LOCAL_STATIC_LIBRARIES := libbootloader_message libbase \ +LOCAL_STATIC_LIBRARIES := libbootloader_message_writer libbase \ liblog libfs_mgr libcutils \ LOCAL_INIT_RC := uncrypt.rc diff --git a/bootloader_message/bootloader_message.cpp b/uncrypt/bootloader_message_writer.cpp index 9de7dff40..42df31efa 100644 --- a/bootloader_message/bootloader_message.cpp +++ b/uncrypt/bootloader_message_writer.cpp @@ -14,8 +14,6 @@ * limitations under the License. */ -#include <bootloader_message/bootloader_message.h> - #include <errno.h> #include <fcntl.h> #include <string.h> @@ -29,6 +27,8 @@ #include <android-base/unique_fd.h> #include <fs_mgr.h> +#include "bootloader.h" + static struct fstab* read_fstab(std::string* err) { // The fstab path is always "/fstab.${ro.hardware}". std::string fstab_path = "/fstab."; @@ -58,57 +58,7 @@ static std::string get_misc_blk_device(std::string* err) { return record->blk_device; } -// In recovery mode, recovery can get started and try to access the misc -// device before the kernel has actually created it. -static bool wait_for_device(const std::string& blk_device, std::string* err) { - int tries = 0; - int ret; - err->clear(); - do { - ++tries; - struct stat buf; - ret = stat(blk_device.c_str(), &buf); - if (ret == -1) { - *err += android::base::StringPrintf("failed to stat %s try %d: %s\n", - blk_device.c_str(), tries, strerror(errno)); - sleep(1); - } - } while (ret && tries < 10); - - if (ret) { - *err += android::base::StringPrintf("failed to stat %s\n", blk_device.c_str()); - } - return ret == 0; -} - -static bool read_misc_partition(void* p, size_t size, size_t offset, std::string* err) { - std::string misc_blk_device = get_misc_blk_device(err); - if (misc_blk_device.empty()) { - return false; - } - if (!wait_for_device(misc_blk_device, err)) { - return false; - } - android::base::unique_fd fd(open(misc_blk_device.c_str(), O_RDONLY)); - if (fd.get() == -1) { - *err = android::base::StringPrintf("failed to open %s: %s", misc_blk_device.c_str(), - strerror(errno)); - return false; - } - if (lseek(fd.get(), static_cast<off_t>(offset), SEEK_SET) != static_cast<off_t>(offset)) { - *err = android::base::StringPrintf("failed to lseek %s: %s", misc_blk_device.c_str(), - strerror(errno)); - return false; - } - if (!android::base::ReadFully(fd.get(), p, size)) { - *err = android::base::StringPrintf("failed to read %s: %s", misc_blk_device.c_str(), - strerror(errno)); - return false; - } - return true; -} - -static bool write_misc_partition(const void* p, size_t size, size_t offset, std::string* err) { +static bool write_misc_partition(const void* p, size_t size, size_t misc_offset, std::string* err) { std::string misc_blk_device = get_misc_blk_device(err); if (misc_blk_device.empty()) { return false; @@ -119,7 +69,8 @@ static bool write_misc_partition(const void* p, size_t size, size_t offset, std: strerror(errno)); return false; } - if (lseek(fd.get(), static_cast<off_t>(offset), SEEK_SET) != static_cast<off_t>(offset)) { + if (lseek(fd.get(), static_cast<off_t>(misc_offset), SEEK_SET) != + static_cast<off_t>(misc_offset)) { *err = android::base::StringPrintf("failed to lseek %s: %s", misc_blk_device.c_str(), strerror(errno)); return false; @@ -139,11 +90,7 @@ static bool write_misc_partition(const void* p, size_t size, size_t offset, std: return true; } -bool read_bootloader_message(bootloader_message* boot, std::string* err) { - return read_misc_partition(boot, sizeof(*boot), BOOTLOADER_MESSAGE_OFFSET_IN_MISC, err); -} - -bool write_bootloader_message(const bootloader_message& boot, std::string* err) { +static bool write_bootloader_message(const bootloader_message& boot, std::string* err) { return write_misc_partition(&boot, sizeof(boot), BOOTLOADER_MESSAGE_OFFSET_IN_MISC, err); } @@ -165,11 +112,6 @@ bool write_bootloader_message(const std::vector<std::string>& options, std::stri return write_bootloader_message(boot, err); } -bool read_wipe_package(std::string* package_data, size_t size, std::string* err) { - package_data->resize(size); - return read_misc_partition(&(*package_data)[0], size, WIPE_PACKAGE_OFFSET_IN_MISC, err); -} - bool write_wipe_package(const std::string& package_data, std::string* err) { return write_misc_partition(package_data.data(), package_data.size(), WIPE_PACKAGE_OFFSET_IN_MISC, err); diff --git a/uncrypt/include/bootloader_message_writer.h b/uncrypt/include/bootloader_message_writer.h new file mode 100644 index 000000000..1344bc835 --- /dev/null +++ b/uncrypt/include/bootloader_message_writer.h @@ -0,0 +1,36 @@ +/* + * Copyright (C) 2016 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef BOOTLOADER_MESSAGE_WRITER_H +#define BOOTLOADER_MESSAGE_WRITER_H + +#ifdef __cplusplus +#include <string> +#include <vector> + +bool clear_bootloader_message(std::string* err); + +bool write_bootloader_message(const std::vector<std::string>& options, std::string* err); +bool write_wipe_package(const std::string& package_data, std::string* err); + +#else +#include <stdbool.h> + +// C Interface. +bool write_bootloader_message(const char* options); +#endif + +#endif // BOOTLOADER_MESSAGE_WRITER_H diff --git a/uncrypt/uncrypt.cpp b/uncrypt/uncrypt.cpp index 5e804bcca..f62d13279 100644 --- a/uncrypt/uncrypt.cpp +++ b/uncrypt/uncrypt.cpp @@ -109,7 +109,7 @@ #include <android-base/logging.h> #include <android-base/stringprintf.h> #include <android-base/strings.h> -#include <bootloader_message/bootloader_message.h> +#include <bootloader_message_writer.h> #include <cutils/android_reboot.h> #include <cutils/properties.h> #include <cutils/sockets.h> diff --git a/updater/install.cpp b/updater/install.cpp index 005f9f97d..1a647dfa5 100644 --- a/updater/install.cpp +++ b/updater/install.cpp @@ -1417,7 +1417,7 @@ Value* ReadFileFn(const char* name, State* state, int argc, Expr* argv[]) { v->data = nullptr; FileContents fc; - if (LoadFileContents(filename, &fc) == 0) { + if (LoadFileContents(filename, &fc) != 0) { v->data = static_cast<char*>(malloc(fc.data.size())); if (v->data != nullptr) { memcpy(v->data, fc.data.data(), fc.data.size()); |