From 58bde316e22e392885de71d2391f2bc7f438ff1f Mon Sep 17 00:00:00 2001 From: Doug Zongker <> Date: Fri, 27 Mar 2009 13:25:30 -0700 Subject: AI 143128: Use PNG instead of BMP for recovery image icons. This saves about 60k from the recovery and system images. Automated import of CL 143128 --- Android.mk | 2 +- minui/resources.c | 167 +++++++++++--------------- res/images/icon_error.bmp | Bin 91076 -> 0 bytes res/images/icon_error.png | Bin 0 -> 9616 bytes res/images/icon_firmware_error.bmp | Bin 91076 -> 0 bytes res/images/icon_firmware_error.png | Bin 0 -> 8088 bytes res/images/icon_firmware_install.bmp | Bin 91076 -> 0 bytes res/images/icon_firmware_install.png | Bin 0 -> 11986 bytes res/images/icon_installing.bmp | Bin 91076 -> 0 bytes res/images/icon_installing.png | Bin 0 -> 10138 bytes res/images/icon_unpacking.bmp | Bin 91076 -> 0 bytes res/images/icon_unpacking.png | Bin 0 -> 7180 bytes res/images/indeterminate1.bmp | Bin 20214 -> 0 bytes res/images/indeterminate1.png | Bin 0 -> 2249 bytes res/images/indeterminate2.bmp | Bin 20214 -> 0 bytes res/images/indeterminate2.png | Bin 0 -> 2251 bytes res/images/indeterminate3.bmp | Bin 20214 -> 0 bytes res/images/indeterminate3.png | Bin 0 -> 2254 bytes res/images/indeterminate4.bmp | Bin 20214 -> 0 bytes res/images/indeterminate4.png | Bin 0 -> 2249 bytes res/images/indeterminate5.bmp | Bin 20214 -> 0 bytes res/images/indeterminate5.png | Bin 0 -> 2246 bytes res/images/indeterminate6.bmp | Bin 20214 -> 0 bytes res/images/indeterminate6.png | Bin 0 -> 2262 bytes res/images/progress_bar_empty.bmp | Bin 136 -> 0 bytes res/images/progress_bar_empty.png | Bin 0 -> 148 bytes res/images/progress_bar_empty_left_round.bmp | Bin 294 -> 0 bytes res/images/progress_bar_empty_left_round.png | Bin 0 -> 220 bytes res/images/progress_bar_empty_right_round.bmp | Bin 294 -> 0 bytes res/images/progress_bar_empty_right_round.png | Bin 0 -> 211 bytes res/images/progress_bar_fill.bmp | Bin 136 -> 0 bytes res/images/progress_bar_fill.png | Bin 0 -> 117 bytes res/images/progress_bar_left_round.bmp | Bin 294 -> 0 bytes res/images/progress_bar_left_round.png | Bin 0 -> 195 bytes res/images/progress_bar_right_round.bmp | Bin 294 -> 0 bytes res/images/progress_bar_right_round.png | Bin 0 -> 192 bytes 36 files changed, 68 insertions(+), 101 deletions(-) delete mode 100644 res/images/icon_error.bmp create mode 100644 res/images/icon_error.png delete mode 100644 res/images/icon_firmware_error.bmp create mode 100644 res/images/icon_firmware_error.png delete mode 100644 res/images/icon_firmware_install.bmp create mode 100644 res/images/icon_firmware_install.png delete mode 100644 res/images/icon_installing.bmp create mode 100644 res/images/icon_installing.png delete mode 100644 res/images/icon_unpacking.bmp create mode 100644 res/images/icon_unpacking.png delete mode 100644 res/images/indeterminate1.bmp create mode 100644 res/images/indeterminate1.png delete mode 100644 res/images/indeterminate2.bmp create mode 100644 res/images/indeterminate2.png delete mode 100644 res/images/indeterminate3.bmp create mode 100644 res/images/indeterminate3.png delete mode 100644 res/images/indeterminate4.bmp create mode 100644 res/images/indeterminate4.png delete mode 100644 res/images/indeterminate5.bmp create mode 100644 res/images/indeterminate5.png delete mode 100644 res/images/indeterminate6.bmp create mode 100644 res/images/indeterminate6.png delete mode 100644 res/images/progress_bar_empty.bmp create mode 100644 res/images/progress_bar_empty.png delete mode 100644 res/images/progress_bar_empty_left_round.bmp create mode 100644 res/images/progress_bar_empty_left_round.png delete mode 100644 res/images/progress_bar_empty_right_round.bmp create mode 100644 res/images/progress_bar_empty_right_round.png delete mode 100644 res/images/progress_bar_fill.bmp create mode 100644 res/images/progress_bar_fill.png delete mode 100644 res/images/progress_bar_left_round.bmp create mode 100644 res/images/progress_bar_left_round.png delete mode 100644 res/images/progress_bar_right_round.bmp create mode 100644 res/images/progress_bar_right_round.png diff --git a/Android.mk b/Android.mk index 816d143cc..6198ab338 100644 --- a/Android.mk +++ b/Android.mk @@ -30,7 +30,7 @@ LOCAL_FORCE_STATIC_EXECUTABLE := true LOCAL_MODULE_TAGS := eng LOCAL_STATIC_LIBRARIES := libminzip libunz libamend libmtdutils libmincrypt -LOCAL_STATIC_LIBRARIES += libminui libpixelflinger_static libcutils +LOCAL_STATIC_LIBRARIES += libminui libpixelflinger_static libpng libcutils LOCAL_STATIC_LIBRARIES += libstdc++ libc # Specify a C-includable file containing the OTA public keys. diff --git a/minui/resources.c b/minui/resources.c index 5beb6a6d9..7ecfeefce 100644 --- a/minui/resources.c +++ b/minui/resources.c @@ -29,97 +29,84 @@ #include +#include + #include "minui.h" -// File signature for BMP files. -// The letters 'BM' as a little-endian unsigned short. - -#define BMP_SIGNATURE 0x4d42 - -typedef struct { - // constant, value should equal BMP_SIGNATURE - unsigned short bfType; - // size of the file in bytes. - unsigned long bfSize; - // must always be set to zero. - unsigned short bfReserved1; - // must always be set to zero. - unsigned short bfReserved2; - // offset from the beginning of the file to the bitmap data. - unsigned long bfOffBits; - - // The BITMAPINFOHEADER: - // size of the BITMAPINFOHEADER structure, in bytes. - unsigned long biSize; - // width of the image, in pixels. - unsigned long biWidth; - // height of the image, in pixels. - unsigned long biHeight; - // number of planes of the target device, must be set to 1. - unsigned short biPlanes; - // number of bits per pixel. - unsigned short biBitCount; - // type of compression, zero means no compression. - unsigned long biCompression; - // size of the image data, in bytes. If there is no compression, - // it is valid to set this member to zero. - unsigned long biSizeImage; - // horizontal pixels per meter on the designated targer device, - // usually set to zero. - unsigned long biXPelsPerMeter; - // vertical pixels per meter on the designated targer device, - // usually set to zero. - unsigned long biYPelsPerMeter; - // number of colors used in the bitmap, if set to zero the - // number of colors is calculated using the biBitCount member. - unsigned long biClrUsed; - // number of color that are 'important' for the bitmap, - // if set to zero, all colors are important. - unsigned long biClrImportant; -} __attribute__((packed)) BitMapFileHeader; +// libpng gives "undefined reference to 'pow'" errors, and I have no +// idea how to convince the build system to link with -lm. We don't +// need this functionality (it's used for gamma adjustment) so provide +// a dummy implementation to satisfy the linker. +double pow(double x, double y) { + return x; +} int res_create_surface(const char* name, gr_surface* pSurface) { char resPath[256]; - BitMapFileHeader header; GGLSurface* surface = NULL; int result = 0; - - snprintf(resPath, sizeof(resPath)-1, "/res/images/%s.bmp", name); + unsigned char header[8]; + png_structp png_ptr = NULL; + png_infop info_ptr = NULL; + + snprintf(resPath, sizeof(resPath)-1, "/res/images/%s.png", name); resPath[sizeof(resPath)-1] = '\0'; - int fd = open(resPath, O_RDONLY); - if (fd == -1) { + FILE* fp = fopen(resPath, "rb"); + if (fp == NULL) { result = -1; goto exit; } - size_t bytesRead = read(fd, &header, sizeof(header)); + + size_t bytesRead = fread(header, 1, sizeof(header), fp); if (bytesRead != sizeof(header)) { result = -2; goto exit; } - if (header.bfType != BMP_SIGNATURE) { - result = -3; // Not a legal header + + if (png_sig_cmp(header, 0, sizeof(header))) { + result = -3; goto exit; } - if (header.biPlanes != 1) { + + png_ptr = png_create_read_struct(PNG_LIBPNG_VER_STRING, NULL, NULL, NULL); + if (!png_ptr) { result = -4; goto exit; } - if (!(header.biBitCount == 24 || header.biBitCount == 32)) { + + info_ptr = png_create_info_struct(png_ptr); + if (!info_ptr) { result = -5; goto exit; } - if (header.biCompression != 0) { + + if (setjmp(png_jmpbuf(png_ptr))) { result = -6; goto exit; } - size_t width = header.biWidth; - size_t height = header.biHeight; + + png_init_io(png_ptr, fp); + png_set_sig_bytes(png_ptr, sizeof(header)); + png_read_info(png_ptr, info_ptr); + + size_t width = info_ptr->width; + size_t height = info_ptr->height; size_t stride = 4 * width; size_t pixelSize = stride * height; - + + int color_type = info_ptr->color_type; + int bit_depth = info_ptr->bit_depth; + int channels = info_ptr->channels; + if (bit_depth != 8 || (channels != 3 && channels != 4) || + (color_type != PNG_COLOR_TYPE_RGB && + color_type != PNG_COLOR_TYPE_RGBA)) { + return -7; + goto exit; + } + surface = malloc(sizeof(GGLSurface) + pixelSize); if (surface == NULL) { - result = -7; + result = -8; goto exit; } unsigned char* pData = (unsigned char*) (surface + 1); @@ -128,63 +115,43 @@ int res_create_surface(const char* name, gr_surface* pSurface) { surface->height = height; surface->stride = width; /* Yes, pixels, not bytes */ surface->data = pData; - surface->format = (header.biBitCount == 24) ? + surface->format = (channels == 3) ? GGL_PIXEL_FORMAT_RGBX_8888 : GGL_PIXEL_FORMAT_RGBA_8888; - // Source pixel bytes are stored B G R {A} - - lseek(fd, header.bfOffBits, SEEK_SET); - size_t y; - if (header.biBitCount == 24) { // RGB - size_t inputStride = (((3 * width + 3) >> 2) << 2); - for (y = 0; y < height; y++) { - unsigned char* pRow = pData + (height - (y + 1)) * stride; - bytesRead = read(fd, pRow, inputStride); - if (bytesRead != inputStride) { - result = -8; - goto exit; - } + int y; + if (channels == 3) { + for (y = 0; y < height; ++y) { + unsigned char* pRow = pData + y * stride; + png_read_row(png_ptr, pRow, NULL); + int x; for(x = width - 1; x >= 0; x--) { int sx = x * 3; int dx = x * 4; - unsigned char b = pRow[sx]; + unsigned char r = pRow[sx]; unsigned char g = pRow[sx + 1]; - unsigned char r = pRow[sx + 2]; + unsigned char b = pRow[sx + 2]; unsigned char a = 0xff; pRow[dx ] = r; // r pRow[dx + 1] = g; // g - pRow[dx + 2] = b; // b; + pRow[dx + 2] = b; // b pRow[dx + 3] = a; } } - } else { // RGBA - for (y = 0; y < height; y++) { - unsigned char* pRow = pData + (height - (y + 1)) * stride; - bytesRead = read(fd, pRow, stride); - if (bytesRead != stride) { - result = -9; - goto exit; - } - size_t x; - for(x = 0; x < width; x++) { - size_t xx = x * 4; - unsigned char b = pRow[xx]; - unsigned char g = pRow[xx + 1]; - unsigned char r = pRow[xx + 2]; - unsigned char a = pRow[xx + 3]; - pRow[xx ] = r; - pRow[xx + 1] = g; - pRow[xx + 2] = b; - pRow[xx + 3] = a; - } + } else { + for (y = 0; y < height; ++y) { + unsigned char* pRow = pData + y * stride; + png_read_row(png_ptr, pRow, NULL); } } + *pSurface = (gr_surface) surface; exit: - if (fd >= 0) { - close(fd); + png_destroy_read_struct(&png_ptr, &info_ptr, NULL); + + if (fp != NULL) { + fclose(fp); } if (result < 0) { if (surface) { diff --git a/res/images/icon_error.bmp b/res/images/icon_error.bmp deleted file mode 100644 index 7eb2bbc77..000000000 Binary files a/res/images/icon_error.bmp and /dev/null differ diff --git a/res/images/icon_error.png b/res/images/icon_error.png new file mode 100644 index 000000000..7064c2e23 Binary files /dev/null and b/res/images/icon_error.png differ diff --git a/res/images/icon_firmware_error.bmp b/res/images/icon_firmware_error.bmp deleted file mode 100644 index 5b8649f17..000000000 Binary files a/res/images/icon_firmware_error.bmp and /dev/null differ diff --git a/res/images/icon_firmware_error.png b/res/images/icon_firmware_error.png new file mode 100644 index 000000000..0c32c9ede Binary files /dev/null and b/res/images/icon_firmware_error.png differ diff --git a/res/images/icon_firmware_install.bmp b/res/images/icon_firmware_install.bmp deleted file mode 100644 index b0f5f959b..000000000 Binary files a/res/images/icon_firmware_install.bmp and /dev/null differ diff --git a/res/images/icon_firmware_install.png b/res/images/icon_firmware_install.png new file mode 100644 index 000000000..ee2afac5d Binary files /dev/null and b/res/images/icon_firmware_install.png differ diff --git a/res/images/icon_installing.bmp b/res/images/icon_installing.bmp deleted file mode 100644 index fff99fd7e..000000000 Binary files a/res/images/icon_installing.bmp and /dev/null differ diff --git a/res/images/icon_installing.png b/res/images/icon_installing.png new file mode 100644 index 000000000..f24f2e33f Binary files /dev/null and b/res/images/icon_installing.png differ diff --git a/res/images/icon_unpacking.bmp b/res/images/icon_unpacking.bmp deleted file mode 100644 index ab6548c58..000000000 Binary files a/res/images/icon_unpacking.bmp and /dev/null differ diff --git a/res/images/icon_unpacking.png b/res/images/icon_unpacking.png new file mode 100644 index 000000000..9198e2eb1 Binary files /dev/null and b/res/images/icon_unpacking.png differ diff --git a/res/images/indeterminate1.bmp b/res/images/indeterminate1.bmp deleted file mode 100644 index 716c92568..000000000 Binary files a/res/images/indeterminate1.bmp and /dev/null differ diff --git a/res/images/indeterminate1.png b/res/images/indeterminate1.png new file mode 100644 index 000000000..264bf27e5 Binary files /dev/null and b/res/images/indeterminate1.png differ diff --git a/res/images/indeterminate2.bmp b/res/images/indeterminate2.bmp deleted file mode 100644 index 223cd3c1e..000000000 Binary files a/res/images/indeterminate2.bmp and /dev/null differ diff --git a/res/images/indeterminate2.png b/res/images/indeterminate2.png new file mode 100644 index 000000000..c30c049ab Binary files /dev/null and b/res/images/indeterminate2.png differ diff --git a/res/images/indeterminate3.bmp b/res/images/indeterminate3.bmp deleted file mode 100644 index fd9086a1f..000000000 Binary files a/res/images/indeterminate3.bmp and /dev/null differ diff --git a/res/images/indeterminate3.png b/res/images/indeterminate3.png new file mode 100644 index 000000000..891a00095 Binary files /dev/null and b/res/images/indeterminate3.png differ diff --git a/res/images/indeterminate4.bmp b/res/images/indeterminate4.bmp deleted file mode 100644 index 87b264034..000000000 Binary files a/res/images/indeterminate4.bmp and /dev/null differ diff --git a/res/images/indeterminate4.png b/res/images/indeterminate4.png new file mode 100644 index 000000000..7a6415149 Binary files /dev/null and b/res/images/indeterminate4.png differ diff --git a/res/images/indeterminate5.bmp b/res/images/indeterminate5.bmp deleted file mode 100644 index e16efb04c..000000000 Binary files a/res/images/indeterminate5.bmp and /dev/null differ diff --git a/res/images/indeterminate5.png b/res/images/indeterminate5.png new file mode 100644 index 000000000..cd6ab20a7 Binary files /dev/null and b/res/images/indeterminate5.png differ diff --git a/res/images/indeterminate6.bmp b/res/images/indeterminate6.bmp deleted file mode 100644 index 085ad951a..000000000 Binary files a/res/images/indeterminate6.bmp and /dev/null differ diff --git a/res/images/indeterminate6.png b/res/images/indeterminate6.png new file mode 100644 index 000000000..ddd9e7384 Binary files /dev/null and b/res/images/indeterminate6.png differ diff --git a/res/images/progress_bar_empty.bmp b/res/images/progress_bar_empty.bmp deleted file mode 100644 index 8e512fd92..000000000 Binary files a/res/images/progress_bar_empty.bmp and /dev/null differ diff --git a/res/images/progress_bar_empty.png b/res/images/progress_bar_empty.png new file mode 100644 index 000000000..9013f04ac Binary files /dev/null and b/res/images/progress_bar_empty.png differ diff --git a/res/images/progress_bar_empty_left_round.bmp b/res/images/progress_bar_empty_left_round.bmp deleted file mode 100644 index c4e2f44fc..000000000 Binary files a/res/images/progress_bar_empty_left_round.bmp and /dev/null differ diff --git a/res/images/progress_bar_empty_left_round.png b/res/images/progress_bar_empty_left_round.png new file mode 100644 index 000000000..dae7d5d13 Binary files /dev/null and b/res/images/progress_bar_empty_left_round.png differ diff --git a/res/images/progress_bar_empty_right_round.bmp b/res/images/progress_bar_empty_right_round.bmp deleted file mode 100644 index 1906f6209..000000000 Binary files a/res/images/progress_bar_empty_right_round.bmp and /dev/null differ diff --git a/res/images/progress_bar_empty_right_round.png b/res/images/progress_bar_empty_right_round.png new file mode 100644 index 000000000..542708823 Binary files /dev/null and b/res/images/progress_bar_empty_right_round.png differ diff --git a/res/images/progress_bar_fill.bmp b/res/images/progress_bar_fill.bmp deleted file mode 100644 index 8d57d8117..000000000 Binary files a/res/images/progress_bar_fill.bmp and /dev/null differ diff --git a/res/images/progress_bar_fill.png b/res/images/progress_bar_fill.png new file mode 100644 index 000000000..37c04b4f4 Binary files /dev/null and b/res/images/progress_bar_fill.png differ diff --git a/res/images/progress_bar_left_round.bmp b/res/images/progress_bar_left_round.bmp deleted file mode 100644 index 6d2df8d6a..000000000 Binary files a/res/images/progress_bar_left_round.bmp and /dev/null differ diff --git a/res/images/progress_bar_left_round.png b/res/images/progress_bar_left_round.png new file mode 100644 index 000000000..e72af47d4 Binary files /dev/null and b/res/images/progress_bar_left_round.png differ diff --git a/res/images/progress_bar_right_round.bmp b/res/images/progress_bar_right_round.bmp deleted file mode 100644 index 68bb6fe37..000000000 Binary files a/res/images/progress_bar_right_round.bmp and /dev/null differ diff --git a/res/images/progress_bar_right_round.png b/res/images/progress_bar_right_round.png new file mode 100644 index 000000000..d04c980b9 Binary files /dev/null and b/res/images/progress_bar_right_round.png differ -- cgit v1.2.3