From 5d6309e77f6055a9aec062dd991d071054726ebb Mon Sep 17 00:00:00 2001 From: Doug Zongker Date: Wed, 3 Nov 2010 14:31:01 -0700 Subject: fix comparison of ECC stats before and after mtd reads ECC errors are found by comparing the result of ioctl(ECCGETSTATS) before and after the read. But if an error was found causing us to go to the next block, we'd compare the stats before the *first* read to the stats after the second (third, fourth, etc.) reads, so we'd read to the end of the partition without ever succeeding. Fix logic so we compare the values before and after each read independently. Bug: 3162777 Change-Id: I5a13abd7243d2afd1d21bd98cbb233e5124b2e80 --- mtdutils/mtdutils.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mtdutils/mtdutils.c b/mtdutils/mtdutils.c index 48d5ea9ab..198f4989d 100644 --- a/mtdutils/mtdutils.c +++ b/mtdutils/mtdutils.c @@ -309,6 +309,8 @@ static int read_block(const MtdPartition *partition, int fd, char *data) fprintf(stderr, "mtd: ECC errors (%d soft, %d hard) at 0x%08llx\n", after.corrected - before.corrected, after.failed - before.failed, pos); + // copy the comparison baseline for the next read. + memcpy(&before, &after, sizeof(struct mtd_ecc_stats)); } else if ((mgbb = ioctl(fd, MEMGETBADBLOCK, &pos))) { fprintf(stderr, "mtd: MEMGETBADBLOCK returned %d at 0x%08llx (errno=%d)\n", -- cgit v1.2.3