From 1e10cc4297e98a934f548aa7e7767ee6d469ff0f Mon Sep 17 00:00:00 2001 From: Tianjie Xu Date: Tue, 23 Oct 2018 12:10:46 -0700 Subject: Add a function to construct the GRSurface in test This fixes the build error as the initializer list no longer work without the proper constructor for c++ class. Bug: 74397117 Test: unit tests pass Change-Id: If3ff508a1a01ad5326413dab8e05bacae8a946c8 --- tests/unit/screen_ui_test.cpp | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/tests/unit/screen_ui_test.cpp b/tests/unit/screen_ui_test.cpp index dc6e6a896..06a98c742 100644 --- a/tests/unit/screen_ui_test.cpp +++ b/tests/unit/screen_ui_test.cpp @@ -69,6 +69,17 @@ class ScreenUITest : public testing::Test { MockDrawFunctions draw_funcs_; }; +// TODO(xunchang) Create a constructor. +static GRSurface CreateFakeGRSurface(int width, int height, int row_bytes, int pixel_bytes) { + GRSurface fake_surface; + fake_surface.width = width; + fake_surface.height = height; + fake_surface.row_bytes = row_bytes; + fake_surface.pixel_bytes = pixel_bytes; + + return fake_surface; +} + TEST_F(ScreenUITest, StartPhoneMenuSmoke) { TextMenu menu(false, 10, 20, HEADERS, ITEMS, 0, 20, draw_funcs_); ASSERT_FALSE(menu.scrollable()); @@ -230,7 +241,7 @@ TEST_F(ScreenUITest, WearMenuSelectItemsOverflow) { } TEST_F(ScreenUITest, GraphicMenuSelection) { - GRSurface fake_surface = GRSurface{ 50, 50, 50, 1, nullptr }; + auto fake_surface = CreateFakeGRSurface(50, 50, 50, 1); std::vector items = { &fake_surface, &fake_surface, &fake_surface }; GraphicMenu menu(&fake_surface, items, 0, draw_funcs_); @@ -252,13 +263,13 @@ TEST_F(ScreenUITest, GraphicMenuSelection) { } TEST_F(ScreenUITest, GraphicMenuValidate) { - auto fake_surface = GRSurface{ 50, 50, 50, 1, nullptr }; + auto fake_surface = CreateFakeGRSurface(50, 50, 50, 1); std::vector items = { &fake_surface, &fake_surface, &fake_surface }; ASSERT_TRUE(GraphicMenu::Validate(200, 200, &fake_surface, items)); // Menu exceeds the horizontal boundary. - auto wide_surface = GRSurface{ 300, 50, 300, 1, nullptr }; + auto wide_surface = CreateFakeGRSurface(300, 50, 300, 1); ASSERT_FALSE(GraphicMenu::Validate(299, 200, &wide_surface, items)); // Menu exceeds the vertical boundary. -- cgit v1.2.3