From 8b23811d2ac5c056ff49f2ab4fca3447a9fdca42 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Fri, 26 Aug 2016 14:54:29 -0700 Subject: Fix clang-tidy warnings in bootable/recovery. * Use const reference type for read-only parameters. Bug: 30407689 * Use faster overloaded string find function. Bug: 30411878 * Add parentheses around macro parameters. Bug: 28705665 Test: build with WITH_TIDY=1 Change-Id: I4e8e5748bfa4ae89871f1fb5fa4624d372530d75 --- install.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'install.cpp') diff --git a/install.cpp b/install.cpp index 6c8d827c2..10a90a0ce 100644 --- a/install.cpp +++ b/install.cpp @@ -54,8 +54,8 @@ static const float DEFAULT_FILES_PROGRESS_FRACTION = 0.4; static const float DEFAULT_IMAGE_PROGRESS_FRACTION = 0.1; // This function parses and returns the build.version.incremental -static int parse_build_number(std::string str) { - size_t pos = str.find("="); +static int parse_build_number(const std::string& str) { + size_t pos = str.find('='); if (pos != std::string::npos) { std::string num_string = android::base::Trim(str.substr(pos+1)); int build_number; -- cgit v1.2.3