From e3f09a72f51df5abcf46a63de4a39ca5ed53698b Mon Sep 17 00:00:00 2001 From: Tao Bao Date: Tue, 1 Oct 2019 11:55:36 -0700 Subject: otautil: Factor out the utils that're private to recovery. A number of utility functions are intended for serving recovery's own use. Exposing them via libotautil (which is a static lib) would pass the dependencies onto libotautil's users (e.g. recovery image, updater, host simulator, device-specific recovery UI/updater extensions etc). This CL finds a new home for the utils that are private to recovery. Test: mmma bootable/recovery Change-Id: I575e97ad099b85fe1c1c8c7c9458a5a43d4e11e1 --- install/Android.bp | 1 + install/fuse_install.cpp | 2 +- install/install.cpp | 4 ++-- install/wipe_data.cpp | 6 +++--- 4 files changed, 7 insertions(+), 6 deletions(-) (limited to 'install') diff --git a/install/Android.bp b/install/Android.bp index e24027049..d4606e92c 100644 --- a/install/Android.bp +++ b/install/Android.bp @@ -37,6 +37,7 @@ cc_defaults { ], static_libs: [ + "librecovery_utils", "libotautil", // external dependencies diff --git a/install/fuse_install.cpp b/install/fuse_install.cpp index 8a7a278e0..143b5d3fb 100644 --- a/install/fuse_install.cpp +++ b/install/fuse_install.cpp @@ -37,7 +37,7 @@ #include "fuse_provider.h" #include "fuse_sideload.h" #include "install/install.h" -#include "otautil/roots.h" +#include "recovery_utils/roots.h" static constexpr const char* SDCARD_ROOT = "/sdcard"; // How long (in seconds) we wait for the fuse-provided package file to diff --git a/install/install.cpp b/install/install.cpp index 9d67b0105..9166f9cfb 100644 --- a/install/install.cpp +++ b/install/install.cpp @@ -51,11 +51,11 @@ #include "install/wipe_data.h" #include "otautil/error_code.h" #include "otautil/paths.h" -#include "otautil/roots.h" #include "otautil/sysutil.h" -#include "otautil/thermalutil.h" #include "private/setup_commands.h" #include "recovery_ui/ui.h" +#include "recovery_utils/roots.h" +#include "recovery_utils/thermalutil.h" using namespace std::chrono_literals; diff --git a/install/wipe_data.cpp b/install/wipe_data.cpp index 765a8152b..82660bef0 100644 --- a/install/wipe_data.cpp +++ b/install/wipe_data.cpp @@ -28,9 +28,9 @@ #include #include "otautil/dirutil.h" -#include "otautil/logging.h" -#include "otautil/roots.h" #include "recovery_ui/ui.h" +#include "recovery_utils/logging.h" +#include "recovery_utils/roots.h" constexpr const char* CACHE_ROOT = "/cache"; constexpr const char* DATA_ROOT = "/data"; @@ -120,4 +120,4 @@ bool WipeData(Device* device, bool convert_fbe) { } ui->Print("Data wipe %s.\n", success ? "complete" : "failed"); return success; -} \ No newline at end of file +} -- cgit v1.2.3