From 23abfd37a55f281186f9275ad35b7182efd2e8b6 Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Wed, 27 Jul 2016 10:19:47 -0700 Subject: Fix clang-tidy performance warnings. * Use const reference parameter type to avoid unnecessary copy. * Use more efficient overloaded string methods. Bug: 30407689 Bug: 30411878 Change-Id: Iefab05c077367f272abf545036b853e8a295c8cd Test: build with WITH_TIDY=1 --- otafault/ota_io.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'otafault') diff --git a/otafault/ota_io.cpp b/otafault/ota_io.cpp index dd805e56e..cb37d515a 100644 --- a/otafault/ota_io.cpp +++ b/otafault/ota_io.cpp @@ -31,7 +31,7 @@ static std::string write_fault_file_name = ""; static std::string fsync_fault_file_name = ""; bool have_eio_error = false; -static bool get_hit_file(const char* cached_path, std::string ffn) { +static bool get_hit_file(const char* cached_path, const std::string& ffn) { return should_hit_cache() ? !strncmp(cached_path, OTAIO_CACHE_FNAME, strlen(cached_path)) : !strncmp(cached_path, ffn.c_str(), strlen(cached_path)); -- cgit v1.2.3