From 1d4e036e3973fc446fd38ba200c03f996a9bc903 Mon Sep 17 00:00:00 2001 From: KingCol13 <48412633+KingCol13@users.noreply.github.com> Date: Wed, 27 Sep 2023 18:56:25 +0100 Subject: Only enable werror for debug (#5501) --- SetFlags.cmake | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) (limited to 'SetFlags.cmake') diff --git a/SetFlags.cmake b/SetFlags.cmake index 98878de4a..1c1071499 100644 --- a/SetFlags.cmake +++ b/SetFlags.cmake @@ -152,9 +152,6 @@ function(set_exe_flags TARGET) target_compile_options( ${TARGET} PRIVATE - # Warnings-as-errors only on Clang for now: - -Werror - # TODO: actually fix the warnings instead of disabling them # or at least disable on a file-level basis: -Wno-missing-noreturn -Wno-padded -Wno-implicit-fallthrough @@ -169,6 +166,16 @@ function(set_exe_flags TARGET) -Wno-documentation-unknown-command -Wno-reserved-id-macro -Wno-error=unused-command-line-argument ) + # Werror only for debug builds + if(CMAKE_BUILD_TYPE STREQUAL "Debug") + target_compile_options( + ${TARGET} PRIVATE + + # Warnings-as-errors only on Clang for now: + -Werror + ) + endif() + if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 7 AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 13) target_compile_options( ${TARGET} PRIVATE -- cgit v1.2.3