From 3daf253b7f4ed8243e3262faee35219335e3e088 Mon Sep 17 00:00:00 2001
From: 12xx12 <44411062+12xx12@users.noreply.github.com>
Date: Sun, 7 Mar 2021 17:31:43 +0100
Subject: Some emplace_back replacements (#5149)

* replace push_back with emplace_back when a new object was created in the function call
---
 src/Entities/ItemFrame.cpp | 2 +-
 src/Entities/LeashKnot.cpp | 2 +-
 src/Entities/Painting.cpp  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'src/Entities')

diff --git a/src/Entities/ItemFrame.cpp b/src/Entities/ItemFrame.cpp
index 807a67b15..ef2939e06 100644
--- a/src/Entities/ItemFrame.cpp
+++ b/src/Entities/ItemFrame.cpp
@@ -84,7 +84,7 @@ void cItemFrame::GetDrops(cItems & a_Items, cEntity * a_Killer)
 {
 	if ((a_Killer != nullptr) && a_Killer->IsPlayer() && !static_cast<cPlayer *>(a_Killer)->IsGameModeCreative())
 	{
-		a_Items.push_back(cItem(E_ITEM_ITEM_FRAME));
+		a_Items.emplace_back(E_ITEM_ITEM_FRAME);
 	}
 }
 
diff --git a/src/Entities/LeashKnot.cpp b/src/Entities/LeashKnot.cpp
index 7ed4845b7..e98ca52ec 100644
--- a/src/Entities/LeashKnot.cpp
+++ b/src/Entities/LeashKnot.cpp
@@ -95,7 +95,7 @@ void cLeashKnot::GetDrops(cItems & a_Items, cEntity * a_Killer)
 {
 	if ((a_Killer != nullptr) && a_Killer->IsPlayer() && !static_cast<cPlayer *>(a_Killer)->IsGameModeCreative())
 	{
-		a_Items.push_back(cItem(E_ITEM_LEASH));
+		a_Items.emplace_back(E_ITEM_LEASH);
 	}
 }
 
diff --git a/src/Entities/Painting.cpp b/src/Entities/Painting.cpp
index d12469f98..0f2139cd1 100644
--- a/src/Entities/Painting.cpp
+++ b/src/Entities/Painting.cpp
@@ -34,7 +34,7 @@ void cPainting::GetDrops(cItems & a_Items, cEntity * a_Killer)
 {
 	if ((a_Killer != nullptr) && a_Killer->IsPlayer() && !static_cast<cPlayer *>(a_Killer)->IsGameModeCreative())
 	{
-		a_Items.push_back(cItem(E_ITEM_PAINTING));
+		a_Items.emplace_back(E_ITEM_PAINTING);
 	}
 }
 
-- 
cgit v1.2.3