summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTiger Wang <ziwei.tiger@hotmail.co.uk>2014-07-16 23:22:00 +0200
committerTiger Wang <ziwei.tiger@hotmail.co.uk>2014-07-16 23:22:00 +0200
commit960fcaa90c3ba4d57ff2205259471799e0418d12 (patch)
tree830621e8d033c5853052147ea51d24cc7d3bbfb8
parentFixed another redstone simulator crash (diff)
downloadcuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.tar
cuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.tar.gz
cuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.tar.bz2
cuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.tar.lz
cuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.tar.xz
cuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.tar.zst
cuberite-960fcaa90c3ba4d57ff2205259471799e0418d12.zip
-rw-r--r--src/Items/ItemBucket.h2
-rw-r--r--src/LineBlockTracer.cpp17
2 files changed, 10 insertions, 9 deletions
diff --git a/src/Items/ItemBucket.h b/src/Items/ItemBucket.h
index 84835c021..a733bda19 100644
--- a/src/Items/ItemBucket.h
+++ b/src/Items/ItemBucket.h
@@ -215,7 +215,7 @@ public:
} Callbacks;
cLineBlockTracer Tracer(*a_World, Callbacks);
- Vector3d Start(a_Player->GetEyePosition() + a_Player->GetLookVector());
+ Vector3d Start(a_Player->GetEyePosition());
Vector3d End(a_Player->GetEyePosition() + a_Player->GetLookVector() * 5);
// cTracer::Trace returns true when whole line was traversed. By returning true when we hit something, we ensure that this never happens if liquid could be placed
diff --git a/src/LineBlockTracer.cpp b/src/LineBlockTracer.cpp
index b03652bab..2395aa43e 100644
--- a/src/LineBlockTracer.cpp
+++ b/src/LineBlockTracer.cpp
@@ -203,6 +203,15 @@ bool cLineBlockTracer::Item(cChunk * a_Chunk)
m_Callbacks->OnNoChunk();
return false;
}
+
+ // Move to next block
+ if (!MoveToNextBlock())
+ {
+ // We've reached the end
+ m_Callbacks->OnNoMoreHits();
+ return true;
+ }
+
if (a_Chunk->IsValid())
{
BLOCKTYPE BlockType;
@@ -225,14 +234,6 @@ bool cLineBlockTracer::Item(cChunk * a_Chunk)
}
}
- // Move to next block
- if (!MoveToNextBlock())
- {
- // We've reached the end
- m_Callbacks->OnNoMoreHits();
- return true;
- }
-
// Update the current chunk
if (a_Chunk != NULL)
{