diff options
| author | madmaxoft <github@xoft.cz> | 2013-09-15 20:49:08 +0200 |
|---|---|---|
| committer | madmaxoft <github@xoft.cz> | 2013-09-15 20:49:08 +0200 |
| commit | 5cde7d8a29b38360ae36f9e8c5210bee07fce612 (patch) | |
| tree | 816bbb5c99b9ac3ce64920ccc9e6abd88519c022 /source/World.cpp | |
| parent | Merge branch 'bugfixes' of git://github.com/tigerw/MCServer into tigerw-bugfixes (diff) | |
| parent | Added break (diff) | |
| download | cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.tar cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.tar.gz cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.tar.bz2 cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.tar.lz cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.tar.xz cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.tar.zst cuberite-5cde7d8a29b38360ae36f9e8c5210bee07fce612.zip | |
Diffstat (limited to 'source/World.cpp')
| -rw-r--r-- | source/World.cpp | 40 |
1 files changed, 11 insertions, 29 deletions
diff --git a/source/World.cpp b/source/World.cpp index edcbb48f2..882cf90d2 100644 --- a/source/World.cpp +++ b/source/World.cpp @@ -1514,22 +1514,13 @@ void cWorld::SpawnItemPickups(const cItems & a_Pickups, double a_BlockX, double for (cItems::const_iterator itr = a_Pickups.begin(); itr != a_Pickups.end(); ++itr) { float SpeedX = (float)(a_FlyAwaySpeed * (r1.randInt(1000) - 500)); - float SpeedY = (float)(a_FlyAwaySpeed * r1.randInt(1000)); + float SpeedY = 1; float SpeedZ = (float)(a_FlyAwaySpeed * (r1.randInt(1000) - 500)); - - // Add random offset to the spawn position: - int MicroX = (int)(a_BlockX * 32) + (r1.randInt(16) + r1.randInt(16) - 16); - int MicroY = (int)(a_BlockY * 32) + (r1.randInt(16) + r1.randInt(16) - 16); - int MicroZ = (int)(a_BlockZ * 32) + (r1.randInt(16) + r1.randInt(16) - 16); - - // TODO 2013_05_12 _X: Because spawning pickups with nonzero speed causes them to bug (FS #338), - // I decided to temporarily reset the speed to zero to fix it, until we have proper pickup physics - SpeedX = SpeedY = SpeedZ = 0; - - // TODO 2013_05_12 _X: It seems that pickups bug out even with zero speed, trying mid-block position: - MicroX = (int)(floor(a_BlockX) * 32) + 16; - MicroY = (int)(floor(a_BlockY) * 32) + 16; - MicroZ = (int)(floor(a_BlockZ) * 32) + 16; + + // Pickup doesn't spawn on client without a mid block position. Perhaps the doubles are causing issues? + int MicroX = (int)(floor(a_BlockX) * 32) + 16; + int MicroY = (int)(floor(a_BlockY) * 32) + 16; + int MicroZ = (int)(floor(a_BlockZ) * 32) + 16; cPickup * Pickup = new cPickup( MicroX, MicroY, MicroZ, @@ -1545,23 +1536,14 @@ void cWorld::SpawnItemPickups(const cItems & a_Pickups, double a_BlockX, double void cWorld::SpawnItemPickups(const cItems & a_Pickups, double a_BlockX, double a_BlockY, double a_BlockZ, double a_SpeedX, double a_SpeedY, double a_SpeedZ) { - // TODO 2013_05_12 _X: Because spawning pickups with nonzero speed causes them to bug (FS #338), - // I decided to temporarily reset the speed to zero to fix it, until we have proper pickup physics - a_SpeedX = a_SpeedY = a_SpeedZ = 0; - MTRand r1; for (cItems::const_iterator itr = a_Pickups.begin(); itr != a_Pickups.end(); ++itr) { - // Add random offset to the spawn position: - int MicroX = (int)(a_BlockX * 32) + (r1.randInt(16) + r1.randInt(16) - 16); - int MicroY = (int)(a_BlockY * 32) + (r1.randInt(16) + r1.randInt(16) - 16); - int MicroZ = (int)(a_BlockZ * 32) + (r1.randInt(16) + r1.randInt(16) - 16); - - // TODO 2013_05_12 _X: It seems that pickups bug out even with zero speed, trying mid-block position: - MicroX = (int)(floor(a_BlockX) * 32) + 16; - MicroY = (int)(floor(a_BlockY) * 32) + 16; - MicroZ = (int)(floor(a_BlockZ) * 32) + 16; - + // Pickup doesn't spawn on client without a mid block position. Perhaps the doubles are causing issues? + int MicroX = (int)(floor(a_BlockX) * 32) + 16; + int MicroY = (int)(floor(a_BlockY) * 32) + 16; + int MicroZ = (int)(floor(a_BlockZ) * 32) + 16; + cPickup * Pickup = new cPickup( MicroX, MicroY, MicroZ, *itr, (float)a_SpeedX, (float)a_SpeedY, (float)a_SpeedZ |