summaryrefslogtreecommitdiffstats
path: root/src/CheckBasicStyle.lua (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Prepare for 1.15+ (#4856)Tiger Wang2020-12-211-2/+3
| | | | | + Add type-safe container for states * Split registry Blocks into BlockTypes, BlockStates so the block types enumeration can be #included without too much penalty * Ensure Registry uses type-safe container
* 1.13 items supportTiger Wang2020-07-181-0/+1
| | | | + Add 1.16 block and item definitions
* Removed extended ASCII, and added a check against it. (#4642)Mattes D2020-04-121-0/+3
|
* CheckBasicStyle: Check number of empty lines between functions (#4267)peterbell102018-07-261-5/+23
| | | | Add check for number of empty lines between functions and fix the corresponding failures
* StyleCheck: Add "else has to be on a separate line" (#3412)mohe20152016-10-201-0/+4
|
* Revert "Added a BasicStyleCheck for virtual functions without override keyword."Mattes D2016-08-131-2/+0
| | | | This reverts commit a800b5bd9f663b5c7d78101a449f97e5a5789c9a.
* Added a BasicStyleCheck for virtual functions without override keyword.Mattes D2016-08-131-0/+2
|
* 1.9 / 1.9.2 / 1.9.3 / 1.9.4 protocol support (#3135)Pokechu222016-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Semistable update to 15w31a I'm going through snapshots in a sequential order since it should make things easier, and since protocol version history is written. * Update to 15w34b protocol Also, fix an issue with the Entity Equipment packet from the past version. Clients are able to connect and do stuff! * Partially update to 15w35e Chunk data doesn't work, but the client joins. I'm waiting to do chunk data because chunk data has an incomplete format until 15w36d. * Add '/blk' debug command This command lets one see what block they are looking at, and makes figuring out what's supposed to be where in a highly broken chunk possible. * Fix CRLF normalization in CheckBasicStyle.lua Normally, this doesn't cause an issue, but when running from cygwin, it detects the CR as whitespace and creates thousands of violations for every single line. Lua, when run on windows, will normalize automatically, but when run via cygwin, it won't. The bug was simply that gsub was returning a replaced version, but not changing the parameter, so the replaced version was ignored. * Update to 15w40b This includes chunk serialization. Fully functional chunk serialization for 1.9. I'm not completely happy with the chunk serialization as-is (correct use of palettes would be great), but cuberite also doesn't skip sending empty chunks so this performance optimization should probably come later. The creation of a full buffer is suboptimal, but it's the easiest way to implement this code. * Write long-by-long rather than creating a buffer This is a bit faster and should be equivalent. However, the code still doesn't look too good. * Update to 15w41a protocol This includes the new set passengers packet, which works off of the ridden entity, not the rider. That means, among other things, that information about the previously ridden vehicle is needed when detaching. So a new method with that info was added. * Update to 15w45a * 15w51b protocol * Update to 1.9.0 protocol Closes #3067. There are still a few things that need to be worked out (picking up items, effects, particles, and most importantly inventory), but in general this should work. I'll make a few more changes tomorrow to get the rest of the protocol set up, along with 1.9.1/1.9.2 (which did make a few changes). Chunks, however, _are_ working, along with most other parts of the game (placing/breaking blocks). * Fix item pickup packet not working That was a silly mistake, but at least it was an easy one. * 1.9.2 protocol support * Fix version info found in server list ping Thus, the client reports that it can connect rather than saying that the server is out of date. This required creating separate classes for 1.9.1 and 1.9.2, unfortunately. * Fix build errors generated by clang These didn't happen in MSVC. * Add protocol19x.cpp and protocol19x.h to CMakeLists * Ignore warnings in protocol19x that are ignored in protocol18x * Document BLOCK_FACE and DIG_STATUS constants * Fix BLOCK_FACE links and add separate section for DIG_STATUS * Fix bat animation and object spawning The causes of both of these are explained in #3135, but the gist is that both were typos. * Implement Use Item packet This means that buckets, bows, fishing rods, and several other similar items now work when not looking at a block. * Handle DIG_STATUS_SWAP_ITEM_IN_HAND * Add support for spawn eggs and potions The items are transformed from the 1.9 version to the 1.8 version when reading and transformed back when sending. * Remove spammy potion debug logging * Fix wolf collar color metadata The wrong type was being used, causing several clientside issues (including the screen going black). * Fix 1.9 chunk sending in the nether The nether and the end don't send skylight. * Fix clang build errors * Fix water bottles becoming mundane potions This happened because the can become splash potion bit got set incorrectly. Water bottles and mundane potions are only differentiated by the fact that water bottles have a metadata of 0, so setting that bit made it a mundane potion. Also add missing break statements to the read item NBT switch, which would otherwise break items with custom names and also cause incorrect "Unimplemented NBT data when parsing!" logging. * Copy Protocol18x as Protocol19x Aditionally, method and class names have been swapped to clean up other diffs. This commit is only added to make the following diffs more readable; it doesn't make any other changes (beyond class names). * Make thrown potions use the correct appearence This was caused by potions now using metadata. * Add missing api doc for cSplashPotionEntity::GetItem * Fix compile error in SplashPotionEntity.cpp * Fix fix of cSplashPotionEntity API doc * Temporarilly disable fall damage particles These were causing issues in 1.9 due to the changed effect ID. * Properly send a kick packet when connecting with an invalid version This means that the client no longer waits on the server screen with no indication whatsoever. However, right now the server list ping isn't implemented for unknown versions, so it'll only load "Old" on the ping. I also added a GetVarIntSize method to cByteBuffer. This helps clean up part of the code here (and I think it could clean up other parts), but it may make sense for it to be moved elsewhere (or declared in a different way). * Handle server list pings from unrecognized versions This isn't the cleanest way of writing it (it feels odd to use ProtocolRecognizer to send packets, and the addition of m_InPingForUnrecognizedVersion feels like the wrong technique), but it works and I can't think of a better way (apart from creating a full separate protocol class to handle only the ping... which would be worse). * Use cPacketizer for the disconnect packet This also should fix clang build errors. * Add 1.9.3 / 1.9.4 support * Fix incorrect indentation in APIDesc
* Style checker - Prevent whitespace-only linesLogicParrot2016-02-061-1/+1
|
* Ignore == if followed by \worktycho2015-12-221-1/+1
| | | | Ignore the space before == rule if immediately followed by a \. If it is imediatly followed by a \, then this is likely the base64 padding at the end of a certificate, which is followed by \n.
* Added HTTPS links wherever they are supported.Alexander Harkness2015-12-191-34/+30
|
* StyleCheck: Check spaces around ==, <=, >=Mattes D2015-10-081-2/+10
|
* Added CircleCI for stylechecking.Mattes D2015-09-171-0/+6
| | | | This will allow us to remove the stylecheck from Travis builds, making them a bit faster, and having fast style checks
* Unified the doxy-comment format.Mattes D2015-07-311-0/+12
|
* ToLua now generates cLuaState::Push() and GetStackValue()Mattes D2015-05-121-0/+1
| | | | | For classes exported through ToLua it generates the cLuaState::Push() and cLuaState::GetStackValue() functions, as well as the supporting forward declarations and typedefs. Renamed virtual_method_hooks.lua to BindingsProcessor.lua since it no longer provides virtual method hooks and instead does additional processing when generating the bindings.
* Added check against "Type const &" and "Type const *".Mattes D2015-05-091-0/+4
|
* CheckBasicStyle: checks spaces around * and &.Mattes D2015-05-091-2/+10
|
* More style checking.Mattes D2015-05-091-0/+21
| | | | Spaces around some operators are checked.
* Chmod +x CheckBasicStyle.luawiseoldman952015-05-051-0/+0
|
* CheckBasicStyle: Can check individual files or git commits.Mattes D2015-05-021-2/+101
|
* Fixed alignmentworktycho2015-03-211-2/+2
|
* Fixed style and removed false positivestycho2015-03-111-3/+3
| | | | Relaxed the rules for < followed by an && and removed rule for < following an &&
* CheckBasicStyle: Fixed a forgotten file close.Mattes D2015-01-291-0/+1
|
* Merge remote-tracking branch 'origin/master' into c++11Tiger Wang2014-12-061-0/+41
|\ | | | | | | | | Conflicts: src/OSSupport/Thread.cpp
| * CheckBasicStyle: Check missing braces for control statements.Mattes D2014-12-051-0/+19
| | | | | | | | Only single-line control statements are checked.
| * CheckBasicStyle: Added a check for parentheses around comparisons.Mattes D2014-12-051-0/+22
| | | | | | | | The check is only rudimentary and tends to fall towards missed positived rather than false positives.
* | CheckBasicStyle: Doesn't report false positives ending in a keyword.Mattes D2014-12-041-5/+5
|/
* CheckBasicStyle ignores the Bindings.h generated file.Mattes D2014-10-131-0/+1
|
* CheckBasicStyle: Added checking for the "template" keyword.Mattes D2014-08-281-1/+2
|
* CheckBasicStyle: multi-level indent change.madmaxoft2014-08-041-1/+16
|
* BasicStyleCheck: Dividers are exactly 80 slashes.madmaxoft2014-08-041-1/+17
|
* CheckBasicStyle: Added a lua shebang.madmaxoft2014-07-211-0/+1
|
* CheckBasicStyle: Doesn't require LuaFileSystem.madmaxoft2014-07-211-34/+10
| | | | Instead it uses the list of files generated by CMake.
* Normalized spaces after "catch".madmaxoft2014-07-211-1/+2
|
* CheckBasicStyle: Checks spaces after keywords, no space before ")".madmaxoft2014-07-211-1/+16
|
* CheckBasicStyle: Checks for braces not on separate lines.madmaxoft2014-07-191-2/+6
| | | | Only the opening braces at the end of a line are checked, others (such as inline getters and setters or initializers) are valid.
* CheckBasicStyle: Check spaces around commas.madmaxoft2014-07-191-6/+6
| | | | We want no space in front of and at least one space after a comma.
* CheckBasicStyle: Proper spaces with commas.madmaxoft2014-07-181-21/+48
|
* Initial version of a script to check basic style.madmaxoft2014-07-171-0/+188
This script reports basic violations of the style, such as indentation using spaces, alignment using tabs, trailing whitespace etc. Passing this script does NOT mean that the style is clean, it's only for fast-checking purposes.