From 700bbdabf53ab3b47151271526570f4a862b87f2 Mon Sep 17 00:00:00 2001 From: Alexander Harkness Date: Tue, 29 Aug 2017 21:29:06 +0100 Subject: SetSwimState now takes into account head height This affects m_IsSubmerged and IsSubmerged() for entities of all types. Also prevent squids from suffocating in water. --- src/Entities/Entity.cpp | 5 +++-- src/Mobs/Squid.h | 1 - 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Entities/Entity.cpp b/src/Entities/Entity.cpp index 598ad4127..15e00871b 100644 --- a/src/Entities/Entity.cpp +++ b/src/Entities/Entity.cpp @@ -1666,7 +1666,8 @@ void cEntity::SetSwimState(cChunk & a_Chunk) m_IsSwimming = IsBlockWater(BlockIn); // Check if the player is submerged: - VERIFY(a_Chunk.UnboundedRelGetBlockType(RelX, RelY + 1, RelZ, BlockIn)); + int HeadHeight = CeilC(GetPosY() + GetHeight()) - 1; + VERIFY(a_Chunk.UnboundedRelGetBlockType(RelX, HeadHeight, RelZ, BlockIn)); m_IsSubmerged = IsBlockWater(BlockIn); } @@ -1698,7 +1699,7 @@ void cEntity::DoSetSpeed(double a_SpeedX, double a_SpeedY, double a_SpeedZ) void cEntity::HandleAir(void) { // Ref.: https://minecraft.gamepedia.com/Chunk_format - // See if the entity is /submerged/ water (block above is water) + // See if the entity is /submerged/ water (head is in water) // Get the type of block the entity is standing in: int RespirationLevel = static_cast(GetEquippedHelmet().m_Enchantments.GetLevel(cEnchantments::enchRespiration)); diff --git a/src/Mobs/Squid.h b/src/Mobs/Squid.h index 590c50495..aeeec77df 100644 --- a/src/Mobs/Squid.h +++ b/src/Mobs/Squid.h @@ -23,7 +23,6 @@ public: // Squids do not drown (or float) virtual void HandleAir(void) override {} - virtual void SetSwimState(cChunk & a_Chunk) override {} } ; -- cgit v1.2.3