From a4dbb5c58270959884c17d720185da06464fa256 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Wed, 2 May 2018 08:50:36 +0100 Subject: Prefer static_cast to reinterpret_cast (#4223) * Change reinterpret_cast -> static_cast wherever possible * Remove more unnecessary `const_cast`s. reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there. --- src/Bindings/ManualBindings_Network.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/Bindings/ManualBindings_Network.cpp') diff --git a/src/Bindings/ManualBindings_Network.cpp b/src/Bindings/ManualBindings_Network.cpp index ff8f173a1..4a7dd2367 100644 --- a/src/Bindings/ManualBindings_Network.cpp +++ b/src/Bindings/ManualBindings_Network.cpp @@ -848,7 +848,7 @@ public: virtual void OnBodyData(const void * a_Data, size_t a_Size) override { - m_Callbacks->CallTableFnWithSelf("OnBodyData", AString(reinterpret_cast(a_Data), a_Size)); + m_Callbacks->CallTableFnWithSelf("OnBodyData", AString(static_cast(a_Data), a_Size)); } @@ -907,7 +907,7 @@ public: virtual void OnBodyData(const void * a_Data, size_t a_Size) override { - m_ResponseBody.append(reinterpret_cast(a_Data), a_Size); + m_ResponseBody.append(static_cast(a_Data), a_Size); } -- cgit v1.2.3