From a4dbb5c58270959884c17d720185da06464fa256 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Wed, 2 May 2018 08:50:36 +0100 Subject: Prefer static_cast to reinterpret_cast (#4223) * Change reinterpret_cast -> static_cast wherever possible * Remove more unnecessary `const_cast`s. reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there. --- src/Chunk.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/Chunk.cpp') diff --git a/src/Chunk.cpp b/src/Chunk.cpp index ff3ff7243..f43b5b4bb 100644 --- a/src/Chunk.cpp +++ b/src/Chunk.cpp @@ -539,7 +539,7 @@ void cChunk::CollectMobCensus(cMobCensus & toFill) // LOGD("Counting entity #%i (%s)", (*itr)->GetUniqueID(), (*itr)->GetClass()); if (entity->IsMob()) { - auto & Monster = reinterpret_cast(*entity); + auto & Monster = static_cast(*entity); currentPosition = Monster.GetPosition(); for (const auto & PlayerPos : PlayerPositions) { @@ -1902,11 +1902,11 @@ void cChunk::CollectPickupsByPlayer(cPlayer & a_Player) MarkDirty(); if (Entity->IsPickup()) { - reinterpret_cast(Entity.get())->CollectedBy(a_Player); + static_cast(*Entity).CollectedBy(a_Player); } else { - reinterpret_cast(Entity.get())->CollectedBy(a_Player); + static_cast(*Entity).CollectedBy(a_Player); } } else if (SqrDist < 5 * 5) -- cgit v1.2.3