From a4dbb5c58270959884c17d720185da06464fa256 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Wed, 2 May 2018 08:50:36 +0100 Subject: Prefer static_cast to reinterpret_cast (#4223) * Change reinterpret_cast -> static_cast wherever possible * Remove more unnecessary `const_cast`s. reinterpret_casts should be avoided for the same reason as c-style casts - they don't do any type-checking. reinterpret_cast was mainly being used for down-casting in inheritance hierarchies but static_cast works just as well while also making sure that there is actually an inheritance relationship there. --- src/StringUtils.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/StringUtils.cpp') diff --git a/src/StringUtils.cpp b/src/StringUtils.cpp index ae0aec1ad..08dd4774a 100644 --- a/src/StringUtils.cpp +++ b/src/StringUtils.cpp @@ -638,7 +638,7 @@ AString & CreateHexDump(AString & a_Out, const void * a_Data, size_t a_Size, siz size_t k = std::min(a_Size - i, a_BytesPerLine); for (size_t j = 0; j < k; j++) { - Byte c = (reinterpret_cast(a_Data))[i + j]; + Byte c = (static_cast(a_Data))[i + j]; Hex << HEX(c >> 4) << HEX(c & 0xf) << ' '; Chars << ((c >= ' ') ? static_cast(c) : '.'); } // for j -- cgit v1.2.3