| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
| |
Updated Comments for better readability.
|
| |
|
|\
| |
| | |
msvc: set warning level to /W4 globally
|
| |
| |
| |
| | |
And fix a bunch of warnings
|
|/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: For GCC there are still a huge number of `-Warray-bounds` warnings
coming from `externals/dynarmic`. I could have added a workaround in
`externals/CMakeLists.txt` similar to what this PR does for other
externals, but given Dynarmic's close affiliation with Yuzu, it would be
better to fix it upstream.
Besides that, on my machine, this makes the build warning-free except
for some warnings from glslangValidator and AutoMoc.
Details:
- Disable some warnings in externals.
- Disable `-Wnullability-completeness`, which is a Clang warning triggered
by the Vulkan SDK where if any pointers in the header are marked
_Nullable, it wants all pointers to be marked _Nullable or _Nonnull.
Most of them are, but some aren't. Who knows why.
- `src/web_service/verify_user_jwt.cpp`: Disable another warning when
including `jwt.hpp`.
- `src/input_common/input_poller.cpp`: Add missing `override` specifiers.
- src/common/swap.h: Remove redundant `operator&`. In general, this
file declares three overloads of each operator. Using `+` as an
example, the overloads are:
- a member function for `swapped_t + integer`
- a member function for `swapped_t + swapped_t`
- a free function for `integer + swapped_t`
But for `operator&`, there was an additional free function for
`swapped_t + integer`, which was redundant with the member function.
This caused a GCC warning saying "ISO C++ says that these are
ambiguous".
|
| |
|
|
|
|
| |
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
|
| |
|
|
|
|
|
| |
The latest version of MSVC STL brings C++23 standard library modules, which conflict with precompiled headers.
Disabling with /experimental:module- has no effect, so force C++20 in the meantime while we wait for module support in other compilers.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Enables shadow-uncaptured-locals and implicit-fallthrough for Clang.
implicit-fallthrough is not enabled by default in -Wall or -Wextra, and
shadow-uncaptured-local doesn't seem to be enabled by default by
-Wshadow, even though GCC has both of these by their respective cases.
|
| |
|
| |
|
| |
|
|\
| |
| | |
CMake: Use precompiled headers to improve compile times
|
| | |
|
| | |
|
|/ |
|
|
|
|
| |
Clang erroneously emits this warning when using designated initializers.
|
|
|
|
| |
This is similar to Clang's -Wunused-lambda-capture
|
|
|
|
| |
Disabling C4100 is similar to -Wno-unused-parameter
|
|
|
|
| |
These warnings are already included in /W3.
|
| |
|
| |
|
|
|
|
| |
These are already explicitly or implicitly set in src/CMakeLists.txt
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[REUSE] is a specification that aims at making file copyright
information consistent, so that it can be both human and machine
readable. It basically requires that all files have a header containing
copyright and licensing information. When this isn't possible, like
when dealing with binary assets, generated files or embedded third-party
dependencies, it is permitted to insert copyright information in the
`.reuse/dep5` file.
Oh, and it also requires that all the licenses used in the project are
present in the `LICENSES` folder, that's why the diff is so huge.
This can be done automatically with `reuse download --all`.
The `reuse` tool also contains a handy subcommand that analyzes the
project and tells whether or not the project is (still) compliant,
`reuse lint`.
Following REUSE has a few advantages over the current approach:
- Copyright information is easy to access for users / downstream
- Files like `dist/license.md` do not need to exist anymore, as
`.reuse/dep5` is used instead
- `reuse lint` makes it easy to ensure that copyright information of
files like binary assets / images is always accurate and up to date
To add copyright information of files that didn't have it I looked up
who committed what and when, for each file. As yuzu contributors do not
have to sign a CLA or similar I couldn't assume that copyright ownership
was of the "yuzu Emulator Project", so I used the name and/or email of
the commit author instead.
[REUSE]: https://reuse.software
Follow-up to 01cf05bc75b1e47beb08937439f3ed9339e7b254
|
| |
|
| |
|
|
|
|
| |
Now that the entire project is free of variable shadowing, we can enforce this as a compile time error to prevent any further introduction of this logic bug.
|
|
|
|
| |
These are similar to Wunused-function on gcc/clang
|
|
|
| |
It was needed on GCC versions not supporting `-std=c++20`, but GCC 10 and newer (required to compile yuzu) don't need it anymore
|
| |
|
|
|
|
| |
This increases the memory heap size for constructing precompiled headers to 2x the default.
|
| |
|
| |
|
| |
|
|
|
|
| |
Treats (un)signed comparison mismatches as errors to be consistent with MSVC
|
|\
| |
| | |
general: Enforce multiple warnings in MSVC
|
| |
| |
| |
| |
| |
| | |
This lets us avoid needing to wrap external headers with #pragma warning directives for warnings we treat as errors and avoids generating warnings for external code.
Thanks to MerryMage for pointing this out.
|
| | |
|
|/
|
|
| |
This supplements C4101 by detecting initialized but unreferenced local variables
|
|
|
|
| |
This is similar to -Werror=return-type
|
|
|
|
| |
Ensures that the source and execution character sets are in UTF-8
|
| |
|
|\
| |
| | |
cmake: Remove yuzu_tester
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We never ended up using yuzu_tester.
Removing it saves code duplication with yuzu_cmd, and distribution size on
prebuilt packages.
For unit testing, we can use catch2 from guest code and dump the results
to a file. Then execute yuzu from a script on ci if we want this to be
automated.
|
|/ |
|
| |
|
|
|
|
| |
This matches GCC's -Wunused-variable
|
|
|
|
|
|
| |
This should match some warnings we treat as errors on gcc and clang,
caching bugs early and reducing the number of instances where we have to
edit commits to make CI happy when developing from Windows.
|
| |
|
|
|
|
|
|
| |
This Clang warning complains when offsetof is used on a
non-standard-layout type (i.e. any class using various C++ features),
even though it works fine (and is not undefined behavior as of C++17).
|
|
|
|
| |
Prevents the compiler tripping up about Windows headers.
|
|
|
|
|
| |
MSVC lets us fine-tune catching expressions with no side-effects a
little more.
|
|
|
|
|
|
|
| |
Allows our CI to catch more potential bugs. This also removes the
[[nodiscard]] attribute of IOFile's Open member function. There are
cases where a file may want to be opened, but have the status of it
checked at a later time.
|
|
|
|
|
| |
This switch is enabled by default in all recent versions of GCC and
Clang.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer
With the support of C++20, we can use concepts to deduce if a type is an STL container or not.
* More agressive concept for stl containers
* Add -fconcepts
* Move to common namespace
* Add Common::IsBaseOf
|
| |
|
|
|
|
| |
Ensures that our code always has its linkage explicit.
|
|
|
|
|
| |
Allows catching cases where internal linkage isn't specified for helper
functions when they should be marked as such.
|
|
|
|
|
|
|
|
|
|
|
| |
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.
We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).
While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
|
|
|
|
|
|
| |
This can result in silent logic bugs within code, and given the amount
of times these kind of warnings are caused, they should be flagged at
compile-time so no new code is submitted with them.
|
|
|
|
|
|
|
| |
This significantly reduces unnecessary disk writes and space usage
when building Citra.
libcore.a is now only ~1MB rather than several hundred megabytes.
|
| |
|
|\
| |
| | |
CMakeLists: Specify /volatile:iso for MSVC
|
| |
| |
| |
| |
| |
| | |
By default, MSVC doesn't use standards-compliant volatile semantics.
This makes it behave in a standards-compliant manner, making
expectations more uniform across compilers.
|
|\ \
| |/
|/| |
CMakeLists: Explicitly specify -Wall for the non-MSVC case
|
| |
| |
| |
| | |
Ensures that -Wall is always active as a compilation flag.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The C++ standard allows constexpr variables declared with the extern
keyword to have external linkage. Previously MSVC wasn't abiding by
this. This just makes the compiler more standards compliant during
builds.
Given we currently don't make use of anything that would break by this,
this is safe to enable.
|
|/
|
|
|
| |
Makes it much nicer to visually scan the options. This also starts the
flag descriptions from the same column for the same reason.
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we were building with MBCS, which is pretty undesirable. We
want the application to be Unicode-aware in general.
Currently, we make the command line variant of yuzu use ANSI variants of
the non-standard getopt functions that we link in for Windows, given we
only have an ANSI option-set.
We should really replace getopt with a library that we make all build
types of yuzu link in, but this will have to do for the time being.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modifying CMAKE_* related flags directly applies those changes to every
single CMake target. This includes even the targets we have in the
externals directory.
So, if we ever increased our warning levels, or enabled particular ones,
or enabled any other compilation setting, then this would apply to
externals as well, which is often not desirable.
This makes our compilation flag setup less error prone by only applying
our settings to our targets and leaving the externals alone entirely.
This also means we don't end up clobbering any provided flags on the
command line either, allowing users to specifically use the flags they
want.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We generally shouldn't be hijacking CMAKE_CXX_FLAGS, etc as a means to
append flags to the targets, since this adds the compilation flags to
everything, including our externals, which can result in weird issues
and makes the build hierarchy fragile.
Instead, we want to just apply these compilation flags to our targets,
and let those managing external libraries to properly specify their
compilation flags.
This also results in us not getting as many warnings, as we don't raise
the warning level on every external target.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added support for network with ENet lib,
connecting is possible, but data can't be sent, yet.
* fixup! Added support for network with ENet lib,
* fixup! CLang
* fixup! Added support for network with ENet lib,
* fixup! Added support for network with ENet lib,
* fixup! Clang format
* More fixups!
* Moved ENetHost* and ENetPeer* into pimpl classes
* fixup! Moved ENetHost* and ENetPeer* into pimpl classes
* fixup! Clang again
* fixup! Moved ENetHost* and ENetPeer* into pimpl classes
* fixup! Moved ENetHost* and ENetPeer* into pimpl classes
* fixup! Moved ENetHost* and ENetPeer* into pimpl classes
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
citra: Remove GLFW, Add SDL2
FindSDL2: Do not CACHE SDL2_* variables if library is not found
EmuWindow_SDL2: Set minimal client area at initialisation time
EmuWindow_SDL2: Corrections
EmuWindow_SDL2: Fix no decorations on startup on OS X
cmake: windows_copy_files
|
|
|
|
|
|
|
|
|
| |
This commit:
* Adds a new subproject, audio_core.
* Defines structures that exist in DSP shared memory.
* Hooks up various other parts of the emulator into audio core.
This sets the foundation for a later HLE DSP implementation.
|
|
|
|
|
|
|
|
| |
Several cleanups to the buildsystem:
- Do better factoring of common libs between platforms.
- Add support to building on Windows.
- Remove Qt4 support.
- Re-sort file lists and add missing headers.
|
| |
|
| |
|
| |
|
| |
|
|
|