summaryrefslogtreecommitdiffstats
path: root/src/audio_core (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Allow 0 stereo countKelebek12023-11-032-3/+3
|
* audio: fix shutdown deadlock in audio rendererLiam2023-10-131-0/+4
|
* Clear DSP buffer after each executionKelebek12023-10-102-0/+11
|
* ci: fix new codespell errorsLiam2023-10-031-1/+1
|
* Merge pull request #11520 from Kelebek1/estimated_timeliamwhite2023-09-182-6/+8
|\ | | | | Do not consider voice commands in time estimation, fix adpcm estimate
| * Do not consider voice commands in time estimation, fix adpcm estimateKelebek12023-09-182-6/+8
| |
* | Reimplement HardwareOpusKelebek12023-09-1620-72/+1465
|/
* Merge pull request #11465 from Kelebek1/skip_remaining_resetliamwhite2023-09-105-27/+14
|\ | | | | [Audio] Do not reset the remaining command count each time
| * Do not reset the command buffer command count each timeKelebek12023-09-075-27/+14
| |
* | Fix data source version 1 command loopingKelebek12023-09-084-52/+72
|/
* Merge pull request #11428 from Kelebek1/adsp_reworkliamwhite2023-09-06169-1252/+1046
|\ | | | | Rework ADSP into a wrapper for apps
| * Rework ADSP into a wrapper for appsKelebek12023-09-04169-1252/+1046
| |
* | msvc: set warning level to /W4 globallyDanila Malyutin2023-09-031-1/+0
|/ | | | And fix a bunch of warnings
* Merge pull request #11408 from Kelebek1/fix_audio_node_idliamwhite2023-08-291-1/+1
|\ | | | | [Audio] Fix node id index in DropVoices
| * Fix node id index in DropVoicesKelebek12023-08-281-1/+1
| |
* | audio: allow more latency in cubeb initializationLiam2023-08-272-8/+3
| |
* | Pre-test opening a stream for audio backends, fall back to null if not suitable.Kelebek12023-08-235-38/+117
|/
* Merge pull request #10839 from lat9nq/pgc-plusliamwhite2023-08-022-19/+23
|\ | | | | general: Reimplement per-game configurations
| * (ui,)settings: Use explicit instantiationlat9nq2023-07-211-3/+2
| | | | | | | | Reduces compile times a tad on clang.
| * settings,general: Rename non-confirming enumslat9nq2023-07-211-2/+3
| |
| * configure_audio: Implement ui generationlat9nq2023-07-212-19/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Needs a considerable amount of management specific to some of the comoboboxes due to the audio engine configuration. general: Partial audio config implmentation configure_audio: Implement ui generation Needs a considerable amount of management specific to some of the comoboboxes due to the audio engine configuration. general: Partial audio config implmentation settings: Make audio settings as enums
* | Fix AudioRendererParameterInternal's sizeKelebek12023-07-301-3/+3
|/
* Use spans over guest memory where possible instead of copying data.Kelebek12023-07-033-77/+32
|
* sink_stream: Resolve heap buffer corruption due to out of bounds writeMorph2023-06-302-17/+20
| | | | Also, remove the use of ScratchBuffer when upmixing, as other channels may not be initialized with zeroed out data.
* Remove memory allocations in some hot pathsKelebek12023-06-2220-73/+80
|
* Merge pull request #10086 from Morph1984/coretiming-ng-1bunnei2023-06-225-15/+8
|\ | | | | core_timing: Use CNTPCT as the guest CPU tick
| * core_timing: Use CNTPCT as the guest CPU tickMorph2023-06-085-15/+8
| | | | | | | | | | Previously, we were mixing the raw CPU frequency and CNTFRQ. The raw CPU frequency (1020 MHz) should've never been used as CNTPCT (whose frequency is CNTFRQ) is the only counter available.
* | nvnflinger: allow locking framerate during video playbackLiam2023-06-082-22/+0
|/
* android: audio_core: sink_stream: Remove unnecessary check.bunnei2023-06-061-3/+0
|
* Merge pull request #10508 from yuzu-emu/limebunnei2023-06-061-0/+3
|\ | | | | Project Lime - yuzu Android Port
| * android: audio_core: Avoid shutdown hang.bunnei2023-06-031-0/+3
| |
* | audio_renderer: resolve adsp thread deadlock shutdownLiam2023-06-044-10/+12
|/
* Audren wait as suggested by ByLawsKelebek12023-05-271-0/+3
|
* Smooth out the DSP callback by adding a 5ms wait time limitKelebek12023-05-184-16/+12
|
* Merge pull request #10162 from lat9nq/sdl-remove-oldliamwhite2023-05-071-10/+1
|\ | | | | yuzu-sdl,audio_core: Remove antiquated warning ignore
| * yuzu-sdl,audio_core: Remove antiquated warning ignorelat9nq2023-05-051-10/+1
| | | | | | | | | | Issue was fixed a long time ago, both by SDL2 and in yuzu by including SDL2 as a system library.
* | Wait for the terminate event before destroying a system instanceKelebek12023-05-011-4/+1
|/
* Use GetGlobalTimeNs as opposed to clock ticksBilly Laws2023-04-082-4/+3
|
* Add some explicit latency to sample count reportingBilly Laws2023-04-041-1/+2
| | | | Some games have very tight scheduling requirements for their audio which can't really be matched on the host, adding a constant to the reported value helps to provide some leeway.
* Merge pull request #9969 from bylaws/masterbunnei2023-04-019-79/+55
|\ | | | | Audio synchronisation improvements
| * audio_core: No longer stall when sink queue is fullBilly Laws2023-03-274-64/+1
| | | | | | | | Now the audout and audren update rates are tied to the sink status stalling is no longer necessary.
| * Run clang-formatBilly Laws2023-03-273-7/+6
| |
| * audio: Wait for samples on the emulated DSP side to avoid desyncsBilly Laws2023-03-276-24/+28
| | | | | | | | Waiting on the host side is inaccurate and leads to desyncs in the event of the sink missing a deadline that require stalls to fix. By waiting for the sink to have space before even starting rendering such desyncs can be avoided.
| * audio: Interpolate system manager sample count using host sink sample infoBilly Laws2023-03-264-3/+39
| | | | | | | | This avoids the need to stall if the host sink sporadically misses the deadline, in such a case the previous implementation would report them samples as being played on-time, causing the guest to send more samples and leading to a gradual buildup.
* | memory: rename global memory references to application memoryLiam2023-03-244-6/+5
|/
* general: fix spelling mistakesLiam2023-03-1216-27/+27
|
* Merge pull request #9917 from Morph1984/the-real-timeliamwhite2023-03-101-1/+1
|\ | | | | native_clock: Re-adjust the RDTSC frequency to its real frequency
| * core: Promote CPU/GPU threads to time criticalMorph2023-03-081-1/+1
| | | | | | | | And also demote Audren and CoreTiming to High thread priority.
* | hle: rename legacy errors to ResultsLiam2023-03-0713-64/+64
|/
* Fix a bug with the Reverb command in reading from the pre_delay line.Kelebek12023-03-023-6/+8
|
* Merge pull request #9769 from Kelebek1/audio_oobbunnei2023-02-162-40/+92
|\ | | | | [audio_core] Fix depop prepare
| * Add fallback for memory read/write in case the address goes over a 4K pageKelebek12023-02-111-12/+64
| |
| * Fix depop prepare receiving bad mix infos and writing out of bounds, and update aux a bit, may helpKelebek12023-02-112-40/+40
| |
* | Merge pull request #9796 from liamwhite/currentliamwhite2023-02-152-3/+3
|\ \ | | | | | | general: rename CurrentProcess to ApplicationProcess
| * | general: rename CurrentProcess to ApplicationProcessLiam2023-02-142-3/+3
| | |
* | | remove static from pointer sized or smaller types for aesthetics, change constexpr static to static constexpr for consistencyarades792023-02-1412-39/+39
| | | | | | | | | | | | Signed-off-by: arades79 <scravers@protonmail.com>
* | | add static lifetime to constexpr values to force compile time evaluation where possiblearades792023-02-1412-39/+39
| | | | | | | | | | | | Signed-off-by: arades79 <scravers@protonmail.com>
* | | Fix biquad filter command's state buffer offsetKelebek12023-02-131-2/+2
|/ /
* | biquad_filter: Clamp f64 in ApplyBiquadFilterFloatMerry2023-02-101-3/+3
| |
* | biquad_filter: Fix rounding in ApplyBiquadFilterIntMerry2023-02-102-24/+16
|/
* audio: cubeb: Fix yuzu crashing when it test for latencyNarr the Reg2023-02-101-0/+20
|
* upsample: Fix coefficient formatMerry2023-01-141-26/+26
|
* audio_core: Fix off-by-one error in upsamplerMerry2023-01-141-33/+12
|
* cmake: make cubeb and SDL2 optionalLiam2022-12-281-6/+13
|
* Signal buffer event on audio in/out system stop, and force remove all registered audio buffersKelebek12022-12-165-7/+26
|
* audio_core: remove explicitly defaulted and implicitly deleted constructorsLiam2022-12-102-2/+0
|
* cmake: use sdl2 imported targetAlexandre Bouvier2022-12-061-5/+1
|
* cmake: prefer system librariesAlexandre Bouvier2022-12-041-2/+2
|
* Merge pull request #9300 from ameerj/pchliamwhite2022-12-032-0/+11
|\ | | | | CMake: Use precompiled headers to improve compile times
| * CMake: Consolidate common PCH headersameerj2022-12-011-7/+1
| |
| * CMake: Use precompiled headersameerj2022-11-302-0/+17
| |
* | Merge pull request #9289 from liamwhite/fruit-companyliamwhite2022-12-039-4/+14
|\ \ | | | | | | general: fix compile for Apple Clang
| * | general: fix compile for Apple ClangLiam2022-11-239-4/+14
| | |
* | | Merge pull request #9320 from yuzu-emu/fix-audio-suspendFernando S2022-11-302-7/+9
|\ \ \ | | | | | | | | AudioCore: Take suspend lock when stalling the running process.
| * | | audio_core: sink_stream: Hold the suspend lock when process is stalled.bunnei2022-11-302-7/+9
| |/ / | | | | | | | | | - Prevents us from clashing with other callers trying to un/stall.
* | / CMake: Directly link to SDL2-static when appropriatelat9nq2022-11-291-1/+5
| |/ |/| | | | | | | Trying to be lazy and alias SDL2 to SDL2-static causes issues in later versions of CMake. Just use the same condition to tell which one to use.
* | Use the maximum input index for samples buffer span size, not just the input countKelebek12022-11-221-6/+8
|/
* Add break for default casesKyle Kienapfel2022-11-141-0/+1
| | | | | | | | | | | Visual Studio has an option to search all files in a solution, so I did a search in there for "default:" looking for any missing break statements. I've left out default statements that return something, and that throw something, even if via ThrowInvalidType. UNREACHABLE leads towards throw R_THROW macro leads towards a return
* Initial ARM64 supportLiam2022-11-091-1/+1
|
* audio_in/out_system: Pass Initialize members by value where applicableLioncash2022-10-264-6/+6
| | | | | | | | | | | applet_resource_user_id isn't actually modified and is just assigned to a member variable, so this doesn't need to be a mutable reference. Similarly, the device name itself isn't modified and is only moved. We pass by value here, since we can still perform the move, but eliminate a sneaky set of calls that can unintentionally destroy the original string. Given how nested the calls are, it's good to get rid of this potential vector for a use-after-move bug.
* general: Resolve -Wclass-memaccessMorph2022-10-223-3/+3
|
* general: Enforce C4800 everywhere except in video_coreMorph2022-10-221-0/+1
|
* CMakeLists: Remove all redundant warningsMorph2022-10-221-10/+0
| | | | These are already explicitly or implicitly set in src/CMakeLists.txt
* Update audio_core for firmware 15.0.0Kelebek12022-10-193-33/+72
|
* sdl2_sink: Inline variable init into if conditionlat9nq2022-10-171-2/+1
| | | | Co-authored-by: Mai <mathew1800@gmail.com>
* sdl2_sink: Distinguish between capture and non-capture device nameslat9nq2022-10-161-1/+1
| | | | | | | | The function prototype appears to care whether we are loading capture devices or not, and SDL_GetAudioDeviceName has a parameter to use it, but for some reason it isn't. This puts `capture` where it goes.
* sdl2_sink: Check for null string when loading SDL audio deviceslat9nq2022-10-161-1/+4
| | | | | | | Attempting to place a null string into a vector of strings causes an error that closes the application. Don't.
* Merge pull request #9061 from liamwhite/writable-eventliamwhite2022-10-143-8/+8
|\ | | | | kernel: remove KWritableEvent
| * kernel: remove KWritableEventLiam2022-10-133-8/+8
| |
* | audio_core: Revert sink name to sdl2Narr the Reg2022-10-141-2/+2
| |
* | Choose the SDL audio backend when Cubeb reports too high of a latencyKelebek12022-10-096-30/+93
|/
* common: remove "yuzu:" prefix from thread namesLiam2022-10-042-2/+2
|
* Merge pull request #8941 from Kelebek1/single_core_sucksbunnei2022-09-241-2/+7
|\ | | | | Do not try to pause core timing from the audio thread when using single-core
| * Do not try to pause core timing from the audio thread when using single-coreKelebek12022-09-221-2/+7
| |
* | Merge pull request #8939 from lioncash/renderMorph2022-09-232-2/+2
|\ \ | | | | | | audio_renderer: Make GetCommandBuffer() take a u32
| * | audio_renderer: Make GetCommandBuffer() take a u32Lioncash2022-09-212-2/+2
| |/ | | | | | | | | | | This function is only ever called with unsigned types, and all of the other interface functions take session_id as a u32, so this makes the class a little more consistent.
* | audio_manager: Forward declare result typeLioncash2022-09-212-1/+3
| | | | | | | | Moves the include into the cpp file to lessen header dependencies.
* | audio_manager: Remove redundant cast in ThreadFunc()Lioncash2022-09-211-3/+5
| | | | | | | | We can just use a local here to get rid of a second cast.
* | audio_manager: move std::functions in SetOutManager/SetInManagerLioncash2022-09-211-2/+2
| | | | | | | | | | Prevents unnecessary reallocations in the event the captured variables are larger than the internal std::function buffer.
* | audio_manager: Remove unused forward declarationsLioncash2022-09-212-10/+0
| | | | | | | | | | Allows us to get rid of some unnecessary forward declarations and includes.
* | audio_manager: Remove unused sessions_started member variableLioncash2022-09-211-2/+0
| | | | | | | | This isn't used, so it can be removed.
* | audio_manager: Remove dependence on system stateLioncash2022-09-213-10/+4
|/ | | | This isn't used by the class, so this can be removed for the time being.
* Merge pull request #8914 from lioncash/audio-constbunnei2022-09-1725-82/+87
|\ | | | | audio_core: Mark several member functions as const
| * audio_renderer: Pass command buffer by const referenceLioncash2022-09-164-4/+4
| | | | | | | | This is just being copied and isn't modified at all.
| * sink_stream: Mark GetQueueSize as constLioncash2022-09-161-1/+1
| |
| * node_states: Mark relevant member functions as constLioncash2022-09-161-2/+2
| |
| * i3dl2/reverb: Mark relevant member functions as constLioncash2022-09-162-4/+4
| | | | | | | | These two don't modify member state.
| * behavior_info: Mark CopyErrorInfo as constLioncash2022-09-164-6/+6
| | | | | | | | | | | | | | This doesn't modify member state. We can also mark the parameter of AppendError as const as well, since it isn't modified.
| * audio_device: Mark GetDeviceVolume as constLioncash2022-09-162-2/+2
| | | | | | | | This doesn't modify instance state.
| * audio_render_manager: Mark several functions as constLioncash2022-09-162-6/+6
| |
| * audio_in: Mark several functions as constLioncash2022-09-164-18/+18
| | | | | | | | These functions don't modify class state, so we can mark them as such
| * audio_out: Mark several functions as constLioncash2022-09-164-16/+17
| | | | | | | | These don't affect class state, so we can mark them as such.
| * audio_buffers: Pass by const-ref in AppendBuffersLioncash2022-09-163-13/+17
| | | | | | | | | | This function doesn't modify the passed in buffer, so we can make that explicit.
| * device_session: Convert for loop into ranged for in AppendBuffersLioncash2022-09-161-5/+5
| | | | | | | | Simplifies the indexing code a little bit.
| * device_session: Pass arguments by const-ref in relevant functionsLioncash2022-09-163-7/+7
| | | | | | | | | | These functions don't modify the passed in audio buffers, so we can signify that in the interface.
* | Merge pull request #8911 from lioncash/cexpr-stringMorph2022-09-164-23/+37
|\ \ | |/ |/| audio_device: Make AudioDeviceName constructor constexpr
| * audio_device: Mark member functions as const where applicableLioncash2022-09-152-8/+8
| | | | | | | | These member functions don't modify any internal state.
| * audio_device: Make AudioDeviceName constructor constexprLioncash2022-09-154-15/+29
| | | | | | | | | | | | | | | | These are used as read-only arrays, so we can make the data read-only and available at compile-time. Now constructing an AudioDevice no longer needs to initialize some tables
* | Merge pull request #8878 from Kelebek1/remove_pausebunnei2022-09-1512-120/+29
|\ \ | | | | | | Remove pause callbacks from coretiming
| * | Remove pause callbacks from coretimingKelebek12022-09-1312-120/+29
| | |
* | | Merge pull request #8901 from lioncash/docsliamwhite2022-09-1528-112/+105
|\ \ \ | | | | | | | | audio_core: Amend documentation comment tags
| * | | audio_core: Amend documentation tagsLioncash2022-09-1528-112/+105
| | |/ | |/| | | | | | | | | | Resolves a wackload of -Wdocumentation warnings due to mismatching tags and whatnot.
* | | compressor: Simplify memset in InitializeCompressorEffectLioncash2022-09-131-1/+1
| | | | | | | | | | | | Provides equivalent behavior while being significantly smaller.
* | | compressor: Mark params parameters as constLioncash2022-09-131-3/+3
| | | | | | | | | | | | These functions don't modify the parameters.
* | | compressor: Remove unneeded casts in ApplyCompressorEffectLioncash2022-09-131-2/+1
|/ / | | | | | | | | Same behavior, but also silences a -Wcast-qual warning, since the second cast casts away const.
* / Remove a pragma once from a cpp fileKelebek12022-09-121-2/+0
|/
* Don't stall with nvdecKelebek12022-09-043-1/+29
|
* Rework audio output, connecting AudioOut into coretiming to fix desync during heavy loads.Kelebek12022-09-0222-842/+549
|
* Do some log memes to help perceived volumeKelebek12022-08-121-0/+3
|
* audio_core: fix -Wuninitialized when compiling with ASanLiam2022-07-301-4/+4
|
* Avoid depop out of boundsKelebek12022-07-282-2/+2
|
* chore: make yuzu REUSE compliantAndrea Pappacoda2022-07-271-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [REUSE] is a specification that aims at making file copyright information consistent, so that it can be both human and machine readable. It basically requires that all files have a header containing copyright and licensing information. When this isn't possible, like when dealing with binary assets, generated files or embedded third-party dependencies, it is permitted to insert copyright information in the `.reuse/dep5` file. Oh, and it also requires that all the licenses used in the project are present in the `LICENSES` folder, that's why the diff is so huge. This can be done automatically with `reuse download --all`. The `reuse` tool also contains a handy subcommand that analyzes the project and tells whether or not the project is (still) compliant, `reuse lint`. Following REUSE has a few advantages over the current approach: - Copyright information is easy to access for users / downstream - Files like `dist/license.md` do not need to exist anymore, as `.reuse/dep5` is used instead - `reuse lint` makes it easy to ensure that copyright information of files like binary assets / images is always accurate and up to date To add copyright information of files that didn't have it I looked up who committed what and when, for each file. As yuzu contributors do not have to sign a CLA or similar I couldn't assume that copyright ownership was of the "yuzu Emulator Project", so I used the name and/or email of the commit author instead. [REUSE]: https://reuse.software Follow-up to 01cf05bc75b1e47beb08937439f3ed9339e7b254
* Project AndioKelebek12022-07-22237-7621/+30231
|
* Rework CoreTimingKelebek12022-07-102-5/+10
|
* core: Replace all instances of ResultCode with Resultgerman772022-06-275-15/+14
|
* Merge pull request #8383 from Morph1984/shadow-of-the-pastMai2022-06-151-3/+0
|\ | | | | yuzu: Make variable shadowing a compile-time error
| * audio_core: Remove -Werror=unused-parameterMorph2022-06-141-1/+0
| | | | | | | | Removing this as we don't enforce unused parameter warnings elsewhere in the project, and explicitly specify -Wno-unused-parameter in the main CMakeLists.
| * CMakeLists: Make variable shadowing a compile-time errorMorph2022-06-141-2/+0
| | | | | | | | Now that the entire project is free of variable shadowing, we can enforce this as a compile time error to prevent any further introduction of this logic bug.
* | common: Change semantics of UNREACHABLE to unconditionally crashLiam2022-06-144-7/+7
|/
* command_generator: Use u8 for tap index lutMorph2022-05-131-8/+8
| | | | Using this smaller type saves 1024 bytes in the compiled executable.
* general: Convert source file copyright comments over to SPDXMorph2022-04-2343-129/+86
| | | | | This formats all copyright comments according to SPDX formatting guidelines. Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
* audio_core: remove time stretcherAndrea Pappacoda2022-04-015-131/+3
| | | | Also drop the SoundTouch dependency
* audio_core: Update current process revisionlat9nq2022-02-111-1/+3
| | | | | | | Update CURRENT_PROCESS_REVISION from REV9 to REVA. Used by Nintendo Entertainment System - Nintendo Switch Online 6.0.0 and Super Nintendo Entertainment System - Nintendo Switch Online 3.0.0.
* audio/stream: Adjust volume scale factorgerman772022-01-161-2/+2
|
* general: Add missing copyright noticesameerj2021-12-052-0/+8
|
* common/logging: Move Log::Entry declaration to a separate headerameerj2021-10-023-0/+7
| | | | This reduces the load of requiring to include std::chrono in all files which include log.h
* Merge pull request #6571 from Kelebek1/Mixbunnei2021-07-131-0/+9
|\ | | | | audio_core: Replace NaN mix volume samples with silence
| * Replace NaN mix volume samples with silence.Kelebek12021-07-081-0/+9
| | | | | | | | Fixes Xenoblade Chronicles 2 blowing out the audio.
* | Merge pull request #6539 from lat9nq/default-settingAmeer J2021-07-081-1/+2
|\ \ | | | | | | general: Move most settings' defaults and labels into their definition
| * | general: Make most settings a BasicSettinglat9nq2021-06-281-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Creates a new BasicSettings class in common/settings, and forces setting a default and label for each setting that uses it in common/settings. Moves defaults and labels from both frontends into common settings. Creates a helper function in each frontend to facillitate reading the settings now with the new default and label properties. Settings::Setting is also now a subclass of Settings::BasicSetting. Also adds documentation for both Setting and BasicSetting.
* | | Merge pull request #6564 from Kelebek1/AudioMorph2021-07-082-18/+51
|\ \ \ | |_|/ |/| | Support more PCM formats
| * | Support more PCM formats. Fixes Ys IX audio.Kelebek12021-07-062-18/+51
| | |
* | | audio_core: Preserve front channel volume after 6 to 2 downmixKelebek12021-07-085-75/+81
| | | | | | | | | | | | | | | | | | Many games report 6 channel output while only providing data for 2. We only output 2-channel audio regardless, and in the downmixing, front left/right only provide 36% of their volume. This is done assuming all of the other channels also contain valid data, but in many games they don't. This PR alters the downmixing to preserve front left/right, so volume is not lost. This improves volume in Link's Awakening, New Super Mario Bros U, Disgaea 6, Super Kirby Clash.
* | | CMakeLists: Treat -Wsign-compare as an error on GCC/ClangMorph2021-07-061-3/+0
|/ / | | | | | | Treats (un)signed comparison mismatches as errors to be consistent with MSVC
* | Fix XC2/VOEZ crashing, add audio looping and a few misc fixesKelebek12021-07-016-131/+187
| |
* | Decouple audio processing and run at variable rateKelebek12021-06-272-75/+109
| | | | | | | | | | | | Currently, processing of audio samples is called from AudioRenderer's Update method, using a fixed 4 buffers to process the given samples. Games call Update at variable rates, depending on framerate and/or sample count, which causes inconsistency in audio processing. From what I've seen, 60 FPS games update every ~0.004s, but 30 FPS/160 sample games update somewhere between 0.02 and 0.04, 5-10x slower. Not enough samples get fed to the backend, leading to a lot of audio skipping. This PR seeks to address this by de-coupling the audio consumption and the audio update. Update remains the same without calling for buffer queuing, and the consume now schedules itself to run based on the sample rate and count.
* | audio_core: common: Bump audio revision to 9.bunnei2021-06-251-1/+1
|/ | | | - This is used in fw 12.x.x games.
* Add missing includes (#6521)Chloe2021-06-241-0/+2
| | | | | * Add missing includes * Add array
* Implement audout GetAudioOutPlayedSampleCountKelebek12021-06-222-2/+11
| | | | Used in Ninja Gaiden games.
* Various suggestions by v1993 and lioncashClément Gallet2021-06-071-10/+6
|
* Add SDL2 audio backendClément Gallet2021-06-064-0/+211
|
* general: Replace RESULT_SUCCESS with ResultSuccessMorph2021-06-022-2/+2
| | | | Transition to PascalCase for result names.
* common: Move settings to common from core.bunnei2021-04-154-4/+4
| | | | - Removes a dependency on core and input_common from common.
* revert to std::sin and std::cosChloe Marcec2021-02-133-6/+6
|
* address issuesChloe Marcec2021-02-133-22/+25
|
* audren: Implement I3dl2ReverbChloe Marcec2021-02-138-18/+569
| | | | Most notable fix is the voices in Fire Emblem Three Houses
* Merge pull request #5868 from german77/HandheldFixbunnei2021-02-081-1/+8
|\ | | | | Prevent over scheduling audio events and add motion update unschedule event
| * Prevent over scheduling audio events and terminate properly the motion update eventgerman2021-02-021-1/+8
| |
* | audren: Disable reverb for the time beingChloe Marcec2021-02-011-1/+4
| | | | | | | | As this is causing issues in a few games, it's best to have it disabled until it's completely implemented
* | audout: FlushAudioOutBuffersChloe Marcec2021-01-242-0/+11
| | | | | | | | Fixes Devil May Cry
* | core: Silence Wclass-memaccess warningsReinUsesLisp2021-01-151-18/+18
|/ | | | | This requires making several types trivial and properly initialize them whenever they are called.
* common/common_funcs: Rename INSERT_UNION_PADDING_{BYTES,WORDS} to _NOINITReinUsesLisp2021-01-151-3/+3
| | | | INSERT_PADDING_BYTES_NOINIT is more descriptive of the underlying behavior.
* Merge pull request #5264 from 16-Bit-Dog/patch-1bunnei2020-12-311-1/+1
|\ | | | | Make the coding conventions more consistant
| * Make the coding conventions more consistant16-Bit-Dog2020-12-311-1/+1
| | | | | | | | | | lut_index had 0 added when nothing was supposed to be added despite this, index was not added to 0 when nothing was supposed to be added...
* | hle: service: Acquire and release a lock on requests.bunnei2020-12-292-15/+6
| | | | | | | | - This makes it such that we can safely access service members from CoreTiming thread.
* | audio_core: stream: Ensure buffer is valid before release.bunnei2020-12-291-2/+10
|/
* Update cubeb and request a persistent stream sessionVitor Kiguchi2020-12-051-0/+1
|
* Merge pull request #5000 from lioncash/audio-errorbunnei2020-12-0323-139/+147
|\ | | | | audio_core: Make shadowing and unused parameters errors
| * audio_core: Make shadowing and unused parameters errorsLioncash2020-12-0323-139/+147
| | | | | | | | Moves the audio code closer to enabling warnings as errors in general.
* | audio_core: Remove temp_mix_bufferChloe Marcec2020-11-282-3/+1
|/ | | | It's unused and doesn't need to be initialized
* Addressed changesChloe Marcec2020-11-174-10/+13
|
* audren: Make use of nodiscard, rework downmixing, release all buffersChloe Marcec2020-11-1713-102/+194
| | | | | | Preliminary work for upmixing & general cleanup. Fixes basic issues in games such as Shovel Knight and slightly improves the LEGO games. Upmixing stitll needs to be implemented. Audio levels in a few games will be fixed as we now use the downmix coefficients when possible instead of supplying our own
* core: Fix clang build pt.2Lioncash2020-10-211-2/+5
| | | | Resolves the clang build issue in a more unintrusive way.
* Revert "core: Fix clang build"bunnei2020-10-2114-215/+169
|
* core: Fix clang buildLioncash2020-10-1814-169/+215
| | | | | | | Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
* audio_core/CMakeLists: Make warnings consistent with coreLioncash2020-10-136-8/+17
| | | | Normalizes the warnings shared between audio_core and core.
* Merge pull request #4721 from lioncash/genfnbunnei2020-09-303-5/+7
|\ | | | | codec: Make lookup table static constexpr
| * command_generator: Make lookup table static constexprLioncash2020-09-261-2/+3
| | | | | | | | | | Allows compilers to elide needing to push these values on the stack every time the function is called.
| * codec: Make lookup table static constexprLioncash2020-09-252-3/+4
| | | | | | | | | | Allows compilers to elide needing to push these values on the stack every time the function is called.
* | Merge pull request #4722 from lioncash/castingbunnei2020-09-301-2/+2
|\ \ | | | | | | cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback()
| * | cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback()Lioncash2020-09-251-2/+2
| |/ | | | | | | | | Conversions from void* to the proper data type are well-defined and supported by static_cast. We don't need to use reinterpret_cast here.
* | Merge pull request #4719 from lioncash/audio-warnbunnei2020-09-278-38/+46
|\ \ | | | | | | audio_core: Resolve sign conversion warnings
| * | audio_core: Resolve sign conversion warningsLioncash2020-09-258-25/+34
| | | | | | | | | | | | | | | | | | While were at it, we can also enable sign conversion warnings and other common warnings as errors to prevent these from creeping back into the codebase.
| * | effect_context: Make use of explicit where applicableLioncash2020-09-251-13/+12
| |/ | | | | | | | | While we're at it we can make the destructor of the base class virtual to ensure that any polymorphism issues never occur.
* | Merge pull request #4720 from lioncash/headerbunnei2020-09-265-7/+2
|\ \ | | | | | | audio_core: Remove unnecessary inclusions
| * | audio_core: Remove unnecessary inclusionsLioncash2020-09-255-7/+2
| |/ | | | | | | | | Same behavior, but removes header dependencies where they don't need to be.
* / behavior_info: Fix typo Renerer -> RendererLioncash2020-09-252-6/+6
|/
* audio_core/command_generator: Use const references where applicableLioncash2020-09-171-10/+11
| | | | | | | | In a lot of cases, we can make use of const references rather than non-const references. While we're in the area we can silence some truncation and sign conversion warnings.
* audio_core/command_generator: Avoid an unnecessary copy in GenerateFinalMixCommand()Lioncash2020-09-171-1/+1
|
* Merge pull request #4310 from ogniK5377/apollo-1-prodbunnei2020-09-1126-647/+4971
|\ | | | | audio_core: Apollo Part 1, AudioRenderer refactor
| * Preliminary effectsDavid Marcec2020-08-1610-35/+731
| |
| * Disable biquad filterDavid Marcec2020-08-141-8/+9
| |
| * Reworked ADPCM decoder to allow better streamingDavid Marcec2020-08-142-33/+95
| |
| * mix buffer depoppingDavid Marcec2020-08-012-30/+101
| |
| * adpcm streamingDavid Marcec2020-07-304-27/+32
| |
| * Fix perf regressionDavid Marcec2020-07-251-1/+2
| |
| * Fix stream channel count when outputting to stereoDavid Marcec2020-07-251-1/+1
| |
| * Address issuesDavid Marcec2020-07-258-101/+104
| |
| * Queue extra mix bufferDavid Marcec2020-07-251-0/+1
| |
| * Disable time stretcher for time beingDavid Marcec2020-07-252-6/+4
| |
| * audio_core: Apollo Part 1, AudioRenderer refactorDavid Marcec2020-07-2525-641/+4127
| |
* | General: Tidy up clang-format warnings part 2Lioncash2020-08-131-1/+1
| |
* | core_timing: Make use of uintptr_t to represent user_dataLioncash2020-07-281-3/+4
|/ | | | Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
* core_timing: Make TimedCallback take std::chrono::nanosecondsLioncash2020-07-162-8/+9
| | | | Enforces our desired time units directly with a concrete type.
* core_timing: Make use of std::chrono with ScheduleEventLioncash2020-07-162-12/+8
|
* configuration: implement per-game configurations (#4098)lat9nq2020-07-102-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Switch game settings to use a pointer In order to add full per-game settings, we need to be able to tell yuzu to switch to using either the global or game configuration. Using a pointer makes it easier to switch. * configuration: add new UI without changing existing funcitonality The new UI also adds General, System, Graphics, Advanced Graphics, and Audio tabs, but as yet they do nothing. This commit keeps yuzu to the same functionality as originally branched. * configuration: Rename files These weren't included in the last commit. Now they are. * configuration: setup global configuration checkbox Global config checkbox now enables/disables the appropriate tabs in the game properties dialog. The use global configuration setting is now saved to the config, defaulting to true. This also addresses some changes requested in the PR. * configuration: swap to per-game config memory for properties dialog Does not set memory going in-game. Swaps to game values when opening the properties dialog, then swaps back when closing it. Uses a `memcpy` to swap. Also implements saving config files, limited to certain groups of configurations so as to not risk setting unsafe configurations. * configuration: change config interfaces to use config-specific pointers When a game is booted, we need to be able to open the configuration dialogs without changing the settings pointer in the game's emualtion. A new pointer specific to just the configuration dialogs can be used to separate changes to just those config dialogs without affecting the emulation. * configuration: boot a game using per-game settings Swaps values where needed to boot a game. * configuration: user correct config during emulation Creates a new pointer specifically for modifying the configuration while emulation is in progress. Both the regular configuration dialog and the game properties dialog now use the pointer Settings::config_values to focus edits to the correct struct. * settings: split Settings::values into two different structs By splitting the settings into two mutually exclusive structs, it becomes easier, as a developer, to determine how to use the Settings structs after per-game configurations is merged. Other benefits include only duplicating the required settings in memory. * settings: move use_docked_mode to Controls group `use_docked_mode` is set in the input settings and cannot be accessed from the system settings. Grouping it with system settings causes it to be saved with per-game settings, which may make transferring configs more difficult later on, especially since docked mode cannot be set from within the game properties dialog. * configuration: Fix the other yuzu executables and a regression In main.cpp, we have to get the title ID before the ROM is loaded, else the renderer will reflect only the global settings and now the user's game specific settings. * settings: use a template to duplicate memory for each setting Replaces the type of each variable in the Settings::Values struct with a new class that allows basic data reading and writing. The new struct Settings::Setting duplicates the data in memory and can manage global overrides per each setting. * configuration: correct add-ons config and swap settings when apropriate Any add-ons interaction happens directly through the global values struct. Swapping bewteen structs now also includes copying the necessary global configs that cannot be changed nor saved in per-game settings. General and System config menus now update based on whether it is viewing the global or per-game settings. * settings: restore old values struct No longer needed with the Settings::Setting class template. * configuration: implement hierarchical game properties dialog This sets the apropriate global or local data in each setting. * clang format * clang format take 2 can the docker container save this? * address comments and style issues * config: read and write settings with global awareness Adds new functions to read and write settings while keeping the global state in focus. Files now generated per-game are much smaller since often they only need address the global state. * settings: restore global state when necessary Upon closing a game or the game properties dialog, we need to restore all global settings to the original global state so that we can properly open the configuration dialog or boot a different game. * configuration: guard setting values incorrectly This disables setting values while a game is running if the setting is overwritten by a per game setting. * config: don't write local settings in the global config Simple guards to prevent writing the wrong settings in the wrong files. * configuration: add comments, assume less, and clang format No longer assumes that a disabled UI element means the global state is turned off, instead opting to directly answer that question. Still however assumes a game is running if it is in that state. * configuration: fix a logic error Should not be negated * restore settings' global state regardless of accept/cancel Fixes loading a properties dialog and causing the global config dialog to show local settings. * fix more logic errors Fixed the frame limit would set the global setting from the game properties dialog. Also strengthened the Settings::Setting member variables and simplified the logic in config reading (ReadSettingGlobal). * fix another logic error In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered condition. * configure_audio: set toggle_stretched_audio to tristate * fixed custom rtc and rng seed overwriting the global value * clang format * rebased * clang format take 4 * address my own review Basically revert unintended changes * settings: literal instead of casting "No need to cast, use 1U instead" Thanks, Morph! Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> * Revert "settings: literal instead of casting " This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f. * main: fix status buttons reporting wrong settings after stop emulation * settings: Log UseDockedMode in the Controls group This should have happened when use_docked_mode was moved over to the controls group internally. This just reflects this in the log. * main: load settings if the file has a title id In other words, don't exit if the loader has trouble getting a title id. * use a zero * settings: initalize resolution factor with constructor instead of casting * Revert "settings: initalize resolution factor with constructor instead of casting" This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8. * configure_graphics: guard device selector when Vulkan is global Prevents the user from editing the device selector if Vulkan is the global renderer backend. Also resets the vulkan_device variable when the users switches back-and-forth between global and Vulkan. * address reviewer concerns Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static. Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com> * main: load per-game settings after LoadROM This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug. * Revert "main: load per-game settings after LoadROM" This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804. * main: only restore global settings when necessary Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug. * configuration_shared: address reviewer concerns except operator overrides Dropping operator override usage in next commit. Co-Authored-By: LC <lioncash@users.noreply.github.com> * settings: Drop operator overrides from Setting template Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog. * complete rebase * configuration_shared: translate "Use global configuration" Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared. * configure_per_game: address reviewer concern As far as I understand, it prevents the program from unnecessarily copying strings. Co-Authored-By: LC <lioncash@users.noreply.github.com> Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> Co-authored-by: VolcaEM <volcaem@users.noreply.github.com> Co-authored-by: LC <lioncash@users.noreply.github.com>
* Don't handle cycles late if stretcher is activeDavid Marcec2020-07-011-1/+3
| | | | Timestretcher seems to be broken
* audio: Improving audio timing for multicore/single coreDavid Marcec2020-07-012-20/+7
| | | | Fixes the issue with needing the timestretcher for multicore.
* Audio: Correct buffer release for host timing.Fernando Sahmkow2020-06-272-1/+17
|
* AudioCore: Use nanoseconds instead of cycles for buffer time.Fernando Sahmkow2020-06-272-6/+6
|
* Add a "Mute Audio" hotkeyKewlan2020-06-261-1/+1
|
* audren: Implement RendererInfoDavid Marcec2020-06-132-6/+26
| | | | Fixes ZLA softlock
* fix logic error & scale sample volume based on voice volumeDavid Marcec2020-05-111-7/+9
|
* pass by const ref insteadDavid Marcec2020-05-111-8/+7
|
* audio_renderer: Better voice mixing and 6 channel downmixingDavid Marcec2020-05-113-11/+96
| | | | Supersedes #3738 and #3321
* audio_renderer: Preliminary BehaviorInfo (#3736)David2020-04-216-11/+242
| | | | | | | | | | | | | * audio_renderer: Preliminary BehaviorInfo * clang format * Fixed IsRevisionSupported * fixed IsValidRevision * Fixed logic error & spelling errors & crash * Addressed issues
* core: memory: Move to Core::Memory namespace.bunnei2020-04-172-10/+11
| | | | - helpful to disambiguate Kernel::Memory namespace.
* audio_core: Accept Audren REV8FearlessTobi2020-03-231-1/+1
| | | | | | According to Ryujinx, REV8 only added changes on Performance buffer and Wavebuffer DSP command generation. As we don't support any of those, we can just increment the revision number for now.
* cubeb_sink: Don't discard other channels when performing downmixingFearlessTobi2020-03-081-3/+17
| | | | | | | | Previously, when performing downmixing, we would discard all channels except the left and right one. This implementation respects them when mixing down to Stereo. It is taken from this document: http://www.atsc.org/wp-content/uploads/2015/03/A52-201212-17.pdf. Fixes Luigis Mansion 3 cutscene and Bayonetta audio.
* audio_core: interpolate: Improvements to fix audio crackling.bunnei2020-02-232-23/+38
| | | | | - Fixes audio crackling in Crash Team Racing Nitro-Fueled, Super Mario Odyssey, and others. - Addresses followup issues from #3310.
* audio_core: interpolate: Fix include for climits (Linux build break).bunnei2020-02-221-1/+1
|
* audio_core: Switch to a faster interpolation techniqueFearlessTobi2020-01-242-48/+159
|
* core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory classLioncash2019-11-271-8/+9
| | | | | | | | | | | | | | With all of the trivial parts of the memory interface moved over, we can get right into moving over the bits that are used. Note that this does require the use of GetInstance from the global system instance to be used within hle_ipc.cpp and the gdbstub. This is fine for the time being, as they both already rely on the global system instance in other functions. These will be removed in a change directed at both of these respectively. For now, it's sufficient, as it still accomplishes the goal of de-globalizing the memory code.
* core: Prepare various classes for memory read/write migrationLioncash2019-11-272-13/+21
| | | | | | | | | | Amends a few interfaces to be able to handle the migration over to the new Memory class by passing the class by reference as a function parameter where necessary. Notably, within the filesystem services, this eliminates two ReadBlock() calls by using the helper functions of HLERequestContext to do that for us.
* core_timing: Use better reference tracking for EventType. (#3159)bunnei2019-11-272-13/+14
| | | | | | | * core_timing: Use better reference tracking for EventType. - Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects. - Removes need for unique names - we won't be using this for save states anyways.
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154)bunnei2019-11-252-4/+3
| | | | | | * kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.
* Used revision 5 instead of 7, marked constexpr as staticDavid Marcec2019-09-211-2/+2
|
* Added frame_count for REV7 audio rendererDavid Marcec2019-09-202-11/+24
| | | | Added framecount
* Clang formatDavid Marcec2019-07-122-2/+4
|
* Addressed issuesDavid Marcec2019-07-122-2/+2
|
* "AudioRenderer" thread should have a unique nameDavid Marcec2019-07-122-3/+4
| | | | Creating multiple "AudioRenderer" threads cause the previous thread to be overwritten. The thread will name be renamed to AudioRenderer-InstanceX, where X is the current instance number.
* addressed issueDavid Marcec2019-07-081-1/+1
|
* audren: Only manage wave buffers with a sizeDavid Marcec2019-07-011-3/+5
| | | | | | We shouldn't be incrementing if wave buffers are empty. They are considered invalid/unused wave buffers. This fixes the issue of certain sounds looping when they shouldn't
* Merge pull request #2583 from FernandoS27/core-timing-safebunnei2019-06-301-1/+1
|\ | | | | Core_Timing: Make core_timing threadsafe by default.
| * Core_Timing: Make core_timing threadsafe by default.Fernando Sahmkow2019-06-161-1/+1
| | | | | | | | | | | | The old implementation had faulty Threadsafe methods where events could be missing. This implementation unifies unsafe/safe methods and makes core timing thread safe overall.
* | CleanupDavid Marcec2019-06-161-1/+1
| |
* | Impl'd IsUserAccountSwitchLocked, SetAudioOutVolume, GetAudioOutVolume & Partial impl of GetAccumulatedSuspendedTickChangedEventDavid Marcec2019-06-162-3/+14
|/ | | | IPC-100 was changed to InitializeApplicationInfoOld instead of InitializeApplicationInfo. IPC-150 makes an indentical call to IPC-100 however does extra processing. They should not have the same name as it's quite confusing to debug.
* core/core_timing_util: Use std::chrono types for specifying time unitsLioncash2019-06-051-1/+3
| | | | | Makes the interface more type-safe and consistent in terms of return values.
* core/core_timing: Make callback parameters consistentLioncash2019-03-241-1/+1
| | | | | | | | | | | In some cases, our callbacks were using s64 as a parameter, and in other cases, they were using an int, which is inconsistent. To make all callbacks consistent, we can just use an s64 as the type for late cycles, given it gets rid of the need to cast internally. While we're at it, also resolve some signed/unsigned conversions that were occurring related to the callback registration.
* audio_core/cubeb_sink: Convert _MSC_VER ifdefs to _WIN32Lioncash2019-03-102-4/+4
| | | | This behavior also needs to be visible for MinGW builds as well.
* audio_core/cubeb_sink: Ensure COM is initialized on Windows prior to calling cubeb_initLioncash2019-02-272-0/+19
| | | | | cubeb now requires that COM explicitly be initialized on the thread prior to calling cubeb_init.
* audio_core/audio_renderer: Name previously unknown parameters of AudioRendererParameterLioncash2019-02-271-6/+8
| | | | | | | | | Provides names for previously unknown entries (aside from the two u8 that appear to be padding bytes, and a single word that also appears to be reserved or padding). This will be useful in subsequent changes when unstubbing behavior related to the audio renderer services.
* audio_core/cubeb_sink: Initialize CubebSinkStream's last_frame data memberLioncash2019-02-251-1/+1
| | | | | Ensures that all member variables are initialized in a deterministic manner across the board.
* audio_core/cubeb_sink: Add override specifier to destructorLioncash2019-02-251-1/+1
| | | | | CubebSinkStream inherits from a base class with a virtual destructor, so override can be appended to CubebSinkStream's destructor.
* audio_core/cubeb_sink: Resolve variable shadowing warnings in SamplesInQueueLioncash2019-02-251-2/+2
| | | | | | The name of the parameter was shadowing the member variable of the same name. Instead, alter the name of the parameter to prevent said shadowing.
* audio_core/codec: Resolve truncation warnings within DecodeADPCMLioncash2019-02-251-2/+2
| | | | | The assignments here were performing an implicit truncation from int to s16. Make it explicit that this is desired behavior.
* audio_core/buffer: Make const and non-const getter for samples consistentLioncash2019-02-162-2/+2
| | | | This way proper const/non-const selection can occur.
* core_timing: Convert core timing into a classLioncash2019-02-166-17/+28
| | | | | | | | | | | Gets rid of the largest set of mutable global state within the core. This also paves a way for eliminating usages of GetInstance() on the System class as a follow-up. Note that no behavioral changes have been made, and this simply extracts the functionality into a class. This also has the benefit of making dependencies on the core timing functionality explicit within the relevant interfaces.
* core_timing: Rename CoreTiming namespace to Core::TimingLioncash2019-02-122-14/+15
| | | | | | Places all of the timing-related functionality under the existing Core namespace to keep things consistent, rather than having the timing utilities sitting in its own completely separate namespace.
* dsp_interface: fix sound being played while volume is 0fearlessTobi2019-01-261-1/+1
| | | | | According to documentation, if the argument of std::exp is zero, one is returned. However we want the return value to be also zero in this case so no audio is played.
* audio_core: remove unnecessary spaces on commentsOtávio Pace2019-01-141-2/+2
|
* audio_core: Convert LOG_CRITICAL + UNREACHABLE over to UNIMPLEMENTED/UNIMPLEMENTED_MSGLioncash2018-12-283-10/+6
| | | | | | These two macros being used in tandem were used prior to the introduction of UNIMPLEMENTED and UNIMPLEMENTED_MSG. This provides equivalent behavior, just with less typing/reading involved.
* Merge pull request #1902 from lioncash/audiobunnei2018-12-156-32/+55
|\ | | | | audio_core: Make g_sink_details internally linked
| * audio_core: Make g_sink_details internally linkedLioncash2018-12-136-32/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can hide the direct array from external view and instead provide functions to retrieve the necessary info. This has the benefit of completely hiding the makeup of the SinkDetails structure from the rest of the code. Given that this makes the array hidden, we can also make the array constexpr by altering the members slightly. This gets rid of several static constructor calls related to std::vector and std::function. Now we don't have heap allocations here that need to occur before the program can even enter main(). It also has the benefit of saving a little bit of heap space, but this doesn't matter too much, since the savings in that regard are pretty tiny.
* | Avoid (expensive) audio interpolation when sample rates already matchheapo2018-12-062-4/+8
|/
* core: Port all current usages of Event to Readable/WritableEventZach Hilman2018-11-292-5/+6
|
* audio_core/audio_renderer: Fix typo in AuxInfo member nameLioncash2018-11-131-1/+1
|
* microprofile: Drop ReleaseActiveBuffer scope.Markus Wick2018-11-061-4/+0
| | | | | This was created with the unfinished resampling PR in mind. As the resampling is now on the audio thread, we don't need to care about this here any more.
* time_stretch: Switch to values of CitrafearlessTobi2018-10-291-3/+3
|
* cubeb_sink: ignore null-name device when selectingWeiyi Wang2018-10-271-1/+2
| | | | We already ignore them on listing devices. We should do the same when selecting devices. This fix a crash when opening a specific device while there is a null device in the list
* time_stretch: Remove unused m_channel_count member variableLioncash2018-10-242-3/+1
| | | | This is only stored to, but never read from.
* EffectOutStatus padding is now in hexDavid Marcec2018-10-091-1/+1
|
* Fixups for softlockDavid Marcec2018-10-072-6/+7
|
* Fixed missing returnDavid Marcec2018-10-071-1/+1
| | | | | Softlock explanation: after effects are initialized in smo, nothing actually changes the state. It expects the state to always be initialized. With the previous testing, updating the states much like how we handle the memory pools continue to have the softlock(which is why I said it probably wasn't effects) after further examination it seems like effects need to be initialized but the state remains unchanged until further notice. For now, assertions are added for the aux buffers to see if they update, unable to check as I haven't gotten smo to actually update them yet.
* Fixed smo softlockDavid Marcec2018-10-072-13/+120
|
* stream: Preserve enum class type in GetState()Lioncash2018-09-244-11/+11
| | | | | | Preserves the meaning/type-safetiness of the stream state instead of making it an opaque u32. This makes it usable for other things outside of the service HLE context.
* Added audren:u#GetAudioRendererStateDavid Marcec2018-09-234-0/+13
|
* Logging: Change the TimeStretch::Process log from debug to trace level.Subv2018-09-211-1/+1
| | | | This function is called too many times and makes the debug logging basically unusable due to the spam.
* time_stretch: Remove unused <array> includeLioncash2018-09-171-1/+0
| | | | This isn't used within this header and isn't necessary.
* stream: Replace includes with forward declarations where applicableLioncash2018-09-172-3/+7
| | | | | Avoids propagating includes in headers where it's not necessary to do so.
* audio_renderer: Replace includes with forward declarations where applicableLioncash2018-09-172-39/+52
| | | | | | | | | Avoids including unnecessary headers within the audio_renderer.h header, lessening the likelihood of needing to rebuild source files including this header if they ever change. Given std::vector allows forward declaring contained types, we can move VoiceState to the cpp file and hide the implementation entirely.
* Merge pull request #1314 from lioncash/castbunnei2018-09-171-2/+2
|\ | | | | audio_core/time_stretch: Silence truncation warnings in Process()
| * audio_core/time_stretch: Silence truncation warnings in Process()Lioncash2018-09-141-2/+2
| | | | | | | | The SoundTouch API only accepts uint amount of samples.
* | Merge pull request #1321 from lioncash/audio-shadowbunnei2018-09-171-4/+4
|\ \ | | | | | | cubeb_sink: Get rid of variable shadowing within CubebSink's constructor
| * | cubeb_sink: Get rid of variable shadowing within CubebSink's constructorLioncash2018-09-141-4/+4
| |/ | | | | | | | | The parameter of the lambda was shadowing the variable that was being assigned to.
* | Merge pull request #1320 from lioncash/namebunnei2018-09-171-1/+1
|\ \ | | | | | | cubeb_sink: Correct context name in ListCubebSinkDevices()
| * | cubeb_sink: Correct context name in ListCubebSinkDevices()Lioncash2018-09-141-1/+1
| |/ | | | | | | This ain't Citra.
* / Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi2018-09-1516-64/+67
|/
* Merge pull request #1298 from lioncash/viewbunnei2018-09-132-2/+4
|\ | | | | audio_core/sink_details: Change std::string parameter into std::string_view
| * audio_core/sink_details: Change std::string parameter into std::string_viewLioncash2018-09-122-2/+4
| | | | | | | | | | The given string is only ever used for lookup and comparison, so we can just utilize a non-owning view to string data here
* | Merge pull request #1163 from FearlessTobi/add-audio-stretchingbunnei2018-09-137-49/+185
|\ \ | |/ |/| audio_core: Add audio stretching support
| * audio_core: Flush stream when not playing anythingMerryMage2018-09-126-0/+23
| |
| * cubeb_sink: Downsample arbitrary number of channelsMerryMage2018-09-091-10/+9
| |
| * cubeb_sink: Perform audio stretchingMerryMage2018-09-083-24/+26
| |
| * audio_core: Add audio stretcherMerryMage2018-09-083-0/+101
| |
| * cubeb_sink: Hold last available value instead of writing zerosMerryMage2018-09-081-5/+15
| | | | | | | | This reduces clicking in output audio should we underrun.
| * cubeb_sink: Use RingBufferMerryMage2018-09-081-40/+26
| |
| * Add audio stretching supportfearlessTobi2018-09-085-0/+15
| |
* | audio_renderer: Rename AudioOut instance to audio_outMerryMage2018-09-082-7/+7
|/
* Update microprofile scopes.Markus Wick2018-09-041-0/+4
| | | | | | Blame the subsystems which deserve the blame :) The updated list is not complete, just the ones I've spotted on random sampling the stack trace.
* audio_core/filter: Add explicit cast to assignment in Process()Lioncash2018-08-211-1/+1
| | | | | Previously this would cause warnings about implicit conversions to s16 from a double
* Merge pull request #1033 from MerryMage/interpbunnei2018-08-137-3/+267
|\ | | | | audio_core: Interpolate
| * audio_renderer: samples_remaining counts frames, not samplesMerryMage2018-08-131-1/+1
| |
| * audio_core: InterpolateMerryMage2018-08-135-0/+121
| |
| * audio_core: Implement low-pass filterMerryMage2018-08-133-2/+145
| |
* | cubeb_sink: Protect queue with a mutexMerryMage2018-08-121-0/+6
|/
* Pushed the requested sample rate instead of our fixed sample rateDavid Marcec2018-08-121-1/+1
|
* Added GetAudioRendererSampleRate, GetAudioRendererSampleCount & GetAudioRendererMixBufferCountDavid Marcec2018-08-122-1/+16
| | | | GetAudioRendererSampleRate is set as a "STUB" as a game could check if the sample rate it sent and the sample rate it wants don't match. Just a thought of something which could happen so keeping it as stub for the mean time
* Make building cubeb optionalKAMiKAZOW2018-08-071-2/+2
|
* audio_core: Implement audren_u audio playback.bunnei2018-08-053-0/+442
|
* audio_core: Use s16 where possible for audio samples.bunnei2018-08-058-33/+24
|
* audio_core: Port codec code from Citra for ADPCM decoding.bunnei2018-08-053-0/+123
|
* cubeb_sink: Support variable sample_rate and num_channels.bunnei2018-08-041-15/+25
|
* audio_core: Sinks need unique names as well.bunnei2018-08-045-9/+14
|
* audio_core: Streams need unique names for CoreTiming.bunnei2018-08-044-9/+13
|
* Merge pull request #895 from lioncash/sinkbunnei2018-08-031-5/+8
|\ | | | | sink_details: std::move std::function instances
| * sink_details: Deduplicate long std::function repetitionLioncash2018-08-021-4/+6
| | | | | | | | | | We can just use type aliases to avoid needing to write the same long type twice
| * sink_details: std::move std::function instancesLioncash2018-08-021-1/+2
| | | | | | | | | | Given std::function is allowed to potentially allocate, these should be std::move'd to prevent potential reallocation (should that ever happen).
* | audio_out: Use Buffer::Tag alias in GetTagsAndReleaseBuffers()'s prototypeLioncash2018-08-022-2/+2
|/ | | | | This makes the Buffer::Tag usage consistent with the Stream class's prototype of GetTagsAndReleaseBuffers().
* audio_core: Add configuration settings.bunnei2018-08-012-9/+31
|
* audio_core: Implement Sink and SinkStream interfaces with cubeb.bunnei2018-07-318-6/+261
|
* audio_core: Add interfaces for Sink and SinkStream.bunnei2018-07-316-0/+163
|
* audio_core: Misc. improvements to stream/buffer/audio_out.bunnei2018-07-315-20/+32
|
* audio_core: Add initial code for keeping track of audout state.bunnei2018-07-286-0/+334
|
* Massive removal of unused modulesJames Rowe2018-01-1326-3017/+0
|
* CoreTiming: Reworked CoreTiming (cherry-picked from Citra #3119)B3n302018-01-091-1/+1
| | | | * CoreTiming: New CoreTiming; Add Test for CoreTiming
* audio: Log dropping frames as trace to reduce spam.bunnei2018-01-071-1/+1
|
* Fixed type conversion ambiguityHuw Pascoe2017-09-301-1/+1
|
* Audio: Use std::deque instead of std::vector for the audio buffer type (StereoBuffer16).Subv2017-09-265-7/+9
| | | | | | | | | The current code inserts and deletes elements from the beginning of the audio buffer, which is very inefficient in an std::vector. Profiling was done using VisualStudio2017's Performance Analyzer in Super Mario 3D Land. Before this change: AudioInterp::Linear had 14.14% of the runtime (inclusive) and most of that time was spent in std::vector's insert implementation. After this change: AudioInterp::Linear has 0.36% of the runtime (inclusive)
* interpolate: Interpolate on a frame-by-frame basisMerryMage2017-08-283-88/+74
|
* CMake: Add SoundTouch include path to target propertyYuri Kunde Schlesner2017-05-281-2/+0
|
* CMake: Define an interface target for SDL2 definitionsYuri Kunde Schlesner2017-05-281-2/+1
|
* CMake: Correct inter-module dependencies and library visibilityYuri Kunde Schlesner2017-05-281-3/+4
| | | | | | | | | | Modules didn't correctly define their dependencies before, which relied on the frontends implicitly including every module for linking to succeed. Also changed every target_link_libraries call to specify visibility of dependencies to avoid leaking definitions to dependents when not necessary.
* DSP: Create backing memory for entire DSP RAMYuri Kunde Schlesner2017-05-104-31/+36
| | | | Also move address space mapping out of video_core.
* Doxygen: Amend minor issues (#2593)Mat M2017-02-274-3/+5
| | | | | | | | | Corrects a few issues with regards to Doxygen documentation, for example: - Incorrect parameter referencing. - Missing @param tags. - Typos in @param tags. and a few minor other issues.
* Support looping HLE audio (#2422)Jake Merdich2017-01-302-11/+35
| | | | | * Support looping HLE audio * DSP: Fix dirty bit clears, handle nonmonotonically incrementing IDs * DSP: Add start offset support
* fixed the override warningnoah the goodra2017-01-271-1/+1
| | | | | | | | | | | | ``` In file included from citra/src/audio_core/sink_details.cpp:11: citra/src/./audio_core/sdl2_sink.h:25:10: warning: 'SetDevice' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void SetDevice(int device_id); ^ citra/src/./audio_core/sink.h:39:18: note: overridden virtual function is here virtual void SetDevice(int device_id) = 0; ^ ```
* SDL: Select audio device (#2403)Kloen Lansfiel2017-01-267-18/+69
| | | | | | | | | | | | | | | | | | | | | | | | * Initial Commit Added Device logic to Sinks Started on UI for selecting devices Removed redundant import * Audio Core: Complete Device Switching Complete the device switching implementation by allowing the output device to be loaded, changed and saved through the configurations menu. Worked with the Sink abstraction and tuned the "Device Selection" configuration so that the Device List is automatically populated when the Sink is changed. This hopefully addresses the concerns and recommendations mentioned in the comments of the PR. * Clean original implementation. * Refactor GetSinkDetails
* time_stretch: Add missing #pragma once directiveLioncash2016-12-131-0/+2
|
* Add all services to the Service namespaceLioncash2016-12-112-3/+3
| | | | | Previously there was a split where some of the services were in the Service namespace and others were not.
* audio_core: SelectSink should default to auto if sink_id is invalidMerryMage2016-12-101-12/+7
|
* Improve verbosity of audio errors with SDL_GetError()freiro2016-11-221-2/+2
|
* Fix typosRicardo de Almeida Gonzaga2016-10-202-4/+4
|
* Use negative priorities to avoid special-casing the self-includeYuri Kunde Schlesner2016-09-219-9/+9
|
* Remove empty newlines in #include blocks.Emmanuel Gil Peyrot2016-09-2123-48/+10
| | | | | | | This makes clang-format useful on those. Also add a bunch of forgotten transitive includes, which otherwise prevented compilation.
* Manually tweak source formatting and then re-run clang-formatYuri Kunde Schlesner2016-09-1913-76/+110
|
* Sources: Run clang-format on everything.Emmanuel Gil Peyrot2016-09-1824-249/+323
|
* audio_core: Tweak audio latencyMerryMage2016-09-072-2/+2
|
* codec: Fix ADPCM distortion caused by incorrect nibble orderfincs2016-09-031-2/+2
| | | | | | Closes #2049. Signed-off-by: MerryMage <MerryMage@users.noreply.github.com>
* audio_core: Add EnableStretching to interface so that one can toggle stretching on and offMerryMage2016-08-314-9/+52
|
* sink: Change EnqueueSamples to take a pointer to a buffer instead of a std::vectorMerryMage2016-08-315-9/+9
|
* DSP/HLE: Audio outputMerryMage2016-05-191-0/+7
|
* DSP/HLE: Implement mixer processingMerryMage2016-05-195-11/+311
|
* AudioCore: Implement time stretcher (#1737)Maribel2016-05-154-0/+219
| | | | | | | | | | | | | | * AudioCore: Implement time stretcher * fixup! AudioCore: Implement time stretcher * fixup! fixup! AudioCore: Implement time stretcher * fixup! fixup! fixup! AudioCore: Implement time stretcher * fixup! fixup! fixup! fixup! AudioCore: Implement time stretcher * fixup! fixup! fixup! fixup! fixup! AudioCore: Implement time stretcher
* source: Fix missing logging argumentsLioncash2016-05-091-2/+2
| | | | Silences two warnings on OSX.
* fixup simple type conversions where possibleAlexander Laties2016-05-072-6/+15
|
* Merge pull request #1736 from MerryMage/sdl2-sinkbunnei2016-05-075-1/+175
|\ | | | | AudioCore: SDL2 Sink
| * AudioCore: SDL2 SinkMerryMage2016-05-075-1/+175
| |
* | HLE: Fix recent DSP change for Visual Studio.bunnei2016-05-071-4/+2
| |
* | DSP/HLE: Implement Source processingMerryMage2016-05-037-5/+496
|/
* Audio: Add sink selection to configuration filesMerryMage2016-04-305-4/+55
|
* AudioCore: List of sink typesMerryMage2016-04-303-0/+46
|
* AudioCore: Implement NullSinkMerryMage2016-04-302-0/+30
|
* Merge pull request #1726 from MerryMage/read-write-regionbunnei2016-04-293-26/+31
|\ | | | | AudioCore: CurrentRegion() -> ReadRegion(), WriteRegion()
| * AudioCore: CurrentRegion() -> ReadRegion(), WriteRegion()MerryMage2016-04-293-26/+31
| |
* | Merge pull request #1723 from MerryMage/audio-interpbunnei2016-04-293-0/+128
|\ \ | | | | | | AudioCore: Implement interpolation
| * | AudioCore: Implement interpolationMerryMage2016-04-293-0/+128
| | |
* | | Merge pull request #1727 from MerryMage/minor-commitbunnei2016-04-283-12/+11
|\ \ \ | | | | | | | | AudioCore: Move samples_per_frame and num_sources into hle/common.h
| * | | AudioCore: Move samples_per_frame and num_sources into hle/common.hMerryMage2016-04-283-12/+11
| | |/ | |/|
* | | Merge pull request #1722 from MerryMage/soundtouchbunnei2016-04-281-1/+4
|\ \ \ | |/ / |/| | Externals: Add soundtouch
| * | Externals: Add soundtouchMerryMage2016-04-281-1/+4
| |/
* | AudioCore: Hack to prevent regressions: Trigger Binary pipe interrupt every audio frameMerryMage2016-04-271-0/+2
| |
* | DSP_DSP: Updated interrupt implementationMerryMage2016-04-272-4/+7
| |
* | DSP/Pipe: There are 8 pipesMerryMage2016-04-252-13/+19
|/
* DSP: Implement audio filters (simple, biquad)MerryMage2016-03-285-7/+275
|
* DSP: Implement audio codecs (PCM8, PCM16, ADPCM)MerryMage2016-03-243-0/+174
|
* DSP: Implement Pipe 2MerryMage2016-03-063-34/+194
| | | | | | Pipe 2 is a DSP pipe that is used to initialize both the DSP hardware (the application signals to the DSP to initialize) and the application (the DSP provides the memory location of structures in the shared memory region).
* AudioCore: Skeleton ImplementationMerryMage2016-02-218-0/+766
This commit: * Adds a new subproject, audio_core. * Defines structures that exist in DSP shared memory. * Hooks up various other parts of the emulator into audio core. This sets the foundation for a later HLE DSP implementation.
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-23 03:13:57 +0100