From a7c7946867c0f36c5091c1cf89954ccce637d51a Mon Sep 17 00:00:00 2001 From: archshift Date: Thu, 9 Oct 2014 23:27:47 -0700 Subject: Common: Return from CreateFullPath early if the directory creation fails --- src/common/file_util.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/common/file_util.cpp b/src/common/file_util.cpp index 78a642599..9e40e87d4 100644 --- a/src/common/file_util.cpp +++ b/src/common/file_util.cpp @@ -190,8 +190,10 @@ bool CreateFullPath(const std::string &fullPath) // Include the '/' so the first call is CreateDir("/") rather than CreateDir("") std::string const subPath(fullPath.substr(0, position + 1)); - if (!FileUtil::IsDirectory(subPath)) - FileUtil::CreateDir(subPath); + if (!FileUtil::IsDirectory(subPath) && !FileUtil::CreateDir(subPath)) { + ERROR_LOG(COMMON, "CreateFullPath: directory creation failed"); + return false; + } // A safety check panicCounter--; -- cgit v1.2.3