summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTao Bao <tbao@google.com>2017-05-12 03:18:50 +0200
committerGerrit Code Review <noreply-gerritcodereview@google.com>2017-05-12 03:18:52 +0200
commit7cb1b796731fa35a6556263876648746710f003b (patch)
tree1d6b2f9185d2b9a9a2961ff92482a323081e4578
parentMerge "recovery: Skip "/" in setup_install_mounts()." (diff)
parentDon't write to /sys/class/android_usb/android0/enable with configfs. (diff)
downloadandroid_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.tar
android_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.tar.gz
android_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.tar.bz2
android_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.tar.lz
android_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.tar.xz
android_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.tar.zst
android_bootable_recovery-7cb1b796731fa35a6556263876648746710f003b.zip
-rw-r--r--adb_install.cpp23
1 files changed, 16 insertions, 7 deletions
diff --git a/adb_install.cpp b/adb_install.cpp
index e7d7758f9..ac0130651 100644
--- a/adb_install.cpp
+++ b/adb_install.cpp
@@ -26,7 +26,10 @@
#include <sys/wait.h>
#include <unistd.h>
+#include <android-base/file.h>
+#include <android-base/logging.h>
#include <android-base/properties.h>
+#include <android-base/unique_fd.h>
#include "common.h"
#include "fuse_sideload.h"
@@ -34,16 +37,22 @@
#include "ui.h"
static void set_usb_driver(bool enabled) {
- int fd = open("/sys/class/android_usb/android0/enable", O_WRONLY);
- if (fd < 0) {
- ui->Print("failed to open driver control: %s\n", strerror(errno));
+ // USB configfs doesn't use /s/c/a/a/enable.
+ if (android::base::GetBoolProperty("sys.usb.configfs", false)) {
return;
}
- if (TEMP_FAILURE_RETRY(write(fd, enabled ? "1" : "0", 1)) == -1) {
- ui->Print("failed to set driver control: %s\n", strerror(errno));
+
+ static constexpr const char* USB_DRIVER_CONTROL = "/sys/class/android_usb/android0/enable";
+ android::base::unique_fd fd(open(USB_DRIVER_CONTROL, O_WRONLY));
+ if (fd == -1) {
+ PLOG(ERROR) << "Failed to open driver control";
+ return;
}
- if (close(fd) < 0) {
- ui->Print("failed to close driver control: %s\n", strerror(errno));
+ // Not using android::base::WriteStringToFile since that will open with O_CREAT and give EPERM
+ // when USB_DRIVER_CONTROL doesn't exist. When it gives EPERM, we don't know whether that's due
+ // to non-existent USB_DRIVER_CONTROL or indeed a permission issue.
+ if (!android::base::WriteStringToFd(enabled ? "1" : "0", fd)) {
+ PLOG(ERROR) << "Failed to set driver control";
}
}