summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2017-01-31 01:48:52 +0100
committerTianjie Xu <xunchang@google.com>2017-02-03 21:35:40 +0100
commitab1abae59ccca2b5f1685ab7d279a0273ff9278b (patch)
tree709a00dd6f56179036bc6203ed52feb093969346
parentMerge "Remove '_static' suffix from libext2* references." (diff)
downloadandroid_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.tar
android_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.tar.gz
android_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.tar.bz2
android_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.tar.lz
android_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.tar.xz
android_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.tar.zst
android_bootable_recovery-ab1abae59ccca2b5f1685ab7d279a0273ff9278b.zip
-rw-r--r--install.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/install.cpp b/install.cpp
index 959a74222..91e4875cb 100644
--- a/install.cpp
+++ b/install.cpp
@@ -382,7 +382,11 @@ static int try_update_binary(const char* path, ZipArchiveHandle zip, bool* wipe_
umask(022);
close(pipefd[0]);
execv(chr_args[0], const_cast<char**>(chr_args));
- PLOG(ERROR) << "Can't run " << chr_args[0];
+ // Bug: 34769056
+ // We shouldn't use LOG/PLOG in the forked process, since they may cause
+ // the child process to hang. This deadlock results from an improperly
+ // copied mutex in the ui functions.
+ fprintf(stdout, "E:Can't run %s (%s)\n", chr_args[0], strerror(errno));
_exit(-1);
}
close(pipefd[1]);