summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2017-01-18 23:37:48 +0100
committerandroid-build-merger <android-build-merger@google.com>2017-01-18 23:37:48 +0100
commite4ec60e045df268edd56fabbbca3638ce94d13c2 (patch)
treef90c7c7c1e65b8ad4279dfe4883e46a80e0a7321
parentDO NOT MERGE ANYWHERE init: move healthd to late-init am: 195ff7f79e -s ours am: 7ceb371048 -s ours am: b8c1788e7b -s ours (diff)
parentAdd a checker for signature boundary in verifier am: 54ea136fde am: 0a34b17c8b am: fb80b4f72d am: d3d5e54a45 am: 6ea9888d51 am: a055eb93c3 am: 15ca2a4763 (diff)
downloadandroid_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.tar
android_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.tar.gz
android_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.tar.bz2
android_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.tar.lz
android_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.tar.xz
android_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.tar.zst
android_bootable_recovery-e4ec60e045df268edd56fabbbca3638ce94d13c2.zip
-rw-r--r--verifier.cpp6
1 files changed, 6 insertions, 0 deletions
diff --git a/verifier.cpp b/verifier.cpp
index 16cc7cf03..2d1b0e74f 100644
--- a/verifier.cpp
+++ b/verifier.cpp
@@ -146,6 +146,12 @@ int verify_file(unsigned char* addr, size_t length,
LOGI("comment is %zu bytes; signature %zu bytes from end\n",
comment_size, signature_start);
+ if (signature_start > comment_size) {
+ LOGE("signature start: %zu is larger than comment size: %zu\n", signature_start,
+ comment_size);
+ return VERIFY_FAILURE;
+ }
+
if (signature_start <= FOOTER_SIZE) {
LOGE("Signature start is in the footer");
return VERIFY_FAILURE;