summaryrefslogtreecommitdiffstats
path: root/update_verifier
diff options
context:
space:
mode:
authorDavid Zeuthen <zeuthen@google.com>2017-08-08 00:47:27 +0200
committerDavid Zeuthen <zeuthen@google.com>2017-08-09 20:23:20 +0200
commit3222dc0d76ca0f19795df2aad417dec2293b7242 (patch)
treee79127d4598a48191ffa776467aa13d7ca99dc68 /update_verifier
parentrecovery: handle security footer before passing size to mke2fs (diff)
downloadandroid_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.tar
android_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.tar.gz
android_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.tar.bz2
android_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.tar.lz
android_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.tar.xz
android_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.tar.zst
android_bootable_recovery-3222dc0d76ca0f19795df2aad417dec2293b7242.zip
Diffstat (limited to 'update_verifier')
-rw-r--r--update_verifier/update_verifier.cpp21
1 files changed, 17 insertions, 4 deletions
diff --git a/update_verifier/update_verifier.cpp b/update_verifier/update_verifier.cpp
index d3a5185b8..48242a5d0 100644
--- a/update_verifier/update_verifier.cpp
+++ b/update_verifier/update_verifier.cpp
@@ -239,23 +239,36 @@ int update_verifier(int argc, char** argv) {
// The current slot has not booted successfully.
#if defined(PRODUCT_SUPPORTS_VERITY) || defined(BOARD_AVB_ENABLE)
+ bool skip_verification = false;
std::string verity_mode = android::base::GetProperty("ro.boot.veritymode", "");
if (verity_mode.empty()) {
+ // With AVB it's possible to disable verification entirely and
+ // in this case ro.boot.veritymode is empty.
+#if defined(BOARD_AVB_ENABLE)
+ LOG(WARNING) << "verification has been disabled; marking without verification.";
+ skip_verification = true;
+#else
LOG(ERROR) << "Failed to get dm-verity mode.";
return reboot_device();
+#endif
} else if (android::base::EqualsIgnoreCase(verity_mode, "eio")) {
// We shouldn't see verity in EIO mode if the current slot hasn't booted successfully before.
// Continue the verification until we fail to read some blocks.
LOG(WARNING) << "Found dm-verity in EIO mode.";
+ } else if (android::base::EqualsIgnoreCase(verity_mode, "disabled")) {
+ LOG(WARNING) << "dm-verity in disabled mode; marking without verification.";
+ skip_verification = true;
} else if (verity_mode != "enforcing") {
LOG(ERROR) << "Unexpected dm-verity mode : " << verity_mode << ", expecting enforcing.";
return reboot_device();
}
- static constexpr auto CARE_MAP_FILE = "/data/ota_package/care_map.txt";
- if (!verify_image(CARE_MAP_FILE)) {
- LOG(ERROR) << "Failed to verify all blocks in care map file.";
- return reboot_device();
+ if (!skip_verification) {
+ static constexpr auto CARE_MAP_FILE = "/data/ota_package/care_map.txt";
+ if (!verify_image(CARE_MAP_FILE)) {
+ LOG(ERROR) << "Failed to verify all blocks in care map file.";
+ return reboot_device();
+ }
}
#else
LOG(WARNING) << "dm-verity not enabled; marking without verification.";