diff options
author | liamwhite <liamwhite@users.noreply.github.com> | 2024-01-26 15:57:40 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-01-26 15:57:40 +0100 |
commit | 4349cdba070b159181d7090a27beb794bb83e481 (patch) | |
tree | 1bd25e48ffeb2dcc0d033fdf3a900d91fa1e4360 | |
parent | Merge pull request #12809 from t895/error-message (diff) | |
parent | core: hid: Skip duplicated vibrations (diff) | |
download | yuzu-4349cdba070b159181d7090a27beb794bb83e481.tar yuzu-4349cdba070b159181d7090a27beb794bb83e481.tar.gz yuzu-4349cdba070b159181d7090a27beb794bb83e481.tar.bz2 yuzu-4349cdba070b159181d7090a27beb794bb83e481.tar.lz yuzu-4349cdba070b159181d7090a27beb794bb83e481.tar.xz yuzu-4349cdba070b159181d7090a27beb794bb83e481.tar.zst yuzu-4349cdba070b159181d7090a27beb794bb83e481.zip |
-rw-r--r-- | src/hid_core/frontend/emulated_controller.cpp | 18 | ||||
-rw-r--r-- | src/hid_core/frontend/emulated_controller.h | 3 | ||||
-rw-r--r-- | src/hid_core/hid_types.h | 9 |
3 files changed, 26 insertions, 4 deletions
diff --git a/src/hid_core/frontend/emulated_controller.cpp b/src/hid_core/frontend/emulated_controller.cpp index e12e5a77e..819460eb5 100644 --- a/src/hid_core/frontend/emulated_controller.cpp +++ b/src/hid_core/frontend/emulated_controller.cpp @@ -110,7 +110,11 @@ void EmulatedController::ReloadFromSettings() { original_npad_type = npad_type; } - SetPollingMode(EmulatedDeviceIndex::RightIndex, Common::Input::PollingMode::Active); + // Disable special features before disconnecting + if (controller.right_polling_mode != Common::Input::PollingMode::Active) { + SetPollingMode(EmulatedDeviceIndex::RightIndex, Common::Input::PollingMode::Active); + } + Disconnect(); if (player.connected) { Connect(); @@ -1241,7 +1245,12 @@ bool EmulatedController::SetVibration(DeviceIndex device_index, const VibrationV return false; } - last_vibration_value = vibration; + // Skip duplicated vibrations + if (last_vibration_value[index] == vibration) { + return Settings::values.vibration_enabled.GetValue(); + } + + last_vibration_value[index] = vibration; if (!Settings::values.vibration_enabled) { return false; @@ -1272,7 +1281,10 @@ bool EmulatedController::SetVibration(DeviceIndex device_index, const VibrationV } VibrationValue EmulatedController::GetActualVibrationValue(DeviceIndex device_index) const { - return last_vibration_value; + if (device_index >= DeviceIndex::MaxDeviceIndex) { + return Core::HID::DEFAULT_VIBRATION_VALUE; + } + return last_vibration_value[static_cast<std::size_t>(device_index)]; } bool EmulatedController::IsVibrationEnabled(std::size_t device_index) { diff --git a/src/hid_core/frontend/emulated_controller.h b/src/hid_core/frontend/emulated_controller.h index 168abe089..701b38300 100644 --- a/src/hid_core/frontend/emulated_controller.h +++ b/src/hid_core/frontend/emulated_controller.h @@ -581,7 +581,8 @@ private: f32 motion_sensitivity{Core::HID::MotionInput::IsAtRestStandard}; u32 turbo_button_state{0}; std::size_t nfc_handles{0}; - VibrationValue last_vibration_value{DEFAULT_VIBRATION_VALUE}; + std::array<VibrationValue, 2> last_vibration_value{DEFAULT_VIBRATION_VALUE, + DEFAULT_VIBRATION_VALUE}; // Temporary values to avoid doing changes while the controller is in configuring mode NpadStyleIndex tmp_npad_type{NpadStyleIndex::None}; diff --git a/src/hid_core/hid_types.h b/src/hid_core/hid_types.h index 2c3f02f34..a01292a70 100644 --- a/src/hid_core/hid_types.h +++ b/src/hid_core/hid_types.h @@ -639,6 +639,15 @@ struct VibrationValue { f32 low_frequency{}; f32 high_amplitude{}; f32 high_frequency{}; + bool operator==(const VibrationValue& b) { + if (low_amplitude != b.low_amplitude || high_amplitude != b.high_amplitude) { + return false; + } + if (low_frequency != b.low_amplitude || high_frequency != b.high_frequency) { + return false; + } + return true; + } }; static_assert(sizeof(VibrationValue) == 0x10, "VibrationValue has incorrect size."); |