diff options
author | Weiyi Wang <wwylele@gmail.com> | 2017-08-28 10:21:51 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-08-28 10:21:51 +0200 |
commit | 647f017c6d42121808aa4522049e3ea8f4d5ed31 (patch) | |
tree | 38f1ac4e26d827d64a8e09d168da24dea9c56286 | |
parent | Merge pull request #2897 from bunnei/telemetry-ui (diff) | |
parent | Warnings: Fixed a few missing-return warnings in video_core. (diff) | |
download | yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.tar yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.tar.gz yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.tar.bz2 yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.tar.lz yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.tar.xz yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.tar.zst yuzu-647f017c6d42121808aa4522049e3ea8f4d5ed31.zip |
-rw-r--r-- | src/video_core/regs_framebuffer.h | 10 | ||||
-rw-r--r-- | src/video_core/swrasterizer/framebuffer.cpp | 2 | ||||
-rw-r--r-- | src/video_core/swrasterizer/texturing.cpp | 4 |
3 files changed, 10 insertions, 6 deletions
diff --git a/src/video_core/regs_framebuffer.h b/src/video_core/regs_framebuffer.h index a50bd4111..7b565f911 100644 --- a/src/video_core/regs_framebuffer.h +++ b/src/video_core/regs_framebuffer.h @@ -256,10 +256,9 @@ struct FramebufferRegs { return 3; case DepthFormat::D24S8: return 4; - default: - LOG_CRITICAL(HW_GPU, "Unknown depth format %u", format); - UNIMPLEMENTED(); } + + ASSERT_MSG(false, "Unknown depth format %u", format); } // Returns the number of bits per depth component of the specified depth format @@ -270,10 +269,9 @@ struct FramebufferRegs { case DepthFormat::D24: case DepthFormat::D24S8: return 24; - default: - LOG_CRITICAL(HW_GPU, "Unknown depth format %u", format); - UNIMPLEMENTED(); } + + ASSERT_MSG(false, "Unknown depth format %u", format); } INSERT_PADDING_WORDS(0x20); diff --git a/src/video_core/swrasterizer/framebuffer.cpp b/src/video_core/swrasterizer/framebuffer.cpp index 7de3aac75..f34eab6cf 100644 --- a/src/video_core/swrasterizer/framebuffer.cpp +++ b/src/video_core/swrasterizer/framebuffer.cpp @@ -352,6 +352,8 @@ u8 LogicOp(u8 src, u8 dest, FramebufferRegs::LogicOp op) { case FramebufferRegs::LogicOp::OrInverted: return ~src | dest; } + + UNREACHABLE(); }; } // namespace Rasterizer diff --git a/src/video_core/swrasterizer/texturing.cpp b/src/video_core/swrasterizer/texturing.cpp index 4f02b93f2..79b1ce841 100644 --- a/src/video_core/swrasterizer/texturing.cpp +++ b/src/video_core/swrasterizer/texturing.cpp @@ -89,6 +89,8 @@ Math::Vec3<u8> GetColorModifier(TevStageConfig::ColorModifier factor, case ColorModifier::OneMinusSourceBlue: return (Math::Vec3<u8>(255, 255, 255) - values.bbb()).Cast<u8>(); } + + UNREACHABLE(); }; u8 GetAlphaModifier(TevStageConfig::AlphaModifier factor, const Math::Vec4<u8>& values) { @@ -119,6 +121,8 @@ u8 GetAlphaModifier(TevStageConfig::AlphaModifier factor, const Math::Vec4<u8>& case AlphaModifier::OneMinusSourceBlue: return 255 - values.b(); } + + UNREACHABLE(); }; Math::Vec3<u8> ColorCombine(TevStageConfig::Operation op, const Math::Vec3<u8> input[3]) { |