diff options
author | David <25727384+ogniK5377@users.noreply.github.com> | 2020-09-30 13:22:45 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-09-30 13:22:45 +0200 |
commit | f7808f5658ba7ff0d8ea2b62350b4878ecb13672 (patch) | |
tree | 2e5ec11d9a5917399b3ba05a50c1aa711071bf96 | |
parent | Merge pull request #4733 from ReinUsesLisp/game-list-leak (diff) | |
parent | core: Mark GetInstance() as deprecated (diff) | |
download | yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.tar yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.tar.gz yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.tar.bz2 yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.tar.lz yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.tar.xz yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.tar.zst yuzu-f7808f5658ba7ff0d8ea2b62350b4878ecb13672.zip |
-rw-r--r-- | src/core/core.h | 2 | ||||
-rw-r--r-- | src/core/frontend/applets/controller.cpp | 8 | ||||
-rw-r--r-- | src/core/frontend/applets/controller.h | 8 | ||||
-rw-r--r-- | src/core/hle/service/am/applets/applets.cpp | 3 |
4 files changed, 15 insertions, 6 deletions
diff --git a/src/core/core.h b/src/core/core.h index 83ded63a5..27efe30bb 100644 --- a/src/core/core.h +++ b/src/core/core.h @@ -120,7 +120,7 @@ public: * Gets the instance of the System singleton class. * @returns Reference to the instance of the System singleton class. */ - static System& GetInstance() { + [[deprecated("Use of the global system instance is deprecated")]] static System& GetInstance() { return s_instance; } diff --git a/src/core/frontend/applets/controller.cpp b/src/core/frontend/applets/controller.cpp index 4505da758..c5d65f2d0 100644 --- a/src/core/frontend/applets/controller.cpp +++ b/src/core/frontend/applets/controller.cpp @@ -4,7 +4,6 @@ #include "common/assert.h" #include "common/logging/log.h" -#include "core/core.h" #include "core/frontend/applets/controller.h" #include "core/hle/service/hid/controllers/npad.h" #include "core/hle/service/hid/hid.h" @@ -14,6 +13,9 @@ namespace Core::Frontend { ControllerApplet::~ControllerApplet() = default; +DefaultControllerApplet::DefaultControllerApplet(Service::SM::ServiceManager& service_manager_) + : service_manager{service_manager_} {} + DefaultControllerApplet::~DefaultControllerApplet() = default; void DefaultControllerApplet::ReconfigureControllers(std::function<void()> callback, @@ -21,9 +23,7 @@ void DefaultControllerApplet::ReconfigureControllers(std::function<void()> callb LOG_INFO(Service_HID, "called, deducing the best configuration based on the given parameters!"); auto& npad = - Core::System::GetInstance() - .ServiceManager() - .GetService<Service::HID::Hid>("hid") + service_manager.GetService<Service::HID::Hid>("hid") ->GetAppletResource() ->GetController<Service::HID::Controller_NPad>(Service::HID::HidController::NPad); diff --git a/src/core/frontend/applets/controller.h b/src/core/frontend/applets/controller.h index a227f15cd..3e49cdbb9 100644 --- a/src/core/frontend/applets/controller.h +++ b/src/core/frontend/applets/controller.h @@ -8,6 +8,10 @@ #include "common/common_types.h" +namespace Service::SM { +class ServiceManager; +} + namespace Core::Frontend { using BorderColor = std::array<u8, 4>; @@ -39,10 +43,14 @@ public: class DefaultControllerApplet final : public ControllerApplet { public: + explicit DefaultControllerApplet(Service::SM::ServiceManager& service_manager_); ~DefaultControllerApplet() override; void ReconfigureControllers(std::function<void()> callback, ControllerParameters parameters) const override; + +private: + Service::SM::ServiceManager& service_manager; }; } // namespace Core::Frontend diff --git a/src/core/hle/service/am/applets/applets.cpp b/src/core/hle/service/am/applets/applets.cpp index 4e0800f9a..2b626bb40 100644 --- a/src/core/hle/service/am/applets/applets.cpp +++ b/src/core/hle/service/am/applets/applets.cpp @@ -206,7 +206,8 @@ void AppletManager::SetDefaultAppletFrontendSet() { void AppletManager::SetDefaultAppletsIfMissing() { if (frontend.controller == nullptr) { - frontend.controller = std::make_unique<Core::Frontend::DefaultControllerApplet>(); + frontend.controller = + std::make_unique<Core::Frontend::DefaultControllerApplet>(system.ServiceManager()); } if (frontend.e_commerce == nullptr) { |