diff options
author | bunnei <bunneidev@gmail.com> | 2019-04-03 17:48:11 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-04-03 17:48:11 +0200 |
commit | 580e3564c9f2cac47b39fc5c3214271cff0648fb (patch) | |
tree | 88175f150482c61d8d53ef7813956455ce4aac5a /src/core/hle | |
parent | Merge pull request #2314 from lioncash/const (diff) | |
parent | kernel/shared_memory: Remove unused core/memory.h include (diff) | |
download | yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.tar yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.tar.gz yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.tar.bz2 yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.tar.lz yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.tar.xz yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.tar.zst yuzu-580e3564c9f2cac47b39fc5c3214271cff0648fb.zip |
Diffstat (limited to 'src/core/hle')
-rw-r--r-- | src/core/hle/kernel/shared_memory.cpp | 11 | ||||
-rw-r--r-- | src/core/hle/kernel/shared_memory.h | 10 | ||||
-rw-r--r-- | src/core/hle/kernel/svc.cpp | 2 |
3 files changed, 18 insertions, 5 deletions
diff --git a/src/core/hle/kernel/shared_memory.cpp b/src/core/hle/kernel/shared_memory.cpp index 62861da36..f15c5ee36 100644 --- a/src/core/hle/kernel/shared_memory.cpp +++ b/src/core/hle/kernel/shared_memory.cpp @@ -9,7 +9,6 @@ #include "core/hle/kernel/errors.h" #include "core/hle/kernel/kernel.h" #include "core/hle/kernel/shared_memory.h" -#include "core/memory.h" namespace Kernel { @@ -119,7 +118,15 @@ ResultCode SharedMemory::Map(Process& target_process, VAddr address, MemoryPermi ConvertPermissions(permissions)); } -ResultCode SharedMemory::Unmap(Process& target_process, VAddr address) { +ResultCode SharedMemory::Unmap(Process& target_process, VAddr address, u64 unmap_size) { + if (unmap_size != size) { + LOG_ERROR(Kernel, + "Invalid size passed to Unmap. Size must be equal to the size of the " + "memory managed. Shared memory size=0x{:016X}, Unmap size=0x{:016X}", + size, unmap_size); + return ERR_INVALID_SIZE; + } + // TODO(Subv): Verify what happens if the application tries to unmap an address that is not // mapped to a SharedMemory. return target_process.VMManager().UnmapRange(address, size); diff --git a/src/core/hle/kernel/shared_memory.h b/src/core/hle/kernel/shared_memory.h index dab2a6bea..37e18c443 100644 --- a/src/core/hle/kernel/shared_memory.h +++ b/src/core/hle/kernel/shared_memory.h @@ -104,11 +104,17 @@ public: /** * Unmaps a shared memory block from the specified address in system memory + * * @param target_process Process from which to unmap the memory block. - * @param address Address in system memory where the shared memory block is mapped + * @param address Address in system memory where the shared memory block is mapped. + * @param unmap_size The amount of bytes to unmap from this shared memory instance. + * * @return Result code of the unmap operation + * + * @pre The given size to unmap must be the same size as the amount of memory managed by + * the SharedMemory instance itself, otherwise ERR_INVALID_SIZE will be returned. */ - ResultCode Unmap(Process& target_process, VAddr address); + ResultCode Unmap(Process& target_process, VAddr address, u64 unmap_size); /** * Gets a pointer to the shared memory block diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp index 23c768f57..ab10db3df 100644 --- a/src/core/hle/kernel/svc.cpp +++ b/src/core/hle/kernel/svc.cpp @@ -1140,7 +1140,7 @@ static ResultCode UnmapSharedMemory(Handle shared_memory_handle, VAddr addr, u64 return ERR_INVALID_MEMORY_RANGE; } - return shared_memory->Unmap(*current_process, addr); + return shared_memory->Unmap(*current_process, addr, size); } static ResultCode QueryProcessMemory(VAddr memory_info_address, VAddr page_info_address, |